Ticket History #2840: Wrong calling convention

# Sun Feb 29 09:35:12 2004 hartmans (Sam Hartman) - Ticket #2308: - Ticket created

To:	krb5-bugs@mit.edu
Subject:	krb5_principal2salt should be marked KRB5_CALLCONV_WRONG
Date:	Sun, 29 Feb 2004 09:35:03 -0500 (EST)
From:	hartmans@MIT.EDU (Sam Hartman)

Download (untitled) / with headers
text/plain 390B

Looking at a diff of krb5.hin from 1.3 to 1.3.2 I find the following fragment:

Index: krb5.hin
===================================================================
krb5_keytab_entry * );
-#if KRB5_PRIVATE
krb5_error_code krb5_principal2salt
(krb5_context,

No callconv was added and the function seems to be in the windows
export list, so I guess it should be marked callocnv_wrong.

# Mon Dec 20 16:11:39 2004 jaltman (Jeffrey Altman) - Ticket created

From:	jaltman@mit.edu
Subject:	CVS Commit

Download (untitled) / with headers
text/plain 216B

Mark krb5_principal2salt has being declared with the wrong calling convention

To generate a diff of this commit:

cvs diff -r1.138 -r1.139 krb5/src/lib/ChangeLog
cvs diff -r1.40 -r1.41 krb5/src/lib/krb5_32.def

# Mon Dec 20 16:11:41 2004 jaltman (Jeffrey Altman) - Tags pullup added

# Mon Dec 20 16:11:41 2004 jaltman (Jeffrey Altman) - Status changed from 'new' to 'resolved'

# Mon Dec 20 16:11:41 2004 jaltman (Jeffrey Altman) - Target_Version 1.4 added

# Mon Dec 20 16:11:42 2004 jaltman (Jeffrey Altman) - Requestor jaltman (Jeffrey Altman) added

# Mon Dec 20 16:12:11 2004 jaltman (Jeffrey Altman) - Subject changed from '[no subject]' to 'Wrong calling convention'

# Mon Dec 20 16:12:11 2004 jaltman (Jeffrey Altman) - Component krb5-libs added

# Mon Dec 20 16:12:11 2004 jaltman (Jeffrey Altman) - Version_reported 1.4 added

# Tue Dec 21 00:15:30 2004 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	CVS Commit

Download (untitled) / with headers
text/plain 207B

* krb5.hin: Flag krb5_principal2salt as KRB5_CALLCONV_WRONG.

To generate a diff of this commit:

cvs diff -r1.479 -r1.480 krb5/src/include/ChangeLog
cvs diff -r1.174 -r1.175 krb5/src/include/krb5.hin

# Tue Dec 21 15:22:17 2004 tlyu (Taylor Yu) - Version_Fixed 1.4 added

# Tue Dec 21 15:22:18 2004 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	CVS Commit

Download (untitled) / with headers
text/plain 175B

pullup from trunk

To generate a diff of this commit:

cvs diff -r1.471.2.3 -r1.471.2.4 krb5/src/include/ChangeLog
cvs diff -r1.173 -r1.173.4.1 krb5/src/include/krb5.hin

# Tue Dec 21 15:22:49 2004 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	CVS Commit

Download (untitled) / with headers
text/plain 168B

pullup from trunk

To generate a diff of this commit:

cvs diff -r1.137.4.1 -r1.137.4.2 krb5/src/lib/ChangeLog
cvs diff -r1.40 -r1.40.6.1 krb5/src/lib/krb5_32.def

# Tue Dec 21 17:47:11 2004 tlyu (Taylor Yu) - Ticket #2308: - Ticket 2308 MergedInto ticket 2840.

# Wed Dec 16 18:02:44 2015 tlyu (Taylor Yu) - CustomField pullup deleted