Skip Menu |
 

To: krb5-bugs@MIT.EDU
From: Sam Hartman <hartmans@MIT.EDU>
Date: Wed, 02 Feb 2005 16:17:50 -0500
Subject: [Michael Calmer] Patches for MIT Kerberos 1.4
Download (untitled)
message/rfc822 6.7KiB
Return-Path: <mc@suse.de>
Received: from solipsist-nation ([unix socket])
by solipsist-nation (Cyrus v2.1.16-IPv6-Debian-2.1.16-10) with LMTP;
Tue, 01 Feb 2005 07:32:02 -0500
X-Sieve: CMU Sieve 2.2
Return-Path: <mc@suse.de>
Received: from south-station-annex.mit.edu (SOUTH-STATION-ANNEX.MIT.EDU
[18.72.1.2])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(No client certificate requested)
by suchdamage.org (Postfix) with ESMTP id 7A36B13254
for <hartmans@suchdamage.org>; Tue, 1 Feb 2005 07:32:02 -0500 (EST)
Received: from pacific-carrier-annex.mit.edu (PACIFIC-CARRIER-ANNEX.MIT.EDU
[18.7.21.83])j11CW1WS028154
for <hartmans@suchdamage.org>; Tue, 1 Feb 2005 07:32:01 -0500 (EST)
Received: from Cantor.suse.de (ns.suse.de [195.135.220.2])
j11CVx9K027569
for <hartmans@mit.edu>; Tue, 1 Feb 2005 07:31:59 -0500 (EST)
Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8])
(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))
(No client certificate requested)
by Cantor.suse.de (Postfix) with ESMTP id 9706513E62B8
for <hartmans@mit.edu>; Tue, 1 Feb 2005 13:31:54 +0100 (CET)
From: Michael Calmer <mc@suse.de>
To: Sam Hartman <hartmans@mit.edu>
Subject: Patches for MIT Kerberos 1.4
Date: Tue, 1 Feb 2005 13:31:48 +0100
User-Agent: KMail/1.7.1
MIME-Version: 1.0
Content-Type: multipart/signed;
boundary="nextPart1295429.RsZTjP6qv9";
protocol="application/pgp-signature";
micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <200502011331.53706.mc@suse.de>
X-Spam-Score: -4.9
X-Scanned-By: MIMEDefang 2.42
X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on
solipsist-nation.suchdamage.org
X-Spam-Level:
X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham
version=2.64

--nextPart1295429.RsZTjP6qv9
Content-Type: multipart/mixed;
boundary="Boundary-01=_1a3/BJz8blBF30P"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--Boundary-01=_1a3/BJz8blBF30P
Content-Type: text/plain;
charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi,

my name is Michael Calmer and I am the krb5 package maintainer for SUSE Lin=
ux.

I saw the mail thread "Novell's Work on MIT KDC" where you were included. S=
o I=20
think I can send patches to you.=20

krb5-1.4-gcc4.dif :

This patch is required to build krb5 with gcc4.


krb5-1.4-reduce-namespace-polution.dif :

This patch includes only the required "#define" to gssapi.h

Without this patch we had trouble to build samba, because it was a=20

#define HAVE_REGEXP_H 1=20

set. Our samba compiles without regexp but c-files which includes=20
gssapi.h now have this define and try to use it, but it is not available.

I think this could happen also with other software.

It would be nice if you can include these patches in krb5. And maybe start =
a=20
discussion about the gssapi.h problem. Maybe you can find an other way=20
instead of the #define(s) :-)

Thanks.

=2D-=20
MFG

Michael Calmer

=2D-------------------------------------------------------------------------
Michael Calmer
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 N=C3=BCrnberg
T: +49 (0) 911 74053 0
=46: +49 (0) 911 74053575 - Michael.Calmer@suse.com
=2D-------------------------------------------------------------------------

--Boundary-01=_1a3/BJz8blBF30P
Content-Type: text/x-diff;
charset="utf-8";
name="krb5-1.4-gcc4.dif"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
filename="krb5-1.4-gcc4.dif"

=2D-- src/appl/bsd/krlogind.c
+++ src/appl/bsd/krlogind.c 2005/01/28 11:51:50
@@ -833,12 +833,12 @@
fatalperror(f, "failed make_sane_hostname");
if (passwd_req)
execl(login_program, "login", "-p", "-h", rhost_sane,
=2D lusername, 0);
+ lusername, (char*)NULL);
else
execl(login_program, "login", "-p", "-h", rhost_sane,
=2D "-f", lusername, 0);
+ "-f", lusername, (char*)NULL);
#else /* USE_LOGIN_F */
=2D execl(login_program, "login", "-r", rhost_sane, 0);
+ execl(login_program, "login", "-r", rhost_sane, (char*)NULL);
#endif /* USE_LOGIN_F */
syslog(LOG_ERR, "failed exec of %s: %s",
login_program, error_message(errno));
=2D-- src/appl/bsd/krshd.c
+++ src/appl/bsd/krshd.c 2005/01/28 11:49:08
@@ -1521,10 +1521,10 @@
cp =3D pwd->pw_shell;
=20
if (do_encrypt && !strncmp(cmdbuf, "-x ", 3)) {
=2D execl(pwd->pw_shell, cp, "-c", (char *)cmdbuf + 3, 0);
+ execl(pwd->pw_shell, cp, "-c", (char *)cmdbuf + 3, (char*)NULL);
}
else {
=2D execl(pwd->pw_shell, cp, "-c", cmdbuf, 0);
+ execl(pwd->pw_shell, cp, "-c", cmdbuf, (char*)NULL);
}
perror(pwd->pw_shell);
perror(cp);
=2D-- src/appl/bsd/login.c
+++ src/appl/bsd/login.c 2005/01/28 11:52:31
@@ -1861,7 +1861,7 @@
(void) strncpy(tbuf+1, p?(p+1):pwd->pw_shell, sizeof(tbuf) - 1);
tbuf[sizeof(tbuf) - 1] =3D '\0';
=20
=2D execlp(pwd->pw_shell, tbuf, 0);
+ execlp(pwd->pw_shell, tbuf, (char*)NULL);
fprintf(stderr, "login: no shell: ");
perror(pwd->pw_shell);
exit(0);
=2D-- src/appl/telnet/telnet/commands.c
+++ src/appl/telnet/telnet/commands.c 2005/01/28 11:50:17
@@ -1467,9 +1467,9 @@
else
shellname++;
if (argc > 1)
=2D execl(shellp, shellname, "-c", &saveline[1], 0);
+ execl(shellp, shellname, "-c", &saveline[1], (char*)NULL);
else
=2D execl(shellp, shellname, 0);
+ execl(shellp, shellname, (char*)NULL);
perror("Execl");
_exit(1);
}

--Boundary-01=_1a3/BJz8blBF30P
Content-Type: text/x-diff;
charset="utf-8";
name="krb5-1.4-reduce-namespace-polution.dif"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="krb5-1.4-reduce-namespace-polution.dif"

--- src/lib/gssapi/generic/Makefile.in
+++ src/lib/gssapi/generic/Makefile.in 2005/02/01 10:48:04
@@ -42,9 +42,11 @@
h=gss$$$$; $(RM) $$h; \
(echo "/* This is the gssapi.h prologue. */"; \
echo "/* It contains some choice pieces of autoconf.h */"; \
- grep SIZEOF $(BUILDTOP)/include/krb5/autoconf.h; \
- grep 'HAVE_.*_H' $(BUILDTOP)/include/krb5/autoconf.h; \
- grep 'USE_.*_H' $(BUILDTOP)/include/krb5/autoconf.h; \
+ grep SIZEOF_INT $(BUILDTOP)/include/krb5/autoconf.h; \
+ grep SIZEOF_LONG $(BUILDTOP)/include/krb5/autoconf.h; \
+ grep SIZEOF_SHORT $(BUILDTOP)/include/krb5/autoconf.h; \
+ grep HAVE_STDDEF_H $(BUILDTOP)/include/krb5/autoconf.h; \
+ grep HAVE_XOM_H $(BUILDTOP)/include/krb5/autoconf.h; \
echo "/* End of gssapi.h prologue. */"; \
cat $(srcdir)/gssapi.hin )> $$h && \
(set -x; $(MV) $$h $@) ; e=$$?; $(RM) $$h; exit $$e

--Boundary-01=_1a3/BJz8blBF30P--

--nextPart1295429.RsZTjP6qv9
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQBB/3a5rQn+SxpBP/IRAn9sAJ9g9LSfnVS64Dwr3rB4Ph/j9y9x9ACgqy1z
u2X+3XDY1GNovNXrihV36Ig=
=Db0d
-----END PGP SIGNATURE-----

--nextPart1295429.RsZTjP6qv9--
From: Ken Raeburn <raeburn@MIT.EDU>
Subject: Re: [krbdev.mit.edu #2910] [Michael Calmer] Patches for MIT Kerberos 1.4
Date: Wed, 2 Feb 2005 17:06:05 -0500
To: rt-comment@krbdev.mit.edu
RT-Send-Cc:
If we want to clean it up a bit more, we should rename the macros we do
dump into gssapi.h, so they get some GSS* prefix.
From: raeburn@mit.edu
Subject: CVS Commit
* configure.in: Check for xom.h. Set include_xom to a C include directive or
comment, and substitute it in the Makefiles.


To generate a diff of this commit:



cvs diff -r1.78 -r1.79 krb5/src/lib/gssapi/ChangeLog
cvs diff -r1.27 -r1.28 krb5/src/lib/gssapi/configure.in
From: raeburn@mit.edu
Subject: CVS Commit
* Makefile.in (gssapi.h): Change SIZEOF symbols to start with GSS_ when
extracting from autoconf.h. Don't look for HAVE_ or USE_ symbols. Add
${include_xom} to the prologue.
(include_xom): New variable.
* gssapi.h: Always include stddef.h unconditionally.
(GSS_SIZEOF_INT, GSS_SIZEOF_LONG, GSS_SIZEOF_SHORT): Don't define.


To generate a diff of this commit:



cvs diff -r1.142 -r1.143 krb5/src/lib/gssapi/generic/ChangeLog
cvs diff -r1.73 -r1.74 krb5/src/lib/gssapi/generic/Makefile.in
cvs diff -r1.20 -r1.21 krb5/src/lib/gssapi/generic/gssapi.hin
From: raeburn@mit.edu
Subject: CVS Commit
* gssapi.hin: Don't conditionally include xom.h here.


To generate a diff of this commit:



cvs diff -r1.143 -r1.144 krb5/src/lib/gssapi/generic/ChangeLog
cvs diff -r1.21 -r1.22 krb5/src/lib/gssapi/generic/gssapi.hin
From: raeburn@mit.edu
Subject: CVS Commit
To generate a diff of this commit:



cvs diff -r1.74 -r1.75 krb5/src/lib/gssapi/generic/Makefile.in
From: raeburn@mit.edu
Subject: CVS Commit
* gssapi.hin: (GSS_SIZEOF_INT, GSS_SIZEOF_LONG, GSS_SIZEOF_SHORT): Don't
define except on Windows.


To generate a diff of this commit:



cvs diff -r1.144 -r1.145 krb5/src/lib/gssapi/generic/ChangeLog
cvs diff -r1.22 -r1.23 krb5/src/lib/gssapi/generic/gssapi.hin
Closing. All relevant changes were made in other tickets.