Ticket History #3147: Memory leak in krb5_get_init

# Fri Aug 12 11:24:03 2005 guest (Public Submitter) - Ticket created

Subject:

Memory leak in krb5_get_init_creds()

Download (untitled) / with headers
text/plain 548B

There is a memory leak in function krb5_get_init_creds() (lib/krb5/krb/get_in_tkt.c

The function calls krb5_libdefaults_string() at two places and forgets to free the returned
string tempstr. It frees the string only when the call to kr5_string_to_deltat() fails and the
function is going to return error. When the conversion is successful, memory is leaked.

Found when using the Kerberos.framework on Mac OS X 10.4.2 and checking our application
with the "leaks" utility. Version 1.4 is used there.

Attached is a patch to file get_in_tkt.c

Download get_in_tkt.patch
application/octet-stream 374B

Message body not shown because it is not plain text.

# Sun Aug 14 09:08:33 2005 tlyu (Taylor Yu) - Queue changed from kfw to krb5

# Sun Aug 14 09:08:56 2005 tlyu (Taylor Yu) - Component krb5-libs added

# Sun Aug 14 09:08:57 2005 tlyu (Taylor Yu) - Version_reported 1.4 added

# Sun Aug 14 09:08:57 2005 tlyu (Taylor Yu) - Target_Version 1.4.3 added

# Mon Aug 15 20:38:21 2005 tlyu (Taylor Yu) - Status changed from 'new' to 'resolved'

# Mon Aug 15 20:38:22 2005 tlyu (Taylor Yu) - Tags pullup added

# Mon Aug 15 20:38:22 2005 tlyu (Taylor Yu) - Given to tlyu (Taylor Yu)

# Mon Aug 15 20:38:23 2005 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	CVS Commit

Download (untitled) / with headers
text/plain 284B

* get_in_tkt.c (krb5_get_init_creds): Free tempstr on non-error
returns from krb5_string_to_deltat() to avoid memory leak.

To generate a diff of this commit:

cvs diff -r5.475 -r5.476 krb5/src/lib/krb5/krb/ChangeLog
cvs diff -r5.111 -r5.112 krb5/src/lib/krb5/krb/get_in_tkt.c

# Wed Sep 07 18:19:26 2005 tlyu (Taylor Yu) - Version_Fixed 1.4.3 added

# Wed Sep 07 18:19:26 2005 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	CVS Commit

Download (untitled) / with headers
text/plain 202B

pullup r17330 from trunk (minus cvs2svn metadata)

Commit By: tlyu

Revision: 17374
Changed Files:
U branches/krb5-1-4/src/lib/krb5/krb/ChangeLog
U branches/krb5-1-4/src/lib/krb5/krb/get_in_tkt.c

# Wed Dec 16 18:02:45 2015 tlyu (Taylor Yu) - CustomField pullup deleted

Ticket History #3147: Memory leak in krb5_get_init_creds()