Ticket History #3276: local array of structures not declared static

# Tue Dec 06 18:08:34 2005 Denis Vlasenko <vda@ilport.com.ua> - Ticket created

From:	Denis Vlasenko <vda@ilport.com.ua>
To:	krb5-bugs@mit.edu
Date:	Tue, 6 Dec 2005 17:19:57 +0200
Subject:	local array of structures not declared static

Download (untitled) / with headers
text/plain 1.2KiB

krb5-1.4.3/src/lib/kadm5/logger.c:

Â Â Â Â Â Â Â Â Â Â Â Â /*Â Â Â Â Â Â Â Â Â Â Â Â Â * If there is a facility present, then parse that.Â Â Â Â Â Â Â Â Â Â Â Â Â */Â Â Â Â Â Â Â Â Â Â Â Â if (cp2) {Â Â Â Â Â Â Â Â Â Â Â Â Â Â const struct {Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â const char *name;Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â int value;Â Â Â Â Â Â Â Â Â Â Â Â Â Â } facilities[] = {Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â { "AUTH", Â Â Â LOG_AUTH Â Â Â Â },#ifdef Â LOG_AUTHPRIVÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â { "AUTHPRIV", Â LOG_AUTHPRIV Â Â },#endif Â /* LOG_AUTHPRIV */#ifdef Â LOG_KERNÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â { "KERN", Â Â Â LOG_KERN Â Â Â Â },#endif Â /* LOG_KERN */

Shouldn't we add "static" before "const" here?--vda

# Mon Jun 19 19:33:39 2006 raeburn (Ken Raeburn) - Status changed from 'new' to 'resolved'

# Mon Jun 19 19:33:40 2006 raeburn (Ken Raeburn) - Given to raeburn (Ken Raeburn)

# Mon Jun 19 19:33:40 2006 raeburn (Ken Raeburn) - Correspondence added

From:	raeburn@mit.edu
Subject:	SVN Commit

Download (untitled) / with headers
text/plain 136B

Make local const array of structures static too.

Commit By: raeburn

Revision: 18165
Changed Files:
U trunk/src/lib/kadm5/logger.c

# Fri Oct 27 18:57:10 2006 tlyu (Taylor Yu) - Version_Fixed 1.6 added