Ticket History #339: krlogind bug -- HOME=/

From wolfgang@wsrcc.com Mon Jan 13 15:08:19 1997
Received: from MIT.EDU (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id PAA07737 for <bugs@RT-11.MIT.EDU>; Mon, 13 Jan 1997 15:08:19 -0500
Received: from capsicum.wsrcc.com by MIT.EDU with SMTP
id AA11460; Mon, 13 Jan 97 15:08:16 EST
Received: (from wolfgang@localhost)
by capsicum.wsrcc.com (8.8.4/8.8.4)
id MAA11681; Mon, 13 Jan 1997 12:08:05 -0800 (PST)
Message-Id: <199701132008.MAA11681@capsicum.wsrcc.com>
Date: Mon, 13 Jan 1997 12:08:05 -0800 (PST)
From: Wolfgang Rupprecht <wolfgang@wsrcc.com>
Reply-To: wolfgang@wsrcc.com
To: krb5-bugs@MIT.EDU
Subject: krb5-appl
X-Send-Pr-Version: 3.99

W S Rupprecht Computer Consulting, Fremont CA
System: NetBSD capsicum.wsrcc.com 1.2 NetBSD 1.2 (WSRCC) #5: Fri Jan 10 16:01:14 PST 1997 wolfgang@capsicum.wsrcc.com:/usr/src/sys/arch/i386/compile/WSRCC i386



logging into a krb5 1.0 host running netbsd 1.2 incorrectly sets
one HOME=/


kinit
rlogin -x hostname
env


Notes: the initial environment passed on to indetd is:

HOME=/ PATH=/sbin:/bin:/usr/sbin:/usr/bin inetd

login.c needs to be a bit more forceful in mashing the HOME=/ environment
setting. The one-line (one bit???) diff is included.

cd /u/src/krb5-1.0/src/appl/bsd/
diff -c /u/src/krb5-1.0/src/appl/bsd/login.c.\~1\~ /u/src/krb5-1.0/src/appl/bsd/login.c
*** /u/src/krb5-1.0/src/appl/bsd/login.c.~1~ Sun Nov 24 20:45:21 1996
--- /u/src/krb5-1.0/src/appl/bsd/login.c Mon Jan 13 09:43:29 1997
***************
*** 1835,1841 ****
if (ccname)
setenv("KRB5CCNAME", ccname, 0);

! setenv("HOME", pwd->pw_dir, 0);
setenv("PATH", LPATH, 0);
setenv("USER", pwd->pw_name, 0);
setenv("SHELL", pwd->pw_shell, 0);
--- 1835,1841 ----
if (ccname)
setenv("KRB5CCNAME", ccname, 0);

! setenv("HOME", pwd->pw_dir, 1);
setenv("PATH", LPATH, 0);
setenv("USER", pwd->pw_name, 0);
setenv("SHELL", pwd->pw_shell, 0);

Diff finished at Mon Jan 13 11:37:36


From: deengert@anl.gov
To: krb5-bugs@MIT.EDU
Cc: wolfgang@wsrcc.com
Subject: Re: krb5-appl/339: krb5-appl - klogind uses -p
Date: Mon, 13 Jan 1997 16:19:57 -0600


Douglas E. Engert <DEEngert@anl.gov>
Argonne National Laboratory
9700 South Cass Avenue
Argonne, Illinois 60439
(630) 252-5444
Krb5-1.0 on all platforms.

System: AIX pembroke 1 4 000300234600

There have been a number of problems reported about login.krb5
and its use of the setenv for PATH, HOME and other variables.
The problem does not appear to be with login.krb5, but rather
with a misuse of the -p option to login.krb5 to preserve the
environment.

The problem appears to be in klogind which calls login.krb5 with
the -p option but does not first setup the environment. i.e.
it leaves the PATH and HOME as set by inetd. On SunOS 4.1.3,
the PATH was set to /bin:/usr/bin:/usr/etc, rather then
/usr/ucb:/bin:/usr/bin. From other comments on some systems
HOME may be set to "/".

Telnetd on the other hand also calls login.krb5, but it first
cleans up the environment.




Rather the just changing setenv(x,y,0) to setenv(x,y,1) in
login.krb5, klogind should either not use the -p option,
or it should get the environment set to be passed correctly.

State-Changed-From-To: open-closed
State-Changed-By: tlyu
State-Changed-When: Sun Mar 16 02:32:05 1997
State-Changed-Why:

This is the same bug as krb5-appl/326; followups should go there.