Skip Menu |
 

Subject: krb5-1.5: fix uninitialized vars
This patch fixes some compiler warnings about uninitialized vars in:
src/appl/gssftp/ftpd/ftpd.c
src/appl/telnet/libtelnet/kerberos5.c
src/kdc/do_tgs_req.c
src/lib/krb5/asn.1/krb5_decode.c
src/plugins/kdb/db2/libdb2/hash/dbm.c
--- src/appl/gssftp/ftpd/ftpd.c
+++ src/appl/gssftp/ftpd/ftpd.c 2005/10/28 10:30:57
@@ -2390,7 +2390,9 @@
char service_name[MAXHOSTNAMELEN+10];
char **gservice;
struct hostent *hp;
-
+ stat_maj = 0;
+ accept_maj = 0;
+ acquire_maj = 0;

kerror = radix_encode(adata, gout_buf, &length, 1);
if (kerror) {
--- src/appl/telnet/libtelnet/kerberos5.c
+++ src/appl/telnet/libtelnet/kerberos5.c 2005/10/28 10:32:04
@@ -260,6 +260,7 @@
if (telnet_krb5_realm != NULL) {
krb5_data rdata;

+ rdata.magic = 0;
rdata.length = strlen(telnet_krb5_realm);
rdata.data = (char *) malloc(rdata.length + 1);
if (rdata.data == NULL) {
--- src/kdc/do_tgs_req.c
+++ src/kdc/do_tgs_req.c 2005/10/28 10:33:09
@@ -474,6 +474,8 @@
goto cleanup;
}
enc_tkt_transited.tr_type = KRB5_DOMAIN_X500_COMPRESS;
+ enc_tkt_transited.magic = 0;
+ enc_tkt_transited.tr_contents.magic = 0;
enc_tkt_transited.tr_contents.data = 0;
enc_tkt_transited.tr_contents.length = 0;
enc_tkt_reply.transited = enc_tkt_transited;
--- src/lib/krb5/asn.1/krb5_decode.c
+++ src/lib/krb5/asn.1/krb5_decode.c 2005/10/28 10:34:04
@@ -526,6 +526,7 @@
setup();
alloc_field(*rep,krb5_safe);
clear_field(rep,checksum);
+ tmpbody.magic = 0;

check_apptag(20);
{ begin_structure();
--- src/plugins/kdb/db2/libdb2/hash/dbm.c
+++ src/plugins/kdb/db2/libdb2/hash/dbm.c 2005/10/28 10:35:59
@@ -90,6 +90,7 @@
if (__cur_db == NULL) {
no_open_db();
item.dptr = 0;
+ item.dsize = 0;
return (item);
}
return (kdb2_dbm_fetch(__cur_db, key));
@@ -103,6 +104,7 @@
if (__cur_db == NULL) {
no_open_db();
item.dptr = 0;
+ item.dsize = 0;
return (item);
}
return (kdb2_dbm_firstkey(__cur_db));
@@ -117,6 +119,7 @@
if (__cur_db == NULL) {
no_open_db();
item.dptr = 0;
+ item.dsize = 0;
return (item);
}
return (kdb2_dbm_nextkey(__cur_db));
From: tlyu@mit.edu
Subject: SVN Commit
Apply patch from Michael Calmer to fix some uninitialized variables.

* src/appl/gssftp/ftpd/ftpd.c (auth_data): Initialize stat_maj,
accept_maj, acquire_maj.

* src/appl/telnet/libtelnet/kerberos5.c (kerberos5_send):
Intialize rdata.

* src/kdc/do_tgs_req.c (process_tgs_req): Initialize magic and
tr_contents.magic.

* src/lib/krb5/asn.1/krb5_decode.c (decode_krb5_safe_with_body):
Initialize tmpbody.magic.

* src/plugins/kdb/db2/libdb2/hash/dbm.c (kdb2_fetch)
(kdb2_firstkey, kdb2_nextkey): Initialize dsize.


Commit By: tlyu



Revision: 18404
Changed Files:
U trunk/src/appl/gssftp/ftpd/ftpd.c
U trunk/src/appl/telnet/libtelnet/kerberos5.c
U trunk/src/kdc/do_tgs_req.c
U trunk/src/lib/krb5/asn.1/krb5_decode.c
U trunk/src/plugins/kdb/db2/libdb2/hash/dbm.c
From: tlyu@mit.edu
Subject: SVN Commit
pull up r18404 from trunk

r18404@cathode-dark-space: tlyu | 2006-08-02 16:51:50 -0400
ticket: 3904
tags: pullup

Apply patch from Michael Calmer to fix some uninitialized variables.

* src/appl/gssftp/ftpd/ftpd.c (auth_data): Initialize stat_maj,
accept_maj, acquire_maj.

* src/appl/telnet/libtelnet/kerberos5.c (kerberos5_send):
Intialize rdata.

* src/kdc/do_tgs_req.c (process_tgs_req): Initialize magic and
tr_contents.magic.

* src/lib/krb5/asn.1/krb5_decode.c (decode_krb5_safe_with_body):
Initialize tmpbody.magic.

* src/plugins/kdb/db2/libdb2/hash/dbm.c (kdb2_fetch)
(kdb2_firstkey, kdb2_nextkey): Initialize dsize.




Commit By: tlyu



Revision: 18408
Changed Files:
_U branches/krb5-1-5/
U branches/krb5-1-5/src/appl/gssftp/ftpd/ftpd.c
U branches/krb5-1-5/src/appl/telnet/libtelnet/kerberos5.c
U branches/krb5-1-5/src/kdc/do_tgs_req.c
U branches/krb5-1-5/src/lib/krb5/asn.1/krb5_decode.c
U branches/krb5-1-5/src/plugins/kdb/db2/libdb2/hash/dbm.c
I get these errors trying to compile on AIX 5.3 with gcc 3.3.2.

***********************
fake-addrinfo.c: In function `my_fake_getaddrinfo':
fake-addrinfo.c:1212: error: `my_h_ent' undeclared (first use in this
function)
fake-addrinfo.c:1212: error: (Each undeclared identifier is reported
only once
fake-addrinfo.c:1212: error: for each function it appears in.)
fake-addrinfo.c: At top level:
fake-addrinfo.c:1331: warning: missing braces around initializer
fake-addrinfo.c:1331: warning: (near initialization for
`krb5int_in6addr_any.u6_addr')
fake-addrinfo.c:1317: warning: `krb5int_lock_fac' defined but not used
fake-addrinfo.c:1326: warning: `krb5int_unlock_fac' defined but not used
***********************

mark