Ticket History #426: read_env_vars_from_file() ignores parameter

From donn@u.washington.edu Mon May 19 20:19:50 1997
Received: from MIT.EDU (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id UAA27698 for <bugs@RT-11.MIT.EDU>; Mon, 19 May 1997 20:19:49 -0400
Received: from melville.u.washington.edu by MIT.EDU with SMTP
id AA24509; Mon, 19 May 97 20:19:48 EDT
Received: (from donn@localhost)
by melville.u.washington.edu (8.8.4+UW97.04/8.8.4+UW97.05)
id RAA68978; Mon, 19 May 1997 17:19:47 -0700
Message-Id: <199705200019.RAA68978@melville.u.washington.edu>
Date: Mon, 19 May 1997 17:19:47 -0700
From: donn@u.washington.edu
Reply-To: donn@u.washington.edu
To: krb5-bugs@MIT.EDU
Subject: appl/bsd/login.c:read_env_vars_from_file() ignores parameter
X-Send-Pr-Version: 3.99

University Computing Services
University of Washington

System: AIX melville 2 4 000010504900


read_env_vars_from_file() ignores its parameter, and always
opens /etc/environment.
Thought experiment should suffice.
Context diff appended.
-----------------------------
*** src/appl/bsd/login.c.dist Wed Apr 2 23:35:11 1997
--- src/appl/bsd/login.c Mon May 19 16:59:13 1997
***************
*** 1106,1112 ****
char *p, *eq;
char tbuf[MAXPATHLEN+2];

! if ((fp = fopen("/etc/environment", "r")) != NULL) {
while (fgets(tbuf, sizeof(tbuf), fp)) {
if (tbuf[0] == '#')
continue;
--- 1106,1112 ----
char *p, *eq;
char tbuf[MAXPATHLEN+2];

! if ((fp = fopen(filename, "r")) != NULL) {
while (fgets(tbuf, sizeof(tbuf), fp)) {
if (tbuf[0] == '#')
continue;