Ticket History #433: pty cloning fix

From jwessel@zap.cso.uiuc.edu Sun Jun 1 12:42:07 1997
Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id MAA15071 for <bugs@RT-11.MIT.EDU>; Sun, 1 Jun 1997 12:42:06 -0400
Received: from zap.cso.uiuc.edu by MIT.EDU with SMTP
id AA17212; Sun, 1 Jun 97 12:41:14 EDT
Received: (from jwessel@localhost) by zap.cso.uiuc.edu (8.7.5/8.7.3) id LAA12791; Sun, 1 Jun 1997 11:41:39 -0500 (CDT)
Message-Id: <199706011641.LAA12791@zap.cso.uiuc.edu>
Date: Sun, 1 Jun 1997 11:41:39 -0500 (CDT)
From: Jason Wessel <jwessel@zap.cso.uiuc.edu>
Reply-To: jwessel@zap.cso.uiuc.edu
To: krb5-bugs@MIT.EDU
Subject: pty cloning fails under HPUX10.20
X-Send-Pr-Version: 3.99

University of Illinois
HPUX-CC
System: HP-UX zap B.10.20 A 9000/780 2008162731 two-user license


There is a leading space in the statement to clone the pty
and it induces some bizzare behavior. Sometimes it will
succeed and other times it will fail. I noticed the problem
the first time it tried to allocate a pty of the type /dev/pty/*

Removing the space causes it to work all the time.
Compile with the native HPUX-10.20 compiler.
*** getpty.c.orig Sun Jun 1 11:19:27 1997
--- getpty.c Sun Jun 1 11:19:35 1997
***************
*** 63,69 ****
return 0;
#else /*HAVE__GETPTY*/

! *fd = open(" /dev/ptym/clone", O_RDWR|O_NDELAY); /* HPUX*/
#ifdef HAVE_STREAMS
if (*fd < 0) *fd = open("/dev/ptmx",O_RDWR|O_NDELAY); /*Solaris*/
#endif
--- 63,69 ----
return 0;
#else /*HAVE__GETPTY*/

! *fd = open("/dev/ptym/clone", O_RDWR|O_NDELAY); /* HPUX*/
#ifdef HAVE_STREAMS
if (*fd < 0) *fd = open("/dev/ptmx",O_RDWR|O_NDELAY); /*Solaris*/
#endif

From: "Theodore Y. Ts'o" <tytso@MIT.EDU>
To: krb5-bugs@MIT.EDU, jwessel@zap.cso.uiuc.edu
Cc: krb5-unassigned@RT-11.MIT.EDU, gnats-admin@RT-11.MIT.EDU,
krb5-prs@RT-11.MIT.EDU
Subject: Re: krb5-libs/433: pty cloning fails under HPUX10.20
Date: Tue, 3 Jun 1997 23:06:29 -0400

Date: Sun, 1 Jun 1997 11:41:39 -0500 (CDT)
From: Jason Wessel <jwessel@zap.cso.uiuc.edu>

There is a leading space in the statement to clone the pty
and it induces some bizzare behavior. Sometimes it will
succeed and other times it will fail. I noticed the problem
the first time it tried to allocate a pty of the type /dev/pty/*

Removing the space causes it to work all the time.

Thanks for noticing this problem! It's been fixed in our development
sources.

- Ted

State-Changed-From-To: open-closed
State-Changed-By: tytso
State-Changed-When: Tue Jun 3 23:12:24 1997
State-Changed-Why: Fix checked into development sources