Ticket History #4587: Change preauth plugin context scope and lifetimes

From krb5-bugs-incoming-bounces@PCH.mit.edu Wed Nov 1 17:22:38 2006
Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90]) by krbdev.mit.edu (8.9.3p2) with ESMTP
id RAA04505; Wed, 1 Nov 2006 17:22:38 -0500 (EST)
Received: from pch.mit.edu (pch.mit.edu [127.0.0.1])
by pch.mit.edu (8.13.6/8.12.8) with ESMTP id kA1MM8t5023983;
Wed, 1 Nov 2006 17:22:08 -0500
Received: from pacific-carrier-annex.mit.edu (PACIFIC-CARRIER-ANNEX.MIT.EDU
[18.7.21.83])
by pch.mit.edu (8.13.6/8.12.8) with ESMTP id kA1MM7Nj023977
for <krb5-bugs-incoming@PCH.mit.edu>; Wed, 1 Nov 2006 17:22:07 -0500
Received: from barracuda.edu (M24-004-BARRACUDA-2.MIT.EDU [18.7.7.112])
by pacific-carrier-annex.mit.edu (8.13.6/8.9.2) with ESMTP id
kA1MLoXm019075
for <krb5-bugs@mit.edu>; Wed, 1 Nov 2006 17:21:50 -0500 (EST)
Received: from citi.umich.edu (citi.umich.edu [141.211.133.111])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(No client certificate requested)
by barracuda.edu (Spam Firewall) with ESMTP id 08AA27398
for <krb5-bugs@mit.edu>; Wed, 1 Nov 2006 17:21:49 -0500 (EST)
Received: from rock.citi.umich.edu (rock.citi.umich.edu [141.211.133.90])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(No client certificate requested)
by citi.umich.edu (Postfix) with ESMTP id 1C0611BB6B
for <krb5-bugs@mit.edu>; Wed, 1 Nov 2006 17:21:49 -0500 (EST)
Received: (from kwc@localhost)
by rock.citi.umich.edu (8.13.7/8.13.1/Submit) id kA1MLmpZ019569;
Wed, 1 Nov 2006 17:21:48 -0500
Date: Wed, 1 Nov 2006 17:21:48 -0500
Message-Id: <200611012221.kA1MLmpZ019569@rock.citi.umich.edu>
To: krb5-bugs@mit.edu
Subject: Change preauth plugin context scope and lifetimes
From: kwc@citi.umich.edu
X-send-pr-version: 3.99
X-Spam-Score: 0.55
X-Spam-Flag: NO
X-Scanned-By: MIMEDefang 2.42
X-BeenThere: krb5-bugs-incoming@mailman.mit.edu
X-Mailman-Version: 2.1.6
Precedence: list
Reply-To: kwc@citi.umich.edu
Sender: krb5-bugs-incoming-bounces@PCH.mit.edu
Errors-To: krb5-bugs-incoming-bounces@PCH.mit.edu


University of Michigan

System: Linux rock.citi.umich.edu 2.6.18-rc5-CITI_NFS4_ALL-1 #2 SMP Mon Oct 30 21:49:49 EST 2006 i686 i686 i386 GNU/Linux
Architecture: i686


Modify the preath plugin interface so that a plugin's context is global to all the
modules within a plugin. Also, change the client-side interface so that the preauth
plugin context lives the lifetime of a krb5_context. This will allow future changes
that can set plugin parameters. The client side request context lives the lifetime
of a call to krb5_get_init_creds().

Make the sample preauth plugins buildable outside the source tree.

Fix minor memory leak in sort_krb5_padata_sequence().

Add a prototype for krb5_do_preauth_tryagain() and change the plugin interface.

Modify the preath plugin interface so that a plugin's context is
global to all the modules within a plugin. Also, change the
client-side interface so that the preauth plugin context (once
created) lives the lifetime of a krb5_context. This will allow
future changes that can set plugin parameters. The client side
request context lives the lifetime of a call to krb5_get_init_creds().

Make the sample preauth plugins buildable outside the source tree.

Fix minor memory leak in sort_krb5_padata_sequence().

Add a prototype for krb5_do_preauth_tryagain() and change the plugin
interface.

Incorporates fixes from Nalin Dahyabhai <nalin@redhat.com> for leaks
of the function table pointers (rt #4566) and fix KDC crash (rt #4567)


Commit By: coffman



Revision: 18754
Changed Files:
U trunk/src/include/k5-int.h
U trunk/src/include/krb5/preauth_plugin.h
U trunk/src/kdc/kdc_preauth.c
U trunk/src/lib/krb5/krb/get_in_tkt.c
U trunk/src/lib/krb5/krb/init_ctx.c
U trunk/src/lib/krb5/krb/preauth2.c
U trunk/src/lib/krb5/os/init_os_ctx.c
U trunk/src/plugins/preauth/cksum_body/Makefile.in
A trunk/src/plugins/preauth/cksum_body/cksum_body_main.c
D trunk/src/plugins/preauth/cksum_body/src/cksum_body.c
U trunk/src/plugins/preauth/wpse/Makefile.in
D trunk/src/plugins/preauth/wpse/src/wpse.c
A trunk/src/plugins/preauth/wpse/wpse_main.c

pull up r18754 from trunk

r18754@cathode-dark-space: coffman | 2006-11-01 17:40:30 -0500
ticket: 4566
ticket: 4567
ticket: 4587
Target_Version: 1.6
Tags: pullup

Modify the preath plugin interface so that a plugin's context is
global to all the modules within a plugin. Also, change the
client-side interface so that the preauth plugin context (once
created) lives the lifetime of a krb5_context. This will allow
future changes that can set plugin parameters. The client side
request context lives the lifetime of a call to krb5_get_init_creds().

Make the sample preauth plugins buildable outside the source tree.

Fix minor memory leak in sort_krb5_padata_sequence().

Add a prototype for krb5_do_preauth_tryagain() and change the plugin
interface.

Incorporates fixes from Nalin Dahyabhai <nalin@redhat.com> for leaks
of the function table pointers (rt #4566) and fix KDC crash (rt #4567)




Commit By: tlyu



Revision: 18777
Changed Files:
_U branches/krb5-1-6/
U branches/krb5-1-6/src/include/k5-int.h
U branches/krb5-1-6/src/include/krb5/preauth_plugin.h
U branches/krb5-1-6/src/kdc/kdc_preauth.c
U branches/krb5-1-6/src/lib/krb5/krb/get_in_tkt.c
U branches/krb5-1-6/src/lib/krb5/krb/init_ctx.c
U branches/krb5-1-6/src/lib/krb5/krb/preauth2.c
U branches/krb5-1-6/src/lib/krb5/os/init_os_ctx.c
U branches/krb5-1-6/src/plugins/preauth/cksum_body/Makefile.in
A branches/krb5-1-6/src/plugins/preauth/cksum_body/cksum_body_main.c
D branches/krb5-1-6/src/plugins/preauth/cksum_body/src/cksum_body.c
U branches/krb5-1-6/src/plugins/preauth/wpse/Makefile.in
D branches/krb5-1-6/src/plugins/preauth/wpse/src/wpse.c
A branches/krb5-1-6/src/plugins/preauth/wpse/wpse_main.c