Ticket History #462: bug in get_in_tkt.c

From brezak@apollo.hp.com Thu Aug 21 12:19:48 1997
Received: from MIT.EDU (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id MAA22594 for <bugs@RT-11.MIT.EDU>; Thu, 21 Aug 1997 12:19:48 -0400
Received: from relay.hp.com by MIT.EDU with SMTP
id AA10767; Thu, 21 Aug 97 12:19:07 EDT
Received: from it_750.ch.apollo.hp.com (it_750.ch.apollo.hp.com [15.22.48.2])
by relay.hp.com (8.8.6/8.8.5) with ESMTP id JAA00791;
Thu, 21 Aug 1997 09:19:04 -0700 (PDT)
Received: from tisbury (tisbury.ch.apollo.hp.com) by it_750.ch.apollo.hp.com
id AA250970342; Thu, 21 Aug 1997 12:19:02 -0400
Message-Id: <3.0.3.32.19970821121846.00a07870@pop-e3.ch.apollo.hp.com>
Date: Thu, 21 Aug 1997 12:18:46 -0400
From: John Brezak <brezak@apollo.hp.com>
To: krb5-bugs@MIT.EDU, krbdev@MIT.EDU
Subject: bug in get_in_tkt.c


Responsible-Changed-From-To: gnats-admin->tlyu
Responsible-Changed-By: tlyu
Responsible-Changed-When: Fri Aug 29 16:42:27 1997
Responsible-Changed-Why:

refiled

State-Changed-From-To: open-closed
State-Changed-By: tlyu
State-Changed-When: Fri Aug 29 16:42:35 1997
State-Changed-Why:

fixed
src/lib/krb5/krb/get_in_tkt.c 5.72


From: Tom Yu <tlyu@MIT.EDU>
To: brezak@apollo.hp.com
Cc: krb5-bugs@MIT.EDU
Subject: Re: krb5-libs/462: bug in get_in_tkt.c
Date: Fri, 29 Aug 1997 16:46:26 -0400

Thanks for your report; I've committed the changes.

---Tom
padata needs to be initialized before krb5_os_localaddr() incase it fails.

*** get_in_tkt.c.orig Wed Aug 13 01:31:14 1997
--- get_in_tkt.c Wed Aug 13 01:31:18 1997
***************
*** 401,412 ****
request.msg_type = KRB5_AS_REQ;
request.addresses = 0;
request.ktype = 0;
if (addrs)
request.addresses = (krb5_address **) addrs;
else
if ((retval = krb5_os_localaddr(context, &request.addresses)))
goto cleanup;
- request.padata = 0;
request.kdc_options = options;
request.client = creds->client;
request.server = creds->server;
--- 401,412 ----
request.msg_type = KRB5_AS_REQ;
request.addresses = 0;
request.ktype = 0;
+ request.padata = 0;
if (addrs)
request.addresses = (krb5_address **) addrs;
else
if ((retval = krb5_os_localaddr(context, &request.addresses)))
goto cleanup;
request.kdc_options = options;
request.client = creds->client;
request.server = creds->server;


=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
John Brezak Internet: brezak@ch.hp.com
Hewlett Packard/Apollo Phone: (508) 436-4915
300 Apollo Drive Fax: (508) 436-5140
Chelmsford, Massachusetts, USA