Ticket History #47: [daemon@ATHENA.MIT.EDU : mc68000 bogusness in lib/rpc/xdr

# Mon Aug 19 14:19:39 2002 The RT System itself - Default: Import/ changed from (no value) to (no value)

Download (untitled) / with headers
text/plain 4.1KiB

From bjaspan@MIT.EDU Tue Oct 1 12:14:54 1996
Received: from MIT.EDU (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id MAA02838 for <bugs@RT-11.MIT.EDU>; Tue, 1 Oct 1996 12:14:54 -0400
Received: from DUN-DUN-NOODLES.MIT.EDU by MIT.EDU with SMTP
id AA15433; Tue, 1 Oct 96 12:14:53 EDT
Received: by DUN-DUN-NOODLES.MIT.EDU (5.x/4.7) id AA27820; Tue, 1 Oct 1996 12:14:52 -0400
Message-Id: <9610011614.AA27820@DUN-DUN-NOODLES.MIT.EDU>
Date: Tue, 1 Oct 1996 12:14:52 -0400
From: "Barry Jaspan" <bjaspan@MIT.EDU>
Reply-To: Ken Hornstein <kenh@cmf.nrl.navy.mil>
To: krb5-bugs@MIT.EDU
Subject: [daemon@ATHENA.MIT.EDU : mc68000 bogusness in lib/rpc/xdr_stdio.c]

Show quoted text

>Number: 47
>Category: krb5-libs
>Synopsis: [daemon@ATHENA.MIT.EDU : mc68000 bogusness in lib/rpc/xdr_stdio.c]
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: bjaspan
>State: closed
>Class: sw-bug
>Submitter-Id: unknown
>Arrival-Date: Tue Oct e 12:15:00 EDT 1996
>Last-Modified: Wed Oct e 13:22:37 EST 1996
>Originator:
>Organization:
>Release: beta-7
>Environment:
>Description:
>How-To-Repeat:
>Fix:
>Audit-Trail:

From: "Barry Jaspan" <bjaspan@MIT.EDU>
To: krb5-bugs@MIT.EDU
Cc: Subject: Re: pending/47: [daemon@ATHENA.MIT.EDU : Re: mc68000 bogusness in lib/rpc/xdr_stdio.c]
Date: Tue, 1 Oct 1996 12:24:58 -0400

------- Forwarded transaction

[8162] daemon@ATHENA.MIT.EDU (Dima Ruban) Kerberos 09/30/96 17:13 (54 lines)
Subject: Re: mc68000 bogusness in lib/rpc/xdr_stdio.c
From: "Dima Ruban" <dima@burka.rdy.com>
Date: Mon, 30 Sep 1996 13:57:40 -0700
In-Reply-To: Ken Hornstein <kenh@cmf.nrl.navy.mil>
"mc68000 bogusness in lib/rpc/xdr_stdio.c" (Sep 30, 3:06pm)
To: Ken Hornstein <kenh@cmf.nrl.navy.mil>, kerberos@MIT.EDU

On Sep 30, 3:06pm, Ken Hornstein wrote:

Show quoted text

> Subject: mc68000 bogusness in lib/rpc/xdr_stdio.c
> I happened to be building beta 7 today on a Motorola box, and the build
> choked in lib/rpc/xdr_stdio.c, in this function (around line 126):
>
> static bool_t
> xdrstdio_putlong(xdrs, lp)
> XDR *xdrs;
> long *lp;
> {
>
> #ifndef mc68000
> rpc_int32 mycopy = htonl((rpc_int32)*lp);
> #endif
> if (fwrite((caddr_t)&mycopy, sizeof(rpc_int32), 1, (FILE

*)xdrs->x_priva

Show quoted text

> te) != 1)
> return (FALSE);
> return (TRUE);
> }
>
> Obviously, if mc68000 _is_ defined, this doesn't compile :-) Is this just
> leftover cruft from Sun, or what?

It should be something like this:

static bool_t
xdrstdio_putlong(xdrs, lp)
XDR *xdrs;
long *lp;
{

#ifndef mc68000
long mycopy = htonl(*lp);
lp = &mycopy;
#endif
if (fwrite((caddr_t)lp, sizeof(long), 1, (FILE *)xdrs->x_private) != 1)
return (FALSE);
return (TRUE);
}

Show quoted text

>
> --Ken
>-- End of excerpt from Ken Hornstein

-- dima
--[8162]--

------- End forwarded transaction

Responsible-Changed-From-To: gnats-admin->bjaspan
Responsible-Changed-By: hartmans
Responsible-Changed-When: Tue Oct 1 15:52:29 1996
Responsible-Changed-Why:

State-Changed-From-To: open-closed
State-Changed-By: bjaspan
State-Changed-When: Wed Oct 30 13:22:20 1996
State-Changed-Why:

Fixed. Files:

lib/rpc/ChangeLog
lib/rpc/xdr_stdio.c

Show quoted text

>Unformatted:

------- Forwarded transaction

[8160] daemon@ATHENA.MIT.EDU (Ken Hornstein) Kerberos 09/30/96 15:31 (26 lines)
Subject: mc68000 bogusness in lib/rpc/xdr_stdio.c
To: kerberos@MIT.EDU
Date: Mon, 30 Sep 1996 15:06:58 -0400
From: Ken Hornstein <kenh@cmf.nrl.navy.mil>

I happened to be building beta 7 today on a Motorola box, and the build
choked in lib/rpc/xdr_stdio.c, in this function (around line 126):

static bool_t
xdrstdio_putlong(xdrs, lp)
XDR *xdrs;
long *lp;
{

#ifndef mc68000
rpc_int32 mycopy = htonl((rpc_int32)*lp);
#endif
if (fwrite((caddr_t)&mycopy, sizeof(rpc_int32), 1, (FILE *)xdrs->x_priva
te) != 1)
return (FALSE);
return (TRUE);
}

Obviously, if mc68000 _is_ defined, this doesn't compile :-) Is this just
leftover cruft from Sun, or what?

--Ken
--[8160]--

------- End forwarded transaction

# Mon Aug 19 14:19:39 2002 The RT System itself - Component krb5-libs added

# Wed Mar 12 00:30:01 2003 tlyu (Taylor Yu) - Version_Fixed 1.2 added

Ticket History #47: [daemon@ATHENA.MIT.EDU : mc68000 bogusness in lib/rpc/xdr_stdio.c]