Ticket History #470: make check fails because isprint(0xd0) etc is true?

# Mon Aug 19 14:14:02 2002 The RT System itself - Ticket #471: - Default: Import/ changed from (no value) to (no value)

Download (untitled) / with headers
text/plain 27.9KiB

Message body is not shown because it is too large.

# Mon Aug 19 14:14:03 2002 The RT System itself - Ticket #471: - Component pending added

# Mon Aug 19 14:24:43 2002 The RT System itself - Default: Import/ changed from (no value) to (no value)

Download (untitled) / with headers
text/plain 248.7KiB

Message body is not shown because it is too large.

# Mon Aug 19 14:24:44 2002 The RT System itself - Component krb5-build added

# Thu Jan 30 23:45:04 2003 raeburn (Ken Raeburn) - Ticket #471: - Ticket 471 MergedInto ticket 470.

# Fri Jan 31 00:16:34 2003 raeburn (Ken Raeburn) - Status changed from 'new' to 'open'

# Fri Jan 31 00:16:34 2003 raeburn (Ken Raeburn) - Comments added

Subject:

make check fails because high-bit chars passed isprint()

Download (untitled) / with headers
text/plain 693B

After decoding the attachments, I found that the output from
tests/asn.1/krb5_encode_test was different from the expected output in
one key way: in the ASCII dumps, characters with the high bit set were
being output instead of using "." as a placeholder for non-printing
characters.

I don't believe I have ever seen this problem, but I think it could
arise again. The behavior of isprint is influenced by the current
locale, so some of these high-bit characters could become printing
characters. Probably the right thing to do is add a test for values
under 127 (since it's an unsigned char value). Or we could use
something like 'setlocale(LC_CTYPE,"C")' to force "normal"
interpretation.

# Fri Jan 31 00:17:43 2003 raeburn (Ken Raeburn) - Subject changed from 'make check fails ' to 'make check fails because isprint(0xd0) etc is true?'

# Fri Oct 24 15:22:17 2008 tlyu (Taylor Yu) - Priority changed from '50' to '25'

# Tue Dec 31 14:51:27 2013 ghudson@mit.edu (Greg Hudson) - Status changed from 'open' to 'resolved'

# Tue Dec 31 14:51:27 2013 ghudson@mit.edu (Greg Hudson) - Comments added

Download (untitled) / with headers
text/plain 219B

We haven't had any reports of this in a long time. Since the ASN.1 tests
do not call setlocale(), isprint() should be using C locale semantics
(per C99 section 7.11.1.1 paragraph 4, and probably similar text in C89).

# Tue Dec 31 14:51:37 2013 ghudson@mit.edu (Greg Hudson) - Tags nochange added