Ticket History #486: syntax bug in libupdate

From norton@alum.mit.edu Sun Nov 2 19:57:22 1997
Received: from MIT.EDU (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id TAA19186 for <bugs@RT-11.MIT.EDU>; Sun, 2 Nov 1997 19:57:22 -0500
Received: from zoom.realtime.net by MIT.EDU with SMTP
id AA23062; Sun, 2 Nov 97 19:57:20 EST
Received: from alum.mit.edu..realtime.net (norton@max1-30.ip.realtime.net [205.238.168.30]) by zoom.bga.com (8.6.12/8.6.12) with SMTP id SAA11800; Sun, 2 Nov 1997 18:57:15 -0600
Message-Id: <199711030057.SAA11800@zoom.bga.com>
Date: Sun, 2 Nov 1997 18:57:15 -0600
From: Joseph W Norton <norton@alum.mit.edu>
Reply-To: norton@alum.mit.edu
To: krb5-bugs@MIT.EDU
Cc: norton@alum.mit.edu
Subject: krb5 bug
X-Send-Pr-Version: 3.99

none
System: Linux namaste 2.0.30 #2 Sun Oct 19 13:58:26 CDT 1997 i586 unknown
Architecture: i586

2 missing ";" characters in shell script

build with debian linux/gnu

*** krb5-1.0pl1/src/util/libupdate.orig Mon Oct 27 19:04:45 1997
--- krb5-1.0pl1/src/util/libupdate Sun Nov 2 14:18:46 1997
***************
*** 25,31 ****
shift
shift
for dir do
! oblists="$oblists${oblists+ }$dir/$oblist"
done

stamp=`echo $library | sed -e 's/.a$/.stamp/'`
--- 25,31 ----
shift
shift
for dir do
! oblists="$oblists${oblists+ }$dir/$oblist";
done

stamp=`echo $library | sed -e 's/.a$/.stamp/'`
***************
*** 41,44 ****

$rmcmd
$arcmd $library `for dir do (cd $dir; cat $oblist | \
! sed -e "s;^\([^ ]*\);$dir/\1;g" -e "s; \([^ ]*\); $dir/\1;g") do
ne`
--- 41,44 ----

$rmcmd
$arcmd $library `for dir do (cd $dir; cat $oblist | \
! sed -e "s;^\([^ ]*\);$dir/\1;g" -e "s; \([^ ]*\); $dir/\1;g"); d
one`


--
Joe Norton
email:norton@alum.mit.edu


State-Changed-From-To: open-closed
State-Changed-By: tytso
State-Changed-When: Thu Nov 13 20:30:39 1997
State-Changed-Why: Fix checked into tree.

From peter@dillinger.lbjhs.austin.isd.tenet.edu Sun Feb 22 17:34:09 1998
Received: from MIT.EDU (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id RAA27438 for <bugs@RT-11.MIT.EDU>; Sun, 22 Feb 1998 17:34:09 -0500
Received: from dillinger.lbjhs.austin.isd.tenet.edu by MIT.EDU with SMTP
id AA01517; Sun, 22 Feb 98 17:34:07 EST
Received: (from peter@localhost)
by dillinger.lbjhs.austin.isd.tenet.edu (8.8.8/8.8.8/Debian/GNU) id QAA01328;
Sun, 22 Feb 1998 16:34:05 -0600
Message-Id: <199802222234.QAA01328@dillinger.lbjhs.austin.isd.tenet.edu>
Date: Sun, 22 Feb 1998 16:34:05 -0600
From: Peter Jensen <peter@dillinger.lbjhs.austin.isd.tenet.edu>
Reply-To: peter@dillinger.lbjhs.austin.isd.tenet.edu
To: krb5-bugs@MIT.EDU
Cc: leverich@stac.org, jon@stac.org, chedlin@stac.org
Subject: typo in src/util/libupdate.sh
X-Send-Pr-Version: 3.99

STAC, Lyndon Baines Johnson High School
System: Linux dillinger 2.0.33 #5 Mon Feb 9 10:23:11 CST 1998 i586 unknown
Architecture: i586
Shell interpreter is GNU bash, version 2.00.0(1)-release
(i586-debian-linux).
Make is GNU Make version 3.75.
Line 44 off krb5-1.0.5/src/util/libupdate.sh appears to be missing a
semicolon immediately before "done". The original line is:
sed -e "s;^\([^ ]*\);$dir/\1;g" -e "s; \([^ ]*\); $dir/\1;g") done
And the corrected statement is:
sed -e "s;^\([^ ]*\);$dir/\1;g" -e "s; \([^ ]*\); $dir/\1;g"); done

When compiling Kerberos, the libupdate utility fails to stop the make when
it fails, thus generating an 8 byte "libpty.a". Later on, the bsd utilities
depend on stuff found in libpty.a (and it dies complaining about undefined
references to "init_pty()" and such.)

I'm not sure if this problem is universal or if my shell is just broken.
Please advise me if I'm confused. Thanks.
make ;)
*** krb5-1.0.5/src/util/libupdate.sh.orig Sun Feb 22 16:05:48 1998
--- krb5-1.0.5/src/util/libupdate.sh Sun Feb 22 16:06:00 1998
***************
*** 41,44 ****

$rmcmd
$arcmd $library `for dir do (cd $dir; cat $oblist | \
! sed -e "s;^\([^ ]*\);$dir/\1;g" -e "s; \([^ ]*\); $dir/\1;g") done`
--- 41,44 ----

$rmcmd
$arcmd $library `for dir do (cd $dir; cat $oblist | \
! sed -e "s;^\([^ ]*\);$dir/\1;g" -e "s; \([^ ]*\); $dir/\1;g"); done`