Ticket History #520: rlogin fails due to pty

# Mon Aug 19 14:23:42 2002 The RT System itself - Default: Import/ changed from (no value) to (no value)

Download (untitled) / with headers
text/plain 2.4KiB

From kenstir@kinsman.senteinc.com Tue Dec 30 15:01:51 1997
Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id PAA11711 for <bugs@RT-11.MIT.EDU>; Tue, 30 Dec 1997 15:01:46 -0500
Received: from kinsman.senteinc.com by MIT.EDU with SMTP
id AA08327; Tue, 30 Dec 97 15:02:02 EST
Received: (from kenstir@localhost) by kinsman.senteinc.com (8.8.0/8.8.0) id PAA24412; Tue, 30 Dec 1997 15:01:44 -0500
Message-Id: <199712302001.PAA24412@kinsman.senteinc.com>
Date: Tue, 30 Dec 1997 15:01:44 -0500
From: kenstir@senteinc.com
Reply-To: kcox@senteinc.com
To: krb5-bugs@MIT.EDU
Subject: rlogin fails due to pty_getpty() bug
X-Send-Pr-Version: 3.99

Show quoted text

>Number: 520
>Category: pty
>Synopsis: rlogin fails due to pty_getpty() bug
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: tlyu
>State: closed
>Class: sw-bug
>Submitter-Id: unknown
>Arrival-Date: Tue Dec 30 15:02:01 EST 1997
>Last-Modified: Tue Jan 06 18:04:36 EST 1998
>Originator: Ken Cox
>Organization:

--
Kenneth H. Cox
Software Guy
Sente, Inc.

Show quoted text

>Release: krb5-1.0.4
>Environment:

System: Linux kinsman.senteinc.com 2.0.30 #1 Wed Jun 4 15:02:33 EDT 1997 i586 unknown
Architecture: i586

Show quoted text

>Description:

The klogind daemon was failing in pty_getpty() because it was
trying to open ptys with names of "/dev/ptyXp0". Here is a patch which
fixes the problem.
Oddly enough, this bug was not present in the krb5-1.0pl1 release.

Show quoted text

>How-To-Repeat:

Show quoted text

>Fix:

--- util/pty/getpty.c.dist Thu Dec 4 22:47:37 1997
+++ util/pty/getpty.c Tue Dec 30 14:43:32 1997
@@ -111,8 +111,10 @@
} else {
for (cp = "pqrstuvwxyzPQRST";*cp; cp++) {
sprintf(slavebuf,"/dev/ptyXX");
- slavebuf[sizeof("/dev/pty")] = *cp;
- slavebuf[sizeof("/dev/ptyp")] = '0';
+ /*slavebuf[sizeof("/dev/pty")] = *cp;*/
+ slavebuf[sizeof("/dev/pty") - 1] = *cp; /* 12/30/97 kenstir */
+ /*slavebuf[sizeof("/dev/ptyp")] = '0';*/
+ slavebuf[sizeof("/dev/ptyp") - 1] = '0'; /* 12/30/97 kenstir */
if (stat(slavebuf, &stb) < 0)
break;
for (i = 0; i < 16; i++) {

Show quoted text

>Audit-Trail:

Responsible-Changed-From-To: hartmans->tlyu
Responsible-Changed-By: tlyu
Responsible-Changed-When: Tue Jan 6 18:03:38 1998
Responsible-Changed-Why:

State-Changed-From-To: open-closed
State-Changed-By: tlyu
State-Changed-When: Tue Jan 6 18:03:44 1998
State-Changed-Why:

Already fixed in our sources.

Show quoted text

>Unformatted:

# Mon Aug 19 14:23:42 2002 The RT System itself - Component pty added

# Mon Aug 19 14:23:42 2002 The RT System itself - Version_reported 1.0.4 added

# Wed Mar 12 00:31:30 2003 tlyu (Taylor Yu) - Version_Fixed 1.2 added

Ticket History #520: rlogin fails due to pty_getpty() bug