From hmkash@ARL.MIL Thu Jan 15 16:53:50 1998
Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id QAA19515 for <bugs@RT-11.MIT.EDU>; Thu, 15 Jan 1998 16:53:45 -0500
Received: from raven.arl.mil by MIT.EDU with SMTP
id AA29994; Thu, 15 Jan 98 16:53:47 EST
Message-Id: <9801151645.aa16154@RAVEN.ARL.MIL>
Date: Thu, 15 Jan 98 16:45:41 EST
From: hmkash@ARL.MIL
Sender: hmkash@ARL.MIL
Reply-To: hmkash@ARL.MIL
To: krb5-bugs@MIT.EDU
Cc: jamesf@ARL.MIL, kenh@cmf.nrl.navy.mil
Subject: Size of pibuf[] in krlogind.c too small
X-Send-Pr-Version: 3.99
System: IRIX64 raven 6.2 03131016 IP19
Pine 3.95
After upgrading from krb5b3 to krb5-1.0.4 the pine email reader would
only display partial screen updates. Using the IRIX par utility, it
was found that pine was displaying the screen with one write() call.
The number of characters in the write() would depend on the screen
size but was usually greater than 1024. Looking through krlogind.c
it was found that pipuf[] and fibuf[] were both of size 1024. In
the krb5b3 source, pibuf was allocated as pibuf[16*1024+1] and
fibuf as fibuf[1024]. Changing pibuf[] in the krb5-1.0.4 source
fixed the problem with pine. A Solaris 2.5.1 host did not have
the problems with pine prior to the modification. Using telnet
into the IRIX 6.2 host also did not have the problem.
Rlogin to an IRIX 6.x host with an 80x24 size screen or larger and run
pine.
Increase size of pibuf[] in krlogind.c.
From: Ken Hornstein <kenh@cmf.nrl.navy.mil>
To: hmkash@ARL.MIL
Cc: krb5-bugs@MIT.EDU, jamesf@ARL.MIL
Subject: Re: krb5-appl/527: Size of pibuf[] in krlogind.c too small
Date: Thu, 15 Jan 1998 17:01:50 -0500
You know, this looks like (to me) a bug in the IRIX pseudo-tty
implementation of packet mode. This doesn't surprise me, as there are
other bugs in the IRIX pseudo-tty packet mode implementation as well.
Perhaps the right thing to do is not use packet mode on Irix?
--Ken
From: "Howard M. Kash III" <hmkash@ARL.MIL>
To: krb5-bugs@MIT.EDU, krb5-unassigned@RT-11.MIT.EDU
Cc: Subject: Re: krb5-appl/527: Size of pibuf[] in krlogind.c too small
Date: Thu, 15 Jan 98 17:41:02 EST
Additional info:
Solaris 2.5.1 <stdio.h>:
#define BUFSIZ 1024
Irix 6.2 <stdio.h>:
#define BUFSIZ 4096
pibuf[] should probably be allocated as pibuf[BUFSIZ]. The telnet
source appears to use BUFSIZ for all of its allocations, thus it
didn't have the problem.
Howard
State-Changed-From-To: open-closed
State-Changed-By: tlyu
State-Changed-When: Tue Jan 20 21:47:55 1998
State-Changed-Why:
Fixed in the trunk.
src/appl/bsd/krlogind.c 5.96
Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id QAA19515 for <bugs@RT-11.MIT.EDU>; Thu, 15 Jan 1998 16:53:45 -0500
Received: from raven.arl.mil by MIT.EDU with SMTP
id AA29994; Thu, 15 Jan 98 16:53:47 EST
Message-Id: <9801151645.aa16154@RAVEN.ARL.MIL>
Date: Thu, 15 Jan 98 16:45:41 EST
From: hmkash@ARL.MIL
Sender: hmkash@ARL.MIL
Reply-To: hmkash@ARL.MIL
To: krb5-bugs@MIT.EDU
Cc: jamesf@ARL.MIL, kenh@cmf.nrl.navy.mil
Subject: Size of pibuf[] in krlogind.c too small
X-Send-Pr-Version: 3.99
Show quoted text
>Number: 527
>Category: krb5-appl
>Synopsis: Size of pibuf[] in krlogind.c too small
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: krb5-unassigned
>State: closed
>Class: sw-bug
>Submitter-Id: unknown
>Arrival-Date: Thu Jan 15 16:54:00 EST 1998
>Last-Modified: Tue Jan 20 21:48:41 EST 1998
>Originator: James Fielding, Howard Kash
>Organization:
U.S. Army Research Lab>Category: krb5-appl
>Synopsis: Size of pibuf[] in krlogind.c too small
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: krb5-unassigned
>State: closed
>Class: sw-bug
>Submitter-Id: unknown
>Arrival-Date: Thu Jan 15 16:54:00 EST 1998
>Last-Modified: Tue Jan 20 21:48:41 EST 1998
>Originator: James Fielding, Howard Kash
>Organization:
Show quoted text
>Release: krb5-1.0.4
>Environment:
>Environment:
System: IRIX64 raven 6.2 03131016 IP19
Pine 3.95
Show quoted text
>Description:
After upgrading from krb5b3 to krb5-1.0.4 the pine email reader would
only display partial screen updates. Using the IRIX par utility, it
was found that pine was displaying the screen with one write() call.
The number of characters in the write() would depend on the screen
size but was usually greater than 1024. Looking through krlogind.c
it was found that pipuf[] and fibuf[] were both of size 1024. In
the krb5b3 source, pibuf was allocated as pibuf[16*1024+1] and
fibuf as fibuf[1024]. Changing pibuf[] in the krb5-1.0.4 source
fixed the problem with pine. A Solaris 2.5.1 host did not have
the problems with pine prior to the modification. Using telnet
into the IRIX 6.2 host also did not have the problem.
Show quoted text
>How-To-Repeat:
Rlogin to an IRIX 6.x host with an 80x24 size screen or larger and run
pine.
Show quoted text
>Fix:
Increase size of pibuf[] in krlogind.c.
Show quoted text
>Audit-Trail:
From: Ken Hornstein <kenh@cmf.nrl.navy.mil>
To: hmkash@ARL.MIL
Cc: krb5-bugs@MIT.EDU, jamesf@ARL.MIL
Subject: Re: krb5-appl/527: Size of pibuf[] in krlogind.c too small
Date: Thu, 15 Jan 1998 17:01:50 -0500
Show quoted text
>After upgrading from krb5b3 to krb5-1.0.4 the pine email reader would
>only display partial screen updates. Using the IRIX par utility, it
>was found that pine was displaying the screen with one write() call.
>The number of characters in the write() would depend on the screen
>size but was usually greater than 1024. Looking through krlogind.c
>only display partial screen updates. Using the IRIX par utility, it
>was found that pine was displaying the screen with one write() call.
>The number of characters in the write() would depend on the screen
>size but was usually greater than 1024. Looking through krlogind.c
You know, this looks like (to me) a bug in the IRIX pseudo-tty
implementation of packet mode. This doesn't surprise me, as there are
other bugs in the IRIX pseudo-tty packet mode implementation as well.
Perhaps the right thing to do is not use packet mode on Irix?
--Ken
From: "Howard M. Kash III" <hmkash@ARL.MIL>
To: krb5-bugs@MIT.EDU, krb5-unassigned@RT-11.MIT.EDU
Cc: Subject: Re: krb5-appl/527: Size of pibuf[] in krlogind.c too small
Date: Thu, 15 Jan 98 17:41:02 EST
Show quoted text
> Thank you very much for your problem report.
> It has the internal identification `krb5-appl/527'.
> The individual assigned to look at your
> report is: krb5-unassigned.
>
> It has the internal identification `krb5-appl/527'.
> The individual assigned to look at your
> report is: krb5-unassigned.
>
> >Category: krb5-appl
> >Responsible: krb5-unassigned
> >Synopsis: Size of pibuf[] in krlogind.c too small
> >Arrival-Date: Thu Jan 15 16:54:00 EST 1998
> >Responsible: krb5-unassigned
> >Synopsis: Size of pibuf[] in krlogind.c too small
> >Arrival-Date: Thu Jan 15 16:54:00 EST 1998
Additional info:
Solaris 2.5.1 <stdio.h>:
#define BUFSIZ 1024
Irix 6.2 <stdio.h>:
#define BUFSIZ 4096
pibuf[] should probably be allocated as pibuf[BUFSIZ]. The telnet
source appears to use BUFSIZ for all of its allocations, thus it
didn't have the problem.
Howard
State-Changed-From-To: open-closed
State-Changed-By: tlyu
State-Changed-When: Tue Jan 20 21:47:55 1998
State-Changed-Why:
Fixed in the trunk.
src/appl/bsd/krlogind.c 5.96
Show quoted text
>Unformatted: