Ticket History #5447: tail portability bug in k5srvutil

# Sat Feb 24 19:12:27 2007 <rbasch@MIT.EDU> - Ticket created

To:	source-reviewers@MIT.EDU
Subject:	tail portability bug in k5srvutil
Date:	Sat, 24 Feb 2007 18:12:40 -0500
From:	Robert A Basch <rbasch@MIT.EDU>
Cc:	krb5-bugs@MIT.EDU

Download (untitled) / with headers
text/plain 962B

"k5srvutil change" failed on a RHEL-5 beta machine, where the tail
command, in an apparent effort to be more POSIX compliant, no longer
recognizes the "+<number>" option. This patch fixes the problem by
making use of awk's NR variable, thereby obviating the use of tail.
(Note that the POSIX tail's "-n" option is not portable, and in
particular is not accepted on Solaris),

Index: k5srvutil.sh
===================================================================
RCS file: /afs/dev.mit.edu/source/repository/third/krb5/src/kadmin/cli/k5srvutil.sh,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 k5srvutil.sh
--- k5srvutil.sh 27 Feb 2004 04:01:52 -0000 1.1.1.1
+++ k5srvutil.sh 24 Feb 2007 21:41:47 -0000
@@ -4,7 +4,7 @@
# returns a list of principals in the keytab
# sorted and uniquified
list_princs() {
- klist -k $keytab | tail +4 | awk '{print $2}' | sort | uniq
+ klist -k $keytab | awk '(NR > 3) {print $2}' | sort | uniq
}

set_command() {

# Mon Feb 26 11:00:59 2007 ghudson@mit.edu (Greg Hudson) - Ticket #5448: - Ticket created

Subject:	Re: tail portability bug in k5srvutil
From:	Greg Hudson <ghudson@MIT.EDU>
To:	Robert A Basch <rbasch@MIT.EDU>
Date:	Sat, 24 Feb 2007 22:13:35 -0500
Cc:	source-reviewers@MIT.EDU, krb5-bugs@MIT.EDU

Download (untitled) / with headers
text/plain 254B

Yay.

The FSF upstream maintainers have an odd desire to deprecate tail +n,
and every so often a distribution version falls prey to it. My guess is
that Red Hat will fix it if someone reports it as a bug, but we can also
work around it easily enough.

# Mon Feb 26 14:18:46 2007 tlyu (Taylor Yu) - Ticket #5448: - Ticket 5448 MergedInto ticket 5447.

# Tue Mar 13 20:52:51 2007 raeburn (Ken Raeburn) - Status changed from 'new' to 'resolved'

# Tue Mar 13 20:52:52 2007 raeburn (Ken Raeburn) - Given to raeburn (Ken Raeburn)

# Tue Mar 13 20:52:52 2007 raeburn (Ken Raeburn) - Correspondence added

From:	raeburn@mit.edu
Subject:	SVN Commit

Download (untitled) / with headers
text/plain 223B

Fix tail portability problem by adding an expression test to the
existing awk invocation instead. Patch from Robert Basch at MIT.

Commit By: raeburn

Revision: 19225
Changed Files:
U trunk/src/kadmin/cli/k5srvutil.sh

# Mon Apr 09 22:44:58 2007 tlyu (Taylor Yu) - Component krb5-admin added

# Mon Apr 09 22:44:58 2007 tlyu (Taylor Yu) - Target_Version 1.6.1 added

# Mon Apr 09 22:44:58 2007 tlyu (Taylor Yu) - Tags pullup added

# Tue Apr 10 17:51:39 2007 tlyu (Taylor Yu) - Version_Fixed 1.6.1 added

# Tue Apr 10 17:51:39 2007 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	SVN Commit

Download (untitled) / with headers
text/plain 368B

pull up r19225 from trunk

r19225@cathode-dark-space: raeburn | 2007-03-13 20:52:47 -0400
ticket: 5447

Fix tail portability problem by adding an expression test to the
existing awk invocation instead. Patch from Robert Basch at MIT.

Commit By: tlyu

Revision: 19414
Changed Files:
_U branches/krb5-1-6/
U branches/krb5-1-6/src/kadmin/cli/k5srvutil.sh

# Wed Dec 16 18:02:49 2015 tlyu (Taylor Yu) - CustomField pullup deleted