Skip Menu |
 

History Show all quoted text — Show full headers
# Mon Jul 30 10:36:51 2007 kpkoch (Kevin Koch) - Ticket created
Subject: NIM update inconsistency when deleting credentials
Download (untitled) / with headers
text/plain 784B
Configuration:

Windows XP SP2 or Vista.

NIM from either MIT KfW Beta 2 or from secure-
endpoints.com/binaries/mit-kfw-3-2-0/kfw-3-2-0.msi.


Test scenario:

Obtain default identity credentials.

Display the NIM GUI, standard view.

Destroy the default identity credentials, either by clicking the
Destroy toolbar button or by right clicking the tray icon and select
Destroy | default identity.

The silhouette disappears from the tray icon but the time remaining is
still shown on the second line of the default identity display.

Clicking the Refresh View toolbar button or selecting View | Refresh
from the menu does not update the display.

Cycling to the advanced view and back to the standard view via F7 F7
updates the default identity display with a blank second line.
# Wed Aug 01 18:19:02 2007 jaltman (Jeffrey Altman) - AdminCc jaltman (Jeffrey Altman) added
# Thu Aug 02 09:18:08 2007 kpkoch (Kevin Koch) - Correspondence added
Download (untitled) / with headers
text/plain 470B
Patch to fix Refresh button behavior:

Index: mainwnd.c
===================================================================
--- mainwnd.c (revision 19739)
+++ mainwnd.c (working copy)
@@ -261,6 +261,7 @@
case KHUI_ACTION_VIEW_REFRESH:
khm_cred_refresh();
InvalidateRect(khm_hwnd_main_cred, NULL, FALSE);
+ khui_action_trigger(KHUI_ACTION_LAYOUT_RELOAD, NULL);
return 0;

case KHUI_ACTION_PASSWD_ID:
# Thu Aug 02 09:44:13 2007 Jeffrey Altman <jaltman@secure-endpoints.com> - Correspondence added
Date: Thu, 02 Aug 2007 09:44:56 -0400
From: Jeffrey Altman <jaltman@secure-endpoints.com>
To: kfw-bugs@mit.edu
Subject: Re: [krbdev.mit.edu #5604] NIM update inconsistency when deleting credentials
RT-Send-Cc:
Download (untitled) / with headers
text/plain 1KiB
Kevin Koch via RT wrote:
Show quoted text
> Patch to fix Refresh button behavior:
>
> Index: mainwnd.c
> ===================================================================
> --- mainwnd.c (revision 19739)
> +++ mainwnd.c (working copy)
> @@ -261,6 +261,7 @@
> case KHUI_ACTION_VIEW_REFRESH:
> khm_cred_refresh();
> InvalidateRect(khm_hwnd_main_cred, NULL, FALSE);
> + khui_action_trigger(KHUI_ACTION_LAYOUT_RELOAD, NULL);
> return 0;
>
> case KHUI_ACTION_PASSWD_ID:
>
As I pointed out previously, this is the wrong change. What you are
doing here is simulating the effect that switching back and forth
between the basic and advanced views would have. You have not actually
identified the cause of the problem.

The question to be answered is "why is the basic view credential list
not being updated?"

More than likely there is a race condition somewhere. If you find that,
you will probably fix several of your tickets. Covering over the
problem with a superficial change like this will just make it harder to
find the true issue.
Download smime.p7s
application/x-pkcs7-signature 3.2KiB

Message body not shown because it is not plain text.

# Thu Aug 02 09:48:22 2007 Jeffrey Altman <jaltman@secure-endpoints.com> - Correspondence added
Date: Thu, 02 Aug 2007 09:49:23 -0400
From: Jeffrey Altman <jaltman@secure-endpoints.com>
To: kfw-bugs@mit.edu
Subject: Re: [krbdev.mit.edu #5604] NIM update inconsistency when deleting credentials
RT-Send-Cc:
Download (untitled) / with headers
text/plain 964B
Kevin Koch via RT wrote:
Show quoted text
> Patch to fix Refresh button behavior:
>
> Index: mainwnd.c
> ===================================================================
> --- mainwnd.c (revision 19739)
> +++ mainwnd.c (working copy)
> @@ -261,6 +261,7 @@
> case KHUI_ACTION_VIEW_REFRESH:
> khm_cred_refresh();
> InvalidateRect(khm_hwnd_main_cred, NULL, FALSE);
> + khui_action_trigger(KHUI_ACTION_LAYOUT_RELOAD, NULL);
> return 0;
>
> case KHUI_ACTION_PASSWD_ID:
>
As I pointed out yesterday, this is the wrong patch to apply. What this
patch will do is reload the layout and the credentials as if the user
had toggled from basic to advanced and back. What you have done is
altered the timing which means you have covered up a race condition but
have not actually solved the real cause of the problem that you are
experiencing in this ticket and perhaps several others.

Find the race, fix the race.
Download smime.p7s
application/x-pkcs7-signature 3.2KiB

Message body not shown because it is not plain text.

# Thu Aug 09 10:52:20 2007 kpkoch (Kevin Koch) - Given to kpkoch (Kevin Koch)
# Thu Aug 09 10:52:20 2007 kpkoch (Kevin Koch) - Status changed from 'new' to 'resolved'
# Thu Aug 09 10:52:21 2007 kpkoch (Kevin Koch) - Correspondence added
From: kpkoch@mit.edu
Subject: SVN Commit
Download (untitled) / with headers
text/plain 315B
Simulate changing views when the REFRESH action is run and when credentials are updated.

This makes the symptoms go away but does not solve whatever the underlying problem is.
Commit By: kpkoch



Revision: 19770
Changed Files:
U trunk/src/windows/identity/ui/mainwnd.c
U trunk/src/windows/identity/ui/timer.c
# Thu Aug 09 13:34:42 2007 Jeffrey Altman <jaltman@secure-endpoints.com> - Correspondence added
Date: Thu, 09 Aug 2007 13:36:14 -0400
From: Jeffrey Altman <jaltman@secure-endpoints.com>
To: rt@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #5604] SVN Commit
RT-Send-Cc:
Download (untitled) / with headers
text/plain 764B
Kevin Koch via RT wrote:
Show quoted text
> Simulate changing views when the REFRESH action is run and when credentials are updated.
>
> This makes the symptoms go away but does not solve whatever the underlying problem is.
> Commit By: kpkoch
>
>
>
> Revision: 19770
> Changed Files:
> U trunk/src/windows/identity/ui/mainwnd.c
> U trunk/src/windows/identity/ui/timer.c

While it may be necessary for MIT to ship with this change for their
next release, the change should be pulled immediately following the
release tag in order to ensure that the real problem is addressed in
a future release. The existence of this change is going to make it
harder for the real problem to be fixed.

Please open a new ticket for the real problem and have it
reference ticket 5604.
Download smime.p7s
application/x-pkcs7-signature 3.2KiB

Message body not shown because it is not plain text.

# Thu Aug 09 15:07:34 2007 kpkoch (Kevin Koch) - Queue changed from kfw to krb5
# Thu Aug 09 15:09:46 2007 kpkoch (Kevin Koch) - Component windows added
# Thu Aug 09 15:09:46 2007 kpkoch (Kevin Koch) - Target_Version 1.6.3 added
# Thu Aug 09 15:09:46 2007 kpkoch (Kevin Koch) - Tags pullup added
# Thu Aug 09 19:02:19 2007 tlyu (Taylor Yu) - Version_Fixed 1.6.3 added
# Thu Aug 09 19:02:19 2007 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: SVN Commit
Download (untitled) / with headers
text/plain 509B
pull up r19770 from trunk

r19770@cathode-dark-space: kpkoch | 2007-08-09 10:52:15 -0400
Ticket: 5604
Tags: pullup
Target_Version: 1.6.3

Simulate changing views when the REFRESH action is run and when credentials are updated.

This makes the symptoms go away but does not solve whatever the underlying problem is.


Commit By: tlyu



Revision: 19799
Changed Files:
_U branches/krb5-1-6/
U branches/krb5-1-6/src/windows/identity/ui/mainwnd.c
U branches/krb5-1-6/src/windows/identity/ui/timer.c
# Fri Aug 10 10:37:10 2007 kpkoch (Kevin Koch) - Correspondence added
From: kpkoch@mit.edu
Subject: SVN Commit
Download (untitled) / with headers
text/plain 347B
Simulate changing views when the REFRESH action is run and when credentials are updated.
This makes the symptoms go away but does not solve whatever the underlying problem is.

I missed this change yesterday.

This should be added to kfw-3_2_1-beta2.
Commit By: kpkoch



Revision: 19813
Changed Files:
U trunk/src/windows/identity/ui/credwnd.c
# Fri Aug 10 14:02:54 2007 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: SVN Commit
Download (untitled) / with headers
text/plain 546B
pull up r19813 from trunk

r19813@cathode-dark-space: kpkoch | 2007-08-10 10:37:04 -0400
Ticket: 5604
Tags: pullup
Target_Version: 1.6.3
Tags: Pullup

Simulate changing views when the REFRESH action is run and when credentials are updated.
This makes the symptoms go away but does not solve whatever the underlying problem is.

I missed this change yesterday.

This should be added to kfw-3_2_1-beta2.


Commit By: tlyu



Revision: 19814
Changed Files:
_U branches/krb5-1-6/
U branches/krb5-1-6/src/windows/identity/ui/credwnd.c
# Fri Aug 24 11:29:28 2007 jaltman (Jeffrey Altman) - Ticket 5689 RefersTo ticket 5604.
# Wed Oct 03 14:52:58 2007 kpkoch (Kevin Koch) - Subject changed from 'NIM update inconsistency when deleting credentials' to 'NIM credential display doesn't update when credential deleted'
# Wed Dec 16 18:02:50 2015 tlyu (Taylor Yu) - CustomField pullup deleted