Ticket History #5651: The Removal of Colors (ticket 5607)

This patch from ticket 5607 which was applied to the trunk and pulled up
to 1-6 is wrong.

Index: credwnd.c
===================================================================
--- credwnd.c (revision 19739)
+++ credwnd.c (working copy)
@@ -685,7 +689,7 @@
COLORREF bg_hdr_warn = RGB(235,235,134);
COLORREF bg_hdr_crit = RGB(235,184,134);
COLORREF bg_hdr_exp = RGB(235,134,134);
- COLORREF bg_hdr_def = RGB(184,235,134);
+ COLORREF bg_hdr_def = GetSysColor(COLOR_WINDOW);

tbl->cr_normal = GetSysColor(COLOR_WINDOWTEXT);
tbl->cr_s = GetSysColor(COLOR_WINDOWTEXT);

If you want the default background header color, bg_hdr_def, to be the
same as the rest of the header colors, then you must set it to the same
value as the other header background colors, bg_hdr.

COLORREF bg_s = GetSysColor(COLOR_HIGHLIGHT);
COLORREF bg_normal = GetSysColor(COLOR_WINDOW);
COLORREF bg_gray = RGB(240,240,240);
COLORREF bg_hdr = RGB(240,240,240);
COLORREF bg_hdr_warn = RGB(235,235,134);
COLORREF bg_hdr_crit = RGB(235,184,134);
COLORREF bg_hdr_exp = RGB(235,134,134);
COLORREF bg_hdr_def = GetSysColor(COLOR_WINDOW);

RGB(240,240,240) != GetSysColor(ColorWindow)

Jeffrey Altman