Skip Menu |
 

History Show all quoted text — Show full headers
# Mon Aug 19 14:19:25 2002 The RT System itself - Default: Import/ changed from (no value) to (no value)
Download (untitled) / with headers
text/plain 2.1KiB
From schwim@whatmore.Stanford.EDU Fri Apr 17 20:52:31 1998
Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id UAA27778 for <bugs@RT-11.MIT.EDU>; Fri, 17 Apr 1998 20:52:30 -0400
Received: from whatmore.Stanford.EDU by MIT.EDU with SMTP
id AA25875; Fri, 17 Apr 98 20:52:22 EDT
Received: (from schwim@localhost)
by whatmore.Stanford.EDU (8.8.8/8.8.8) id RAA02520;
Fri, 17 Apr 1998 17:52:20 -0700 (PDT)
Message-Id: <199804180052.RAA02520@whatmore.Stanford.EDU>
Date: Fri, 17 Apr 1998 17:52:20 -0700 (PDT)
From: Larry Schwimmer <schwim@whatmore.Stanford.EDU>
To: krb5-bugs@MIT.EDU
Subject: PATCH: appl/bsd/login.c not 64-bit clean

Show quoted text
>Number: 581
>Category: krb5-clients
>Synopsis: verify_krb_v4_tgt is not 64-bit clean
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: krb5-unassigned
>State: open
>Class: sw-bug
>Submitter-Id: unknown
>Arrival-Date: Fri Apr 17 20:53:00 EDT 1998
>Last-Modified: Fri Sep 14 11:40:57 EDT 2001
>Originator: Larry Schwimmer
>Organization:
>Release: 1.0.5
>Environment:
64 bit (includes DUNIX)
Show quoted text
>Description:

Addresses are four-bytes. long is 8 bytes on a 64 bit
machine, so the call fails. I guess you could use unsigned KRB4_32
instead of unsigned int.

yours,
Larry Schwimmer
schwim@leland.stanford.edu
Leland Systems Group

Show quoted text
>How-To-Repeat:
>Fix:
--- appl/bsd/login.c.orig Fri Feb 6 19:41:18 1998
+++ appl/bsd/login.c Fri Apr 17 17:47:46 1998
***************
*** 779,785 ****
struct hostent *hp;
KTEXT_ST ticket;
AUTH_DAT authdata;
- unsigned long addr;
static /*const*/ char rcmd[] = "rcmd";
char key[8];
int krbval, retval, have_keys;
--- 779,785 ----
struct hostent *hp;
KTEXT_ST ticket;
AUTH_DAT authdata;
+ unsigned int addr;
static /*const*/ char rcmd[] = "rcmd";
char key[8];
int krbval, retval, have_keys;
Show quoted text
>Audit-Trail:

Responsible-Changed-From-To: gnats-admin->krb5-unassigned
Responsible-Changed-By: raeburn
Responsible-Changed-When: Fri Sep 14 11:40:47 2001
Responsible-Changed-Why:
reformat/refile
Show quoted text
>Unformatted:
# Mon Aug 19 14:19:25 2002 The RT System itself - Component krb5-clients added
# Fri Jan 09 16:56:08 2004 hartmans (Sam Hartman) - Subject changed from 'verify_krb_v4_tgt is not 64-bit clean ' to 'preauth'
# Tue Jun 20 17:45:20 2006 Russ Allbery <devnull@mit.edu> - Version_reported 1.0.5 added
# Tue Jun 20 17:45:21 2006 Russ Allbery <devnull@mit.edu> - Status changed from 'new' to 'resolved'
# Tue Jun 20 17:45:21 2006 Russ Allbery <devnull@mit.edu> - Tags pullup added
# Tue Jun 20 17:45:22 2006 Russ Allbery <devnull@mit.edu> - Target_Version 1.5 added
# Tue Jun 20 17:45:22 2006 Russ Allbery <devnull@mit.edu> - Given to Russ Allbery <devnull@mit.edu>
# Tue Jun 20 17:45:22 2006 Russ Allbery <devnull@mit.edu> - Correspondence added
From: Russ Allbery <rra@stanford.edu>
Subject: SVN Commit
Download (untitled) / with headers
text/plain 244B
In verify_krb_v4_tgt, use an unsigned KRB4_32 to store an address rather
than an unsigned long to avoid memcpying past the end of a structure on
64-bit platforms.

Commit By: rra



Revision: 18175
Changed Files:
U trunk/src/appl/bsd/login.c
# Sun Jun 25 10:47:35 2006 tlyu (Taylor Yu) - Version_Fixed 1.5 added
# Sun Jun 25 10:47:36 2006 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: SVN Commit
Download (untitled) / with headers
text/plain 425B
pull up r18175 from trunk

r18175@cathode-dark-space: rra | 2006-06-20 17:45:16 -0400
Ticket: 581
Version_Reported: 1.0.5
Target_Version: 1.5
Tags: pullup

In verify_krb_v4_tgt, use an unsigned KRB4_32 to store an address rather
than an unsigned long to avoid memcpying past the end of a structure on
64-bit platforms.


Commit By: tlyu



Revision: 18211
Changed Files:
U branches/krb5-1-5/src/appl/bsd/login.c
# Wed Dec 16 18:02:38 2015 tlyu (Taylor Yu) - CustomField pullup deleted