Skip Menu |
 

Subject: error in filebase+suffix list generation in plugin code
krb5int_get_plugin_filenames works from two lists, filebases[] and fileexts[], to build a list of
filenames to look for. However, it's allocating M+N elements in its array, computing all M*N
combinations, and sticking them into the M+N slots in overlapping passes. No overrun here,
but we can leak memory and omit some filenames from the final list, if filebases ever gets more
than one element, which I think it currently does not.
From: lxs@mit.edu
Subject: SVN Commit

Generate a large enough array to hold all the base/extension pairs.
Store pairs without overlapping.

Commit By: lxs



Revision: 20308
Changed Files:
U trunk/src/util/support/plugins.c
From: lxs@mit.edu
Subject: SVN Commit

Added test for multiple basename case.

Commit By: lxs



Revision: 6401
Changed Files:
U trunk/KerberosFramework/Kerberos5/Tools/TestPlugin/test-plugin.c