Ticket History #6042: krb5_string_to_keysalts should default to normal salt rather than "ignore salttype"

# Mon Jul 21 18:54:26 2008 jaltman (Jeffrey Altman) - Ticket created

Subject:

Do not permit salttype after a lookup to be assigned "Ignore salttype"

Download (untitled) / with headers
text/plain 609B

Index: str_conv.c
===================================================================
--- str_conv.c (revision 20163)
+++ str_conv.c (working copy)

@@ -346,6 +346,9 @@
krb5_xfree(savep);
}
+ if (stype == -1)
+ stype == KRB5_KDB_SALT_TYPETYPE_NORMAL;
+
/* Save our values */
(*ksaltp)[(*nksaltp)].ks_enctype = ktype;
(*ksaltp)[(*nksaltp)].ks_salttype = stype;

Instead of setting the ks_salttype field to -1 which is an invalid
salttype, we default to using the normal salt type instead.

# Mon Jul 21 18:54:47 2008 jaltman (Jeffrey Altman) - Component krb5-libs added

# Mon Jul 21 18:55:53 2008 jaltman (Jeffrey Altman) - Ticket 6042 RefersTo ticket 5839.

# Mon Jan 06 16:26:59 2014 tlyu (Taylor Yu) - Subject changed from 'Do not permit salttype after a lookup to be assigned "Ignore salttype"' to 'krb5_string_to_keysalts should default to normal salt rather than "ignore salttype"'

# Mon Jan 06 17:48:02 2014 tlyu (Taylor Yu) - Status changed from 'open' to 'review'

# Mon Jan 06 17:48:02 2014 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	git commit

Download (untitled) / with headers
text/plain 485B

Default to normal salt instead of "ignore"

krb5_string_to_keysalts() treats an empty salt field as -1 ("ignore"),
rather than as the normal salttype. Default to normal instead, so
that omitting a salttype works as expected.

https://github.com/krb5/krb5/commit/25a3b1bd943199bcaa3a9d3a43f90f8ea05f1124
Author: Tom Yu <tlyu@mit.edu>
Commit: 25a3b1bd943199bcaa3a9d3a43f90f8ea05f1124
Branch: master
src/lib/kadm5/str_conv.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

# Tue Aug 12 18:27:37 2014 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'

# Tue Aug 12 18:27:37 2014 tlyu (Taylor Yu) - Version_Fixed 1.13 added