Ticket History #605: klist checks for ENOENT, which is wrong

From ghudson@MIT.EDU Tue Jun 2 17:21:52 1998
Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id RAA07255 for <bugs@RT-11.MIT.EDU>; Tue, 2 Jun 1998 17:21:51 -0400
Received: from SMALL-GODS.MIT.EDU by MIT.EDU with SMTP
id AA02261; Tue, 2 Jun 98 17:21:52 EDT
Received: by small-gods.MIT.EDU (SMI-8.6/4.7) id RAA14944; Tue, 2 Jun 1998 17:21:48 -0400
Message-Id: <199806022121.RAA14944@small-gods.MIT.EDU>
Date: Tue, 2 Jun 1998 17:21:48 -0400
From: ghudson@MIT.EDU
Reply-To: ghudson@MIT.EDU
To: krb5-bugs@MIT.EDU
Subject: klist checks for wrong return code
X-Send-Pr-Version: 3.99

MIT

System: SunOS small-gods 5.5.1 Generic_103640-12 sun4u sparc SUNW,Ultra-1
Architecture: sun4

klist's do_ccache() function has a check for a return code of
ENOENT, which isn't what you get when a credentials cache doesn't
exist.
Run klist with no credentials cache. Note the confusing part of the
error message about "while setting cache flags".

Index: klist.c
===================================================================
RCS file: /afs/dev.mit.edu/source/repository/third/krb5/src/clients/klist/klist.c,v
retrieving revision 1.2
diff -c -r1.2 klist.c
*** klist.c 1997/10/14 05:58:17 1.2
--- klist.c 1998/06/02 21:16:41
***************
*** 280,286 ****

flags = 0; /* turns off OPENCLOSE mode */
if ((code = krb5_cc_set_flags(kcontext, cache, flags))) {
! if (code == ENOENT) {
if (!status_only)
com_err(progname, code, "(ticket cache %s)",
krb5_cc_get_name(kcontext, cache));
--- 280,286 ----

flags = 0; /* turns off OPENCLOSE mode */
if ((code = krb5_cc_set_flags(kcontext, cache, flags))) {
! if (code == KRB5_FCC_NOFILE) {
if (!status_only)
com_err(progname, code, "(ticket cache %s)",
krb5_cc_get_name(kcontext, cache));

State-Changed-From-To: open-closed
State-Changed-By: mdh
State-Changed-When: Tue Aug 11 23:42:32 1998
State-Changed-Why:

Fixed.