Skip Menu |
 

Subject: Reduce warnings
Building krb5 produces a large number of false positive warnings. Reduce these warnings.
The following patch should remove large numbers of the warnings.
Download warnings.patch
text/plain 56.1KiB

Message body is not shown because it is too large.

Assigning to Ken to review.
From: raeburn@mit.edu
Subject: SVN Commit
Download (untitled) / with headers
text/plain 3.8KiB

Based on patch from lxs, with some changes:

Add several new gcc warning flags, used in the KfM build process.

Put declarations before code.

Fix a bunch of signed/unsigned type mixes, mostly by changing variable
types to unsigned int.

Fix constness in handling name of default ccache name.

Make sure functions get declared with prototypes:
krb5int_pthread_loaded krb5int_gmt_mktime krb5int_aes_encrypt
krb5int_aes_decrypt gssint_mecherrmap_init gssint_mecherramp_get.

Don't shadow global names: stat accept index open encrypt. Fix
variable shadowing in LDAP ASN.1 support.

Don't define unused krb5int_local_addresses.
Don't export internal krb5_change_set_password.
Fix error return indications from gssint_oid_to_mech.

Create and use k5-gmt_mktime.h to provide one global declaration of
krb5int_gmt_mktime, needed before we've generated krb5.h on some
platforms.

Not incorporated from initial patch: const changes in function
signatures.
Commit By: raeburn



Revision: 20697
Changed Files:
_U trunk/
U trunk/src/aclocal.m4
A trunk/src/include/k5-gmt_mktime.h
U trunk/src/include/k5-int.h
U trunk/src/include/k5-thread.h
U trunk/src/kim/lib/kim_preferences.c
U trunk/src/kim/lib/mac/kim_os_string.c
U trunk/src/lib/crypto/checksum_length.c
U trunk/src/lib/crypto/cksumtype_to_string.c
U trunk/src/lib/crypto/cksumtypes.c
U trunk/src/lib/crypto/cksumtypes.h
U trunk/src/lib/crypto/coll_proof_cksum.c
U trunk/src/lib/crypto/des/f_parity.c
U trunk/src/lib/crypto/des/string2key.c
U trunk/src/lib/crypto/des/weak_key.c
U trunk/src/lib/crypto/hash_provider/hash_crc32.c
U trunk/src/lib/crypto/hash_provider/hash_md4.c
U trunk/src/lib/crypto/hash_provider/hash_md5.c
U trunk/src/lib/crypto/hash_provider/hash_sha1.c
U trunk/src/lib/crypto/hmac.c
U trunk/src/lib/crypto/keyed_cksum.c
U trunk/src/lib/crypto/keyhash_provider/k5_md4des.c
U trunk/src/lib/crypto/keyhash_provider/k5_md5des.c
U trunk/src/lib/crypto/make_checksum.c
U trunk/src/lib/crypto/pbkdf2.c
U trunk/src/lib/crypto/sha1/shs.c
U trunk/src/lib/crypto/string_to_cksumtype.c
U trunk/src/lib/crypto/valid_cksumtype.c
U trunk/src/lib/crypto/verify_checksum.c
U trunk/src/lib/gssapi/generic/gssapiP_generic.h
U trunk/src/lib/gssapi/generic/util_buffer.c
U trunk/src/lib/gssapi/generic/util_errmap.c
U trunk/src/lib/gssapi/gss_libinit.c
U trunk/src/lib/gssapi/krb5/accept_sec_context.c
U trunk/src/lib/gssapi/krb5/copy_ccache.c
U trunk/src/lib/gssapi/krb5/import_sec_context.c
U trunk/src/lib/gssapi/krb5/init_sec_context.c
U trunk/src/lib/gssapi/krb5/inq_context.c
U trunk/src/lib/gssapi/krb5/k5seal.c
U trunk/src/lib/gssapi/krb5/krb5_gss_glue.c
U trunk/src/lib/gssapi/krb5/set_allowable_enctypes.c
U trunk/src/lib/gssapi/krb5/util_seed.c
U trunk/src/lib/gssapi/mechglue/g_acquire_cred.c
U trunk/src/lib/gssapi/mechglue/g_initialize.c
U trunk/src/lib/gssapi/mechglue/g_inq_context.c
U trunk/src/lib/gssapi/mechglue/g_rel_oid_set.c
U trunk/src/lib/gssapi/mechglue/mglueP.h
U trunk/src/lib/gssapi/mechglue/oid_ops.c
U trunk/src/lib/gssapi/spnego/gssapiP_spnego.h
U trunk/src/lib/gssapi/spnego/spnego_mech.c
U trunk/src/lib/krb5/asn.1/asn1_decode.c
U trunk/src/lib/krb5/asn.1/asn1_k_decode.c
U trunk/src/lib/krb5/asn.1/asn1buf.c
U trunk/src/lib/krb5/asn.1/asn1buf.h
U trunk/src/lib/krb5/asn.1/ldap_key_seq.c
U trunk/src/lib/krb5/ccache/ccdefault.c
U trunk/src/lib/krb5/krb/gc_frm_kdc.c
U trunk/src/lib/krb5/krb/pkinit_apple_cert_store.c
U trunk/src/lib/krb5/krb/pkinit_apple_utils.c
U trunk/src/lib/krb5/krb/preauth2.c
U trunk/src/lib/krb5/krb/ser_ctx.c
U trunk/src/lib/krb5/krb/srv_rcache.c
U trunk/src/lib/krb5/krb/str_conv.c
U trunk/src/lib/krb5/libkrb5.exports
U trunk/src/lib/krb5/os/changepw.c
U trunk/src/lib/krb5/os/gen_rname.c
U trunk/src/lib/krb5/os/localaddr.c
U trunk/src/lib/krb5/os/sendto_kdc.c
U trunk/src/lib/krb5/rcache/rc_io.c
U trunk/src/util/support/gmt_mktime.c