Ticket History #616: telnet -k option doesn't get copied as realm correctly

From ghudson@MIT.EDU Fri Jul 31 01:08:32 1998
Received: from MIT.EDU (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id BAA03222 for <bugs@RT-11.MIT.EDU>; Fri, 31 Jul 1998 01:08:32 -0400
Received: from MAYTAG.MIT.EDU by MIT.EDU with SMTP
id AA06076; Fri, 31 Jul 98 01:08:21 EDT
Received: by maytag.mit.edu (950413.SGI.8.6.12/4.7) id BAA22370; Fri, 31 Jul 1998 01:08:31 -0400
Message-Id: <199807310508.BAA22370@maytag.mit.edu>
Date: Fri, 31 Jul 1998 01:08:31 -0400
From: ghudson@MIT.EDU
Reply-To: ghudson@MIT.EDU
To: krb5-bugs@MIT.EDU
Subject: telnet option-parsing bug
X-Send-Pr-Version: 3.99

MIT

System: IRIX maytag 6.3 12161207 IP32


libtelnet/kerberos.c defines dst_realm_sz as an int. telnet/main.c
declares it as an extern char, which tends to have the value 0. So
the realm argument gets copied in incorrectly into the krb4 realm
buffer.
Index: main.c
===================================================================
RCS file: /afs/dev.mit.edu/source/repository/third/krb5/src/appl/telnet/telnet/main.c,v
retrieving revision 1.4
diff -c -r1.4 main.c
*** main.c 1998/07/30 17:06:59 1.4
--- main.c 1998/07/31 05:00:51
***************
*** 232,238 ****
case 'k':
#if defined(AUTHENTICATION) && defined(KRB4)
{
! extern char *dest_realm, dst_realm_buf[], dst_realm_sz;
dest_realm = dst_realm_buf;
(void)strncpy(dest_realm, optarg, dst_realm_sz);
}
--- 232,239 ----
case 'k':
#if defined(AUTHENTICATION) && defined(KRB4)
{
! extern char *dest_realm, dst_realm_buf[];
! extern int dst_realm_sz;
dest_realm = dst_realm_buf;
(void)strncpy(dest_realm, optarg, dst_realm_sz);
}