Ticket History #6201: small leak in KDC authdata plugins

# Mon Oct 20 16:55:36 2008 tlyu (Taylor Yu) - Ticket created

Subject:

small leak in KDC authdata plugins

Download (untitled) / with headers
text/plain 82B

There is a small leak in the KDC authdata plugin code. Patch from Apple
attached.

Download LHA-5396551-free-ftables-on-exit.patch
application/octet-stream 3.8KiB

Message body not shown because it is not plain text.

# Mon Oct 20 16:55:36 2008 tlyu (Taylor Yu) - Ticket 6201 RefersTo ticket 5655.

# Mon Oct 20 17:16:27 2008 tlyu (Taylor Yu) - Cc lha (Love Hornquist Astrand) added

# Mon Nov 03 14:26:11 2008 ghudson@mit.edu (Greg Hudson) - Correspondence added

Download (untitled) / with headers
text/plain 255B

I am having some trouble characterizing this patch. There are two
changes to error-handling in the KDC code, and then a change to
lib/kdb/kdb_default.c to avoid leaking keytab objects.

All of the changes look fine; they just don't seem terribly related.

# Mon Nov 03 14:34:38 2008 lha (Love Hornquist Astrand) - Comments added

Date:	Mon, 03 Nov 2008 11:34:36 -0800
From:	Love Hörnquist Åstrand <lha@apple.com>
Subject:	Re: [krbdev.mit.edu #6201] small leak in KDC authdata plugins
To:	"rt-comment@krbdev.mit.edu" <rt-comment@krbdev.mit.edu>
RT-Send-Cc:

Download (untitled) / with headers
text/plain 382B

3 nov 2008 kl. 11:26 skrev Greg Hudson via RT:

Show quoted text

> I am having some trouble characterizing this patch. There are two
> changes to error-handling in the KDC code, and then a change to
> lib/kdb/kdb_default.c to avoid leaking keytab objects.
>
> All of the changes look fine; they just don't seem terribly related.

The are related as in "Memory leaks as detected by leaks".

Love

# Mon Nov 03 14:40:35 2008 ghudson@mit.edu (Greg Hudson) - Correspondence added

Download (untitled) / with headers
text/plain 122B

Okay, that's fine. I'll check it in as such. I had just received some
incorrect summaries of the patch and was confused.

# Mon Nov 03 14:47:42 2008 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'review'

# Mon Nov 03 14:47:42 2008 ghudson@mit.edu (Greg Hudson) - Correspondence added

From:	ghudson@mit.edu
Subject:	SVN Commit

Download (untitled) / with headers
text/plain 212B

Apply a patch from Apple to correct a few memory leaks.

Commit By: ghudson

Revision: 20958
Changed Files:
U trunk/src/kdc/kdc_authdata.c
U trunk/src/kdc/kdc_preauth.c
U trunk/src/lib/kdb/kdb_default.c

# Thu Jan 29 22:38:53 2009 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'

# Fri Jan 30 23:08:20 2009 tlyu (Taylor Yu) - Version_Fixed 1.7 added