Ticket History #6210: pa_sam leaks parts of krb5_sam_challenge

pa_sam (preauth2.c) calls decode_krb5_sam_challenge and then just calls krb5_xfree to free the
resulting krb5_sam_challenge. However, krb5_sam_challenge is a deep structure.

Should be calling krb5_free_sam_challenge instead.

Properly free sam_challenge in pa_sam().

Commit By: ghudson



Revision: 21062
Changed Files:
U trunk/src/lib/krb5/krb/preauth2.c

I handled the error cases but appear to have missed the main
(successful) code path. Reopening this ticket.

Also, there is some ugly stuff going on in that function where
structures are partially constructed with allocated data and not freed,
and at least one case where a structure does a shallow copy of allocated
data from another structure and neither is freed. I will need to do
some more careful analysis.

In pa_sam, use the correct function to free sam_challenge in the
success path.


https://github.com/krb5/krb5/commit/b89fe040c3673c700b3f47d79bc380692b9ba846
Commit By: ghudson
Revision: 22319
Changed Files:
U trunk/src/lib/krb5/krb/preauth2.c

pull up r22319 from trunk
------------------------------------------------------------------------
r22319 | ghudson | 2009-05-06 14:52:44 -0400 (Wed, 06 May 2009) | 5 lines
Changed paths:
M /trunk/src/lib/krb5/krb/preauth2.c

ticket: 6210

In pa_sam, use the correct function to free sam_challenge in the
success path.

https://github.com/krb5/krb5/commit/6f667dcc6f55d06cf91ed8479861972728baa477
Commit By: tlyu
Revision: 22337
Changed Files:
U branches/krb5-1-7/src/lib/krb5/krb/preauth2.c