Ticket History #6278: gssd-agent deadlock

# Thu Dec 04 10:05:01 2008 tsitkova (Zhanna Tsitkova) - Ticket created

Subject:

gssd-agent deadlock

Download (untitled) / with headers
text/plain 81B

Vendor's priority - Serious Bug
Vendor's patch - LHA-6370271-deadlock-in-com-err

# Thu Dec 04 10:07:37 2008 tsitkova (Zhanna Tsitkova) - Ticket 6278 MemberOf ticket 6204.

# Thu Dec 04 15:13:15 2008 tsitkova (Zhanna Tsitkova) - Cc lha (Love Hornquist Astrand) added

# Fri Dec 05 13:12:40 2008 tsitkova (Zhanna Tsitkova) - Comments added

Download (untitled) / with headers
text/plain 16B

Adding the patch

Download LHA-6370271-deadlock-in-com-err.patch
text/plain 774B

diff -Nur -x '*~' -x '*.orig' -x '*.rej' -x '*.pbxbtree' -x '*.pbxindex' -x lha.mode1v3 -x lha.mode2v3 -x lha.pbxuser -x windows -x .DS_Store Kerberos.AEP-6.5fc1.orig/KerberosFramework/KerberosErrors/Sources/com_err.c Kerberos.AEP-6.5fc1/KerberosFramework/KerberosErrors/Sources/com_err.c
--- Kerberos.AEP-6.5fc1.orig/KerberosFramework/KerberosErrors/Sources/com_err.c 2008-11-07 11:24:28.000000000 -0800
+++ Kerberos.AEP-6.5fc1/KerberosFramework/KerberosErrors/Sources/com_err.c 2008-11-13 15:37:31.000000000 -0800
@@ -201,6 +201,8 @@
char *message = NULL;
int reentered = 0; /* some of the functions that we call may call us. */

+ kim_library_init();
+
if (!err) {
enter_err = com_err_thread_entering_error_message (&reentered);

# Fri Dec 05 13:13:49 2008 tsitkova (Zhanna Tsitkova) - Given to lxs (Alexandra Ellwood)

# Tue Dec 16 13:59:05 2008 lxs (Alexandra Ellwood) - Comments added

Download (untitled) / with headers
text/plain 462B

This is the wrong way of fixing this bug. kim_library_init() just registers
KIM's error tables using a pthread-once call.

I would like to understand the deadlock this patch is intended to fix.
There are multiple mutexes involved (one for the error table array and
one for KIM's copy of the framework cfbundle). However it's not
obvious to me from just looking at the patch what the deadlock is.

I don't see a regression test tagged with this bug number.

# Wed Dec 17 17:51:33 2008 lxs (Alexandra Ellwood) - Given to tsitkova (Zhanna Tsitkova)

# Wed Dec 17 17:51:33 2008 lxs (Alexandra Ellwood) - Comments added

Download (untitled) / with headers
text/plain 231B

This should be fixed by moving the CFBundle code in kim_os_string.c into the support library
under non-KIM names. Then this code will no longer call into KIM initializers and cannot
deadlock error_message().

Passing to Zhanna.

# Thu Dec 18 11:30:11 2008 tsitkova (Zhanna Tsitkova) - Given to raeburn (Ken Raeburn)

# Thu Dec 18 11:30:11 2008 tsitkova (Zhanna Tsitkova) - Comments added

Download (untitled) / with headers
text/plain 16B

Assigning to Ken

# Wed Sep 09 19:31:29 2015 tlyu (Taylor Yu) - Status changed from 'new' to 'resolved'

# Wed Sep 09 19:31:29 2015 tlyu (Taylor Yu) - Tags noresource added