Skip Menu |
 

History Show all quoted text — Show full headers
# Thu Dec 04 10:37:31 2008 tsitkova (Zhanna Tsitkova) - Ticket created
Subject: At Login the client is setting the renew life time to 24 hours?
Download (untitled) / with headers
text/plain 170B
KIM - set default_renewal_lifetime if KRB5_GET_INIT_CREDS_OPT_RENEW_LIFE flag is set.

Vendor's priority - Other Bug
Vendor's patch - LHA-6325227-dont-set-renewable-life
# Thu Dec 04 10:37:31 2008 tsitkova (Zhanna Tsitkova) - Ticket 6283 MemberOf ticket 6204.
# Thu Dec 04 13:40:54 2008 tsitkova (Zhanna Tsitkova) - Comments added
Download (untitled) / with headers
text/plain 19B
Including the patch
Download LHA-6325227-dont-set-renewable-life.patch
text/plain 3.1KiB
diff -Nur -x '*~' -x '*.orig' -x '*.rej' -x '*.pbxbtree' -x '*.pbxindex' -x lha.mode1v3 -x lha.mode2v3 -x lha.pbxuser -x windows -x .DS_Store Kerberos.AEP-6.5fc1.orig/KerberosFramework/Kerberos5/Sources/kim/lib/kim_options.c Kerberos.AEP-6.5fc1/KerberosFramework/Kerberos5/Sources/kim/lib/kim_options.c
--- Kerberos.AEP-6.5fc1.orig/KerberosFramework/Kerberos5/Sources/kim/lib/kim_options.c 2008-11-07 11:24:45.000000000 -0800
+++ Kerberos.AEP-6.5fc1/KerberosFramework/Kerberos5/Sources/kim/lib/kim_options.c 2008-11-11 17:34:02.000000000 -0800
@@ -45,7 +45,7 @@
0,
kim_default_lifetime,
kim_default_renewable,
-kim_default_renewal_lifetime,
+0,
kim_default_forwardable,
kim_default_proxiable,
kim_default_addressless,
@@ -488,8 +488,9 @@
if (!err) {
krb5_get_init_creds_opt_set_tkt_life (in_options->init_cred_options,
in_options->lifetime);
- krb5_get_init_creds_opt_set_renew_life (in_options->init_cred_options,
- in_options->renewable ? in_options->renewal_lifetime : 0);
+ if (in_options->renewal_lifetime || in_options->renewable)
+ krb5_get_init_creds_opt_set_renew_life (in_options->init_cred_options,
+ in_options->renewal_lifetime);
krb5_get_init_creds_opt_set_forwardable (in_options->init_cred_options,
in_options->forwardable);
krb5_get_init_creds_opt_set_proxiable (in_options->init_cred_options,
diff -Nur -x '*~' -x '*.orig' -x '*.rej' -x '*.pbxbtree' -x '*.pbxindex' -x lha.mode1v3 -x lha.mode2v3 -x lha.pbxuser -x windows -x .DS_Store Kerberos.AEP-6.5fc1.orig/KerberosFramework/Kerberos5/Sources/kim/lib/kim_preferences_private.h Kerberos.AEP-6.5fc1/KerberosFramework/Kerberos5/Sources/kim/lib/kim_preferences_private.h
--- Kerberos.AEP-6.5fc1.orig/KerberosFramework/Kerberos5/Sources/kim/lib/kim_preferences_private.h 2008-11-07 11:24:45.000000000 -0800
+++ Kerberos.AEP-6.5fc1/KerberosFramework/Kerberos5/Sources/kim/lib/kim_preferences_private.h 2008-11-11 17:33:14.000000000 -0800
@@ -52,7 +52,6 @@

#define kim_default_lifetime 10*60*60
#define kim_default_renewable TRUE
-#define kim_default_renewal_lifetime 7*24*60*60
#define kim_default_forwardable TRUE
#define kim_default_proxiable TRUE
#define kim_default_addressless TRUE
diff -Nur -x '*~' -x '*.orig' -x '*.rej' -x '*.pbxbtree' -x '*.pbxindex' -x lha.mode1v3 -x lha.mode2v3 -x lha.pbxuser -x windows -x .DS_Store Kerberos.AEP-6.5fc1.orig/KerberosFramework/Kerberos5/Sources/lib/krb5/krb/get_in_tkt.c Kerberos.AEP-6.5fc1/KerberosFramework/Kerberos5/Sources/lib/krb5/krb/get_in_tkt.c
--- Kerberos.AEP-6.5fc1.orig/KerberosFramework/Kerberos5/Sources/lib/krb5/krb/get_in_tkt.c 2008-11-07 11:25:56.000000000 -0800
+++ Kerberos.AEP-6.5fc1/KerberosFramework/Kerberos5/Sources/lib/krb5/krb/get_in_tkt.c 2008-11-11 18:20:20.000000000 -0800
@@ -1026,7 +1026,7 @@
} else {
renew_life = 0;
}
- if (renew_life > 0)
+ if (renew_life > 0 || (options->flags & KRB5_GET_INIT_CREDS_OPT_RENEW_LIFE))
request.kdc_options |= KDC_OPT_RENEWABLE;

if (renew_life > 0) {
# Thu Dec 04 15:09:24 2008 tsitkova (Zhanna Tsitkova) - Cc lha (Love Hornquist Astrand) added
# Thu Dec 04 17:24:15 2008 lxs (Alexandra Ellwood) - Comments added
Download (untitled) / with headers
text/plain 808B
I'm not sure how this patch fixes a bug where ticket renewal times are 24 hours. KIM (and KLL,
which this code was copied from) is hardcoding a default of 7 days. So while this patch does
get rid of a duplicate default value, I am concerned that it is not actually fixing the bug
described in the subject line.

Also as far as code readability goes, I'd like to see the kim_default_renewal_lifetime macro
remain in the code and be set to 0 with a comment explaining that the krb5 libraries treat a
renewable lifetime of 0 as "use the default renewal lifetime" when KDC_OPT_RENEWABLE is set.
The patch just sets a 0 in the initializer structure with no explanation as to what it means. This
increases the likelihood that future programmers will break the code while trying to modify its
behavior.
# Thu Dec 04 23:34:12 2008 lha (Love Hornquist Astrand) - Comments added
Download (untitled) / with headers
text/plain 146B
On purpose to fix the problem in the subject line, just make sure that the tools behavied
consistantly.

I have no comment about the readablity.
# Tue Dec 16 13:08:30 2008 lxs (Alexandra Ellwood) - Given to tsitkova (Zhanna Tsitkova)
# Tue Dec 16 13:08:30 2008 lxs (Alexandra Ellwood) - Comments added
Download (untitled) / with headers
text/plain 35B
Commented, passing back to Zhanna.
# Tue Jan 06 14:11:11 2009 tsitkova (Zhanna Tsitkova) - Priority changed from (no value) to '50'
# Wed Sep 09 19:28:38 2015 tlyu (Taylor Yu) - Status changed from 'new' to 'resolved'
# Wed Sep 09 19:28:38 2015 tlyu (Taylor Yu) - Tags noresource added