Ticket History #6294: lib/gssapi/krb5/init_sec_context.c: don't leak on mutex

# Mon Dec 08 15:21:03 2008 tsitkova (Zhanna Tsitkova) - Ticket created

Subject:	gss-api - mutex_lock problem
CC:	lha@apple.com

Download (untitled) / with headers
text/plain 121B

Fix the problem in gss_init_sec_context when mutex_lock fails

Vendor's patch - LHA-6419724-no-leak-on-lock-failure.patch

Download LHA-6419724-no-leak-on-lock-failure.patch
text/plain 911B

diff -Nur -x '*~' -x '*.orig' -x '*.rej' -x '*.pbxbtree' -x '*.pbxindex' -x lha.mode1v3 -x lha.mode2v3 -x lha.pbxuser -x windows -x .DS_Store Kerberos.AEP-6.5fc1.orig/KerberosFramework/Kerberos5/Sources/lib/gssapi/krb5/init_sec_context.c Kerberos.AEP-6.5fc1/KerberosFramework/Kerberos5/Sources/lib/gssapi/krb5/init_sec_context.c
--- Kerberos.AEP-6.5fc1.orig/KerberosFramework/Kerberos5/Sources/lib/gssapi/krb5/init_sec_context.c 2008-12-04 14:14:02.000000000 -0800
+++ Kerberos.AEP-6.5fc1/KerberosFramework/Kerberos5/Sources/lib/gssapi/krb5/init_sec_context.c 2008-12-04 14:25:28.000000000 -0800
@@ -905,6 +905,8 @@
}
kerr = k5_mutex_lock(&cred->lock);
if (kerr) {
+ if (claimant_cred_handle == GSS_C_NO_CREDENTIAL)
+ krb5_gss_release_cred(minor_status, (gss_cred_id_t *)&cred);
krb5_free_context(context);
*minor_status = kerr;
return GSS_S_FAILURE;

# Mon Dec 08 15:21:04 2008 tsitkova (Zhanna Tsitkova) - Ticket 6294 MemberOf ticket 6204.

# Tue Dec 09 10:49:00 2008 tsitkova (Zhanna Tsitkova) - Given to tsitkova (Zhanna Tsitkova)

# Tue Dec 09 11:09:23 2008 tsitkova (Zhanna Tsitkova) - Status changed from 'new' to 'review'

# Tue Dec 09 11:09:23 2008 tsitkova (Zhanna Tsitkova) - Correspondence added

From:	tsitkova@mit.edu
Subject:	SVN Commit

Download (untitled) / with headers
text/plain 260B

Release default credentials before exiting krb5_gss_init_sec_context routine.

https://github.com/krb5/krb5/commit/b9d1bc83c53454f71990e8550b691f32e352aab0
Commit By: tsitkova

Revision: 21298
Changed Files:
U trunk/src/lib/gssapi/krb5/init_sec_context.c

# Fri Jan 23 15:56:05 2009 tlyu (Taylor Yu) - Subject changed from 'gss-api - mutex_lock problem' to 'lib/gssapi/krb5/init_sec_context.c: don't leak on mutex_lock failure'

# Fri Jan 23 15:56:05 2009 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'

# Fri Jan 30 23:08:20 2009 tlyu (Taylor Yu) - Version_Fixed 1.7 added

Ticket History #6294: lib/gssapi/krb5/init_sec_context.c: don't leak on mutex_lock failure