Skip Menu |
 

Download (untitled) / with headers
text/plain 7.1KiB
From krb5-bugs-incoming-bounces@PCH.mit.edu Tue Dec 9 21:21:29 2008
Return-Path: <krb5-bugs-incoming-bounces@PCH.mit.edu>
X-Original-To: krb5-send-pr-nospam1@krbdev.mit.edu
Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90])
by krbdev.mit.edu (Postfix) with ESMTP id 779AECCC93;
Tue, 9 Dec 2008 21:21:29 +0000 (UTC)
Received: from pch.mit.edu (pch.mit.edu [127.0.0.1])
by pch.mit.edu (8.13.6/8.12.8) with ESMTP id mB9LLTn4005010;
Tue, 9 Dec 2008 16:21:29 -0500
Received: from biscayne-one-station.mit.edu (BISCAYNE-ONE-STATION.MIT.EDU
[18.7.7.80])
by pch.mit.edu (8.13.6/8.12.8) with ESMTP id mB9LKBWd004794
for <krb5-bugs-incoming@PCH.mit.edu>; Tue, 9 Dec 2008 16:20:11 -0500
Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
by biscayne-one-station.mit.edu (8.13.6/8.9.2) with ESMTP id
mB9LK99j024436
for <krb5-bugs@mit.edu>; Tue, 9 Dec 2008 16:20:09 -0500 (EST)
Received: from cathode-dark-space.mit.edu (CATHODE-DARK-SPACE.MIT.EDU
[18.18.1.96]) (authenticated bits=56)
(User authenticated as tlyu@ATHENA.MIT.EDU)
by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id mB9LK8n6023960
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT)
for <krb5-bugs@mit.edu>; Tue, 9 Dec 2008 16:20:08 -0500 (EST)
Received: (from tlyu@localhost) by cathode-dark-space.mit.edu (8.12.9.20060308)
id mB9LK8ds029694; Tue, 9 Dec 2008 16:20:08 -0500 (EST)
Received: from fort-point-station.mit.edu (FORT-POINT-STATION.MIT.EDU
[18.7.7.76])
by pch.mit.edu (8.13.6/8.12.8) with ESMTP id mB85AtQO001334
for <krb5-bugs-incoming@PCH.mit.edu>; Mon, 8 Dec 2008 00:10:55 -0500
Received: from mit.edu (M24-004-BARRACUDA-2.MIT.EDU [18.7.7.112])
by fort-point-station.mit.edu (8.13.6/8.9.2) with ESMTP id
mB85AndN011663
for <krb5-bugs@mit.edu>; Mon, 8 Dec 2008 00:10:49 -0500 (EST)
Received: from cpmx.mail.saic.com (cpmx.mail.saic.com [139.121.17.160])
by mit.edu (Spam Firewall) with ESMTP id CB00513CFABC
for <krb5-bugs@mit.edu>; Mon, 8 Dec 2008 00:10:27 -0500 (EST)
Received: from 0599-ITS-SMS01 ([139.121.21.144] [139.121.21.144]) by
cpmx.mail.saic.com with ESMTP id BT-MMP-1878426 for
krb5-bugs@mit.edu; Sun, 7 Dec 2008 21:10:23 -0800
X-AuditID: 8b79118b-aa3c3ba000002a1c-94-493cac3fcf1f
Received: from mx2.west.saic.com (unknown [139.121.21.144])
by 0599-ITS-SMS01 (Symantec Mail Security) with ESMTP id 404F020131
for <krb5-bugs@mit.edu>; Sun, 7 Dec 2008 21:10:23 -0800 (PST)
X-SAIC-EXTERNAL-IP: [59.167.195.66]
Received: from eth3395.vic.adsl.internode.on.net (HELO
pan.teratext.saic.com.au) ([59.167.195.66])
by mx2.west.saic.com with ESMTP; 07 Dec 2008 21:10:22 -0800
Received: from atlas.teratext.com.au (atlas.teratext.saic.com.au
[192.168.0.13])
by pan.teratext.saic.com.au (Postfix) with ESMTP id 8969DA4F1D
for <krb5-bugs@mit.edu>; Mon, 8 Dec 2008 16:10:20 +1100 (EST)
Received: by atlas.teratext.com.au (Postfix, from userid 231)
id 7185031821; Mon, 8 Dec 2008 16:10:20 +1100 (EST)
To: krb5-bugs@MIT.EDU
From: msf@teratext.com.au
X-send-pr-version: 3.99
Date: Mon, 8 Dec 2008 16:10:20 +1100 (EST)
X-Brightmail-Tracker: AAAAAA==
X-Spam-Score: 0.00
X-Spam-Score: 1.50
X-Spam-Level: * (1.50)
X-Spam-Flag: NO
X-Spam-Flag: NO
X-Scanned-By: MIMEDefang 2.42
Message-ID: <ldvmyf559mi.fsf@cathode-dark-space.mit.edu>
Lines: 78
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailman-Approved-At: Tue, 09 Dec 2008 16:20:36 -0500
X-BeenThere: krb5-bugs-incoming@mailman.mit.edu
X-Mailman-Version: 2.1.6
Precedence: list
Reply-To: msf@teratext.com.au
Sender: krb5-bugs-incoming-bounces@PCH.mit.edu
Errors-To: krb5-bugs-incoming-bounces@PCH.mit.edu


Show quoted text
>Submitter-Id: msf
>Originator: Michael Fuller
>Organization:
SAIC Pty Ltd (Australia)
Show quoted text
>Confidential: no
>Synopsis: "make check" fails due to rb5_cc_new_unique() on 64-bit Solaris SPARC under Sun Studio
>Severity: serious
>Priority: medium
>Category: test
>Class: sw-bug
>Release: 1.6.3
>Environment:

System: SunOS atlas 5.10 Generic_118833-24 sun4u sparc SUNW,Sun-Fire-880
Architecture: sun4
Show quoted text
>Description:
"make check" fails due to a crash in src/lib/krb5/ccache/t_cc.

The failure in krb5-1.6.3/src/lib/krb5/ccache/t_cc.c occurs in or
near test code that was re-enabled and re-worked in v1.6.3 as part
of the introduction of the new krb5_cc_new_unique() API function.

The failure occurs in 64-bit mode on SPARC Solaris under Sun Studio (5.8).
The failure does not occur on 32-bit SPARC Solaris under Sun Studio (5.8).
The failure does not occur on 64-bit x86-64 Solaris under gcc (3.4.3).

Show quoted text
>How-To-Repeat:
Configure and build the 1.6.3 release in 64-bit mode on a
SPARC Solaris box using Sun Studio 5.8, then run "make check":
src/lib/krb5/ccache/t_cc will crash.

bash% uname -a
SunOS atlas 5.10 Generic_118833-24 sun4u sparc SUNW,Sun-Fire-880

bash% cc -V
cc: Sun C 5.8 Patch 121015-04 2007/01/10
`
bash% export PATH=/usr/ccs/bin:$PATH
bash% export PATH=/opt/SUNWspro/bin:$PATH
bash% configure --prefix=/tmp/krb5-1.6.3-CC CC=cc CFLAGS=-xarch=v9 1> ,configure 2>&1
bash% make 1> ,make 2>&1
bash% sudo make install 1> ,make-install 2>&1
bash% export PATH=/tmp/krb5-1.6.3-CC/sbin:$PATH
bash% export PATH=/tmp/krb5-1.6.3-CC/bin:$PATH
bash% export LD_LIBRARY_PATH=/tmp/krb5-1.6.3-CC/lib:$LD_LIBRARY_PATH
bash% make check 1> ,make-check 2>&1
bash% tail -100 < ,make-check | head -22
making check in lib/krb5/ccache...
cc -I../../../include -I./../../../include -I./ccapi -DKRB5_DEPRECATED=1 -DKRB5_PRIVATE=1 -xarch=v9 -D_REENTRANT -c t_cc.c
"t_cc.c", line 140: warning: implicit function declaration: strdup
"t_cc.c", line 140: warning: improper pointer/integer combination: op "="
"t_cc.c", line 303: warning: argument #2 is incompatible with prototype:
prototype: pointer to struct _krb5_cc_ops {} : "../../../include/krb5/krb5.h", line 2068
argument : pointer to const struct _krb5_cc_ops {}
"t_cc.c", line 308: warning: argument #2 is incompatible with prototype:
prototype: pointer to struct _krb5_cc_ops {} : "../../../include/krb5/krb5.h", line 2068
argument : pointer to const struct _krb5_cc_ops {}
"t_cc.c", line 314: warning: argument #2 is incompatible with prototype:
prototype: pointer to struct _krb5_cc_ops {} : "../../../include/krb5/krb5.h", line 2068
argument : pointer to const struct _krb5_cc_ops {}
"t_cc.c", line 320: warning: argument #2 is incompatible with prototype:
prototype: pointer to struct _krb5_cc_ops {} : "../../../include/krb5/krb5.h", line 2068
argument : pointer to const struct _krb5_cc_ops {}
cc -L../../../lib -R/tmp/krb5-1.6.3-CC/lib -xarch=v9 -o t_cc t_cc.o -lkrb5 -lk5crypto -lcom_err -lkrb5support -lresolv -lsocket -lnsl
KRB5_CONFIG=./t_krb5.conf ; export KRB5_CONFIG ;\
LD_LIBRARY_PATH=`echo -L../../../lib | sed -e "s/-L//g" -e "s/ /:/g"`; export LD_LIBRARY_PATH; ./t_cc
Testing miscellaneous error conditions
*** Error code 139
make: Fatal error: Command failed for target `check-unix'

Show quoted text
>Fix:
The bug may be in the test case itself (but I don't think so);
There may be a 64-bit problem in the new krb5_cc_new_unique()
code, or there may be a straight bug that is not exposed on
all architectures/compiler combinations.
(Or there may be a bug in Sun Studio 5.8, of course.)
To: rt@krbdev.MIT.EDU
Subject: Re: [krbdev.mit.edu #6297] "make check" fails due to rb5_cc_new_unique() on 64-bit Solaris SPARC under Sun Studio
From: Tom Yu <tlyu@MIT.EDU>
Date: Tue, 09 Dec 2008 16:44:56 -0500
RT-Send-Cc:
"The RT System itself via RT" <rt-comment@krbdev.mit.edu> writes:

Show quoted text
> bash% tail -100 < ,make-check | head -22
> making check in lib/krb5/ccache...
> cc -I../../../include -I./../../../include -I./ccapi -DKRB5_DEPRECATED=1 -DKRB5_PRIVATE=1 -xarch=v9 -D_REENTRANT -c t_cc.c
> "t_cc.c", line 140: warning: implicit function declaration: strdup
> "t_cc.c", line 140: warning: improper pointer/integer combination: op "="

Does adding an inclusion of <string.h> to the beginning of that file help?
From: Ken Raeburn <raeburn@MIT.EDU>
To: rt@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #6297] "make check" fails due to rb5_cc_new_unique() on 64-bit Solaris SPARC under Sun Studio
Date: Tue, 9 Dec 2008 16:40:23 -0500
RT-Send-Cc:
On Dec 8, 2008, Michael Fuller wrote:
Show quoted text
> making check in lib/krb5/ccache...
> cc -I../../../include -I./../../../include -I./ccapi -
> DKRB5_DEPRECATED=1 -DKRB5_PRIVATE=1 -xarch=v9 -D_REENTRANT -c t_cc.c
> "t_cc.c", line 140: warning: implicit function declaration: strdup
> "t_cc.c", line 140: warning: improper pointer/integer combination:
> op "="

In 64-bit mode, where the implicit "int" return type is a 32-bit value
and the real return value is a 64-bit value, yes, this will cause
problems.

In the string.h header on my system, defining _REENTRANT appears to be
one of the ways to get the declaration for strdup() to be used. I'm
using:

cc: Sun C 5.9 SunOS_sparc 2007/05/03

What does it take under 5.8?

Ken
From: Ken Raeburn <raeburn@MIT.EDU>
To: rt@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #6297] "make check" fails due to rb5_cc_new_unique() on 64-bit Solaris SPARC under Sun Studio
Date: Tue, 9 Dec 2008 17:04:42 -0500
RT-Send-Cc:
On Dec 9, 2008, at 16:44, Tom Yu via RT wrote:
Show quoted text
> "The RT System itself via RT" <rt-comment@krbdev.mit.edu> writes:
>
>> bash% tail -100 < ,make-check | head -22
>> making check in lib/krb5/ccache...
>> cc -I../../../include -I./../../../include -I./ccapi -
>> DKRB5_DEPRECATED=1 -DKRB5_PRIVATE=1 -xarch=v9 -D_REENTRANT -c
>> t_cc.c
>> "t_cc.c", line 140: warning: implicit function declaration: strdup
>> "t_cc.c", line 140: warning: improper pointer/integer combination:
>> op "="
>
> Does adding an inclusion of <string.h> to the beginning of that file
> help?

Oh, oops, I didn't notice we weren't including string.h in that
release...

Ken
Date: Wed, 10 Dec 2008 09:41:14 +1100
From: Michael Fuller <MICHAEL.S.FULLER@saic.com>
To: Tom Yu via RT <rt-comment@krbdev.mit.edu>
Subject: Re: [krbdev.mit.edu #6297] "make check" fails due to rb5_cc_new_unique() on 64-bit Solaris SPARC under Sun Studio
RT-Send-Cc:
Download (untitled) / with headers
text/plain 2.2KiB
Show quoted text
>> bash% tail -100 < ,make-check | head -22
>> making check in lib/krb5/ccache...
>> cc -I../../../include -I./../../../include -I./ccapi -DKRB5_DEPRECATED=1 -DKRB5_PRIVATE=1 -xarch=v9 -D_REENTRANT -c t_cc.c
>> "t_cc.c", line 140: warning: implicit function declaration: strdup
>> "t_cc.c", line 140: warning: improper pointer/integer combination: op "="
>
> Does adding an inclusion of <string.h> to the beginning of that file help?

Yes, it does; the above warnings disappear and the test no longer crashes:
[...]
making check in lib/krb5/ccache...
cc -I../../../include -I./../../../include -I./ccapi -DKRB5_DEPRECATED=1 -DKRB5_PRIVATE=1 -xarch=v9 -D_REENTRANT -c t_cc.c
"t_cc.c", line 304: warning: argument #2 is incompatible with prototype:
prototype: pointer to struct _krb5_cc_ops {} : "../../../include/krb5/krb5.h", line 2068
argument : pointer to const struct _krb5_cc_ops {}
"t_cc.c", line 309: warning: argument #2 is incompatible with prototype:
prototype: pointer to struct _krb5_cc_ops {} : "../../../include/krb5/krb5.h", line 2068
argument : pointer to const struct _krb5_cc_ops {}
"t_cc.c", line 315: warning: argument #2 is incompatible with prototype:
prototype: pointer to struct _krb5_cc_ops {} : "../../../include/krb5/krb5.h", line 2068
argument : pointer to const struct _krb5_cc_ops {}
"t_cc.c", line 321: warning: argument #2 is incompatible with prototype:
prototype: pointer to struct _krb5_cc_ops {} : "../../../include/krb5/krb5.h", line 2068
argument : pointer to const struct _krb5_cc_ops {}
cc -L../../../lib -R/tmp/krb5-1.6.3-CC/lib -xarch=v9 -o t_cc t_cc.o -lkrb5 -lk5crypto -lcom_err -lkrb5support -lresolv -lsocket -lnsl
KRB5_CONFIG=./t_krb5.conf ; export KRB5_CONFIG ;\
LD_LIBRARY_PATH=`echo -L../../../lib | sed -e "s/-L//g" -e "s/ /:/g"`; export LD_LIBRARY_PATH; ./t_cc
Testing miscellaneous error conditions
Starting test on /tmp/cctest.28984
Test on /tmp/cctest.28984 passed
Skiping KEYRING: test - unregistered type
Starting test on MEMORY:/tmp/cctest.28984
Test on MEMORY:/tmp/cctest.28984 passed
Starting test on FILE:/tmp/cctest.28984
Test on FILE:/tmp/cctest.28984 passed
[...]

Thanks;

Regards,
Michael
Already works on the trunk, should be fixed in 1.7.
From: raeburn@mit.edu
Subject: SVN Commit

For Sun Studio compilers, set WARN_CFLAGS to emit warning tag names
and make int/ptr mixups a fatal error that will be noticed at build or
"make check" time. Tested in a 32-bit build.

https://github.com/krb5/krb5/commit/75841b4eb32d6b1bc90a097958f7c61235c4ff87
Commit By: raeburn



Revision: 21325
Changed Files:
U trunk/src/aclocal.m4