Skip Menu |
 

History Show all quoted text — Show full headers
# Fri Dec 12 15:07:35 2008 tsitkova (Zhanna Tsitkova) - Ticket created
Subject: krb5_stdccv3_remove mem leak
CC: lha@apple.com
Download (untitled) / with headers
text/plain 87B
Mem leak in ccapi/stdcc.c

Vendor's patch - LHA-6431228-krb5_stdccv3_remove-leaks.patch
# Fri Dec 12 15:09:14 2008 tsitkova (Zhanna Tsitkova) - Comments added
Download (untitled) / with headers
text/plain 19B
Attaching the patch
Download LHA-6431228-krb5_stdccv3_remove-leaks.patch
text/plain 792B
diff -Nur -x '*~' -x '*.orig' -x '*.rej' -x '*.pbxbtree' -x '*.pbxindex' -x lha.mode1v3 -x lha.mode2v3 -x lha.pbxuser -x windows -x .DS_Store Kerberos.AEP-6.5fc1.orig/KerberosFramework/Kerberos5/Sources/lib/krb5/ccache/ccapi/stdcc.c Kerberos.AEP-6.5fc1/KerberosFramework/Kerberos5/Sources/lib/krb5/ccache/ccapi/stdcc.c
--- Kerberos.AEP-6.5fc1.orig/KerberosFramework/Kerberos5/Sources/lib/krb5/ccache/ccapi/stdcc.c 2008-12-08 14:02:55.000000000 -0800
+++ Kerberos.AEP-6.5fc1/KerberosFramework/Kerberos5/Sources/lib/krb5/ccache/ccapi/stdcc.c 2008-12-09 11:52:11.000000000 -0800
@@ -851,6 +851,8 @@
}
if (err == ccIteratorEnd) { err = ccErrCredentialsNotFound; }

+ if (iterator) cc_credentials_iterator_release (iterator);
+
if (!err) {
cache_changed ();
}
# Fri Dec 12 15:09:42 2008 tsitkova (Zhanna Tsitkova) - Ticket 6299 MemberOf ticket 6204.
# Fri Dec 12 16:09:28 2008 tsitkova (Zhanna Tsitkova) - Target_Version 1.7 added
# Fri Dec 12 16:11:44 2008 tsitkova (Zhanna Tsitkova) - Given to tsitkova (Zhanna Tsitkova)
# Fri Dec 12 16:13:09 2008 tsitkova (Zhanna Tsitkova) - Priority changed from (no value) to '80'
# Mon Dec 15 21:41:21 2008 tsitkova (Zhanna Tsitkova) - Status changed from 'new' to 'review'
# Mon Dec 15 21:41:21 2008 tsitkova (Zhanna Tsitkova) - Correspondence added
From: tsitkova@mit.edu
Subject: SVN Commit
Download (untitled) / with headers
text/plain 219B

Fixed memory leak in krb5_stdccv3_remove.

https://github.com/krb5/krb5/commit/e1aeb84e941ebfee21440438e82782e867a664ce
Commit By: tsitkova



Revision: 21362
Changed Files:
U trunk/src/lib/krb5/ccache/ccapi/stdcc.c
# Fri Jan 30 13:01:10 2009 ghudson@mit.edu (Greg Hudson) - Status changed from 'review' to 'open'
# Fri Jan 30 13:01:10 2009 ghudson@mit.edu (Greg Hudson) - Correspondence added
Download (untitled) / with headers
text/plain 358B
This patch appears to blow away the value of err from the loop. If, for
instance, the specified credential is not found, the function would
probably return successfully anyway because it was able to release the
iterator.

Also, if credentials were successfully removed but the iterator could
not be released, cache_changed() should probably still be called.
# Wed Sep 09 19:33:00 2015 tlyu (Taylor Yu) - Status changed from 'open' to 'resolved'
# Wed Sep 09 19:33:00 2015 tlyu (Taylor Yu) - Tags noresource added