Ticket History #6486: t_pac fails on SPARC Solaris

# Tue May 12 18:20:01 2009 tlyu (Taylor Yu) - Ticket created

Subject:

t_pac fails on SPARC Solaris

Download (untitled) / with headers
text/plain 261B

During make check:

LD_LIBRARY_PATH=`echo -L../../../lib | sed -e "s/-L//g" -e "s/ /:/g"`; export
LD_LIBRARY_PATH; ./t_pac
t_pac: krb5_pac_verify: Invalid argument

The test passes on x86 Linux and x86 Mac OS 10.5, I believe. I suspect an endianness problem.

# Wed May 13 16:41:39 2009 tlyu (Taylor Yu) - Given to tlyu (Taylor Yu)

# Wed May 13 16:41:39 2009 tlyu (Taylor Yu) - Target_Version 1.7 added

# Wed May 13 16:41:39 2009 tlyu (Taylor Yu) - Status changed from 'new' to 'review'

# Wed May 13 16:41:39 2009 tlyu (Taylor Yu) - Tags pullup added

# Wed May 13 16:41:39 2009 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	SVN Commit

Download (untitled) / with headers
text/plain 552B

In util/support/utf8_conv.c, the SWAP16 macro is invoked with an
argument that has side effects. On platforms where SWAP16 can
evaluate its argument twice (including platforms where utf8_conv.c
creates a fallback definition for the SWAP16 macro), this can cause a
read overrun by a factor of two.

Rearrange the data flow to avoid calling SWAP16 with an argument that
has side effects.

https://github.com/krb5/krb5/commit/9c6c6de0ac5b08c31585350309cb85964b8e01e1
Commit By: tlyu
Revision: 22348
Changed Files:
U trunk/src/util/support/utf8_conv.c

# Sun May 24 18:50:19 2009 tlyu (Taylor Yu) - Version_Fixed 1.7 added

# Sun May 24 18:50:19 2009 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	SVN Commit

Download (untitled) / with headers
text/plain 796B

pull up r22348 from trunk

------------------------------------------------------------------------
r22348 | tlyu | 2009-05-13 22:41:37 +0200 (Wed, 13 May 2009) | 13 lines

ticket: 6486
tags: pullup
target_version: 1.7

In util/support/utf8_conv.c, the SWAP16 macro is invoked with an
argument that has side effects. On platforms where SWAP16 can
evaluate its argument twice (including platforms where utf8_conv.c
creates a fallback definition for the SWAP16 macro), this can cause a
read overrun by a factor of two.

Rearrange the data flow to avoid calling SWAP16 with an argument that
has side effects.

https://github.com/krb5/krb5/commit/2fd6b6c82430f8544d01542ba8573f7bf3218bb5
Commit By: tlyu
Revision: 22371
Changed Files:
U branches/krb5-1-7/src/util/support/utf8_conv.c

# Wed Dec 16 18:02:54 2015 tlyu (Taylor Yu) - CustomField pullup deleted

# Sun Sep 24 20:39:54 2017 ghudson@mit.edu (Greg Hudson) - Status changed from 'review' to 'resolved'