Skip Menu |
 

History Show all quoted text — Show full headers
# Wed Aug 19 18:56:35 2009 tlyu (Taylor Yu) - Ticket created
To: krb5-bugs@MIT.EDU
Subject: strptime() doesn't like being touched that way by krb5_ldap_get_time
From: Tom Yu <tlyu@MIT.EDU>
Date: Wed, 19 Aug 2009 18:56:27 -0400
Download (untitled) / with headers
text/plain 732B
I noticed this problem on Mac OS X, but we probably want to fix it in
the general case for portability reasons.

getepochtime(), called by krb5_ldap_get_time(), passes a format string
of "%Y%m%d%H%M%SZ" to strptime(), causing a a return of EINVAL on Mac
OS X when any KDC programs attempt to fetch the master key list when
using an LDAP back end. According to POSIX / SUS, the application
must provide nonalphanumeric separators between format specifiers in
the format string of strptime().

Experimentation with a test program implies that the "%Y" format
specifier to strptime() tries to eat as many digits as it can, which
is about ten. This happens to be the number of decimal digits
required to represent a 32-bit integer...
# Wed Aug 19 23:08:27 2009 raeburn (Ken Raeburn) - Comments added
From: Ken Raeburn <raeburn@MIT.EDU>
To: rt-comment@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #6548] strptime() doesn't like being touched that way by krb5_ldap_get_time
Date: Wed, 19 Aug 2009 23:08:23 -0400
RT-Send-Cc:
Download (untitled) / with headers
text/plain 873B
On Aug 19, 2009, at 18:56, Tom Yu via RT wrote:
Show quoted text
> I noticed this problem on Mac OS X, but we probably want to fix it in
> the general case for portability reasons.
>
> getepochtime(), called by krb5_ldap_get_time(), passes a format string
> of "%Y%m%d%H%M%SZ" to strptime(), causing a a return of EINVAL on Mac
> OS X when any KDC programs attempt to fetch the master key list when
> using an LDAP back end. According to POSIX / SUS, the application
> must provide nonalphanumeric separators between format specifiers in
> the format string of strptime().

I think we might see similar problems in krb5_string_to_timestamp,
too. Currently it ignores conversion errors (assumes that the pattern
tried wasn't applicable so the next pattern should be tried). The
t_kerb test program can exercise krb5_string_to_timestamp, but we
don't currently have it do so.

Ken
# Wed Nov 14 16:02:22 2012 tlyu (Taylor Yu) - Subject changed from 'strptime() doesn't like being touched that way by krb5_ldap_get_time' to 'strptime() "%Y" format on Mac OS X can be too greedy'
# Wed Nov 14 16:02:22 2012 tlyu (Taylor Yu) - Status changed from 'new' to 'open'
# Tue Dec 31 14:31:22 2013 tlyu (Taylor Yu) - Status changed from 'open' to 'resolved'
# Tue Dec 31 14:31:22 2013 tlyu (Taylor Yu) - Tags nochange added