Skip Menu |
 

From: Ken Raeburn <raeburn@MIT.EDU>
To: krb5-bugs@MIT.EDU
Subject: uninitialized values used in mkey-migration code
Date: Wed, 30 Dec 2009 23:43:24 -0500
kdb5_mkey.c:kdb5_add_mkey declares and uses new_mkey_kvno without
setting it

No automated tests currently exercise that code anyways, and the tests
in src/tests/mk_migr don't bother to examine the mkvno values. (Not
that you're guaranteed to get something recognizable as garbage, of
course.)

Ken
From: raeburn@mit.edu
Subject: SVN Commit

Instead of passing a 0 to add_new_mkey for kvno and leaving
new_mkey_kvno (used when stashing) uninitialized, use get_next_kvno to
set the latter to the only non-zero value that add_new_mkey will
accept.

https://github.com/krb5/krb5/commit/c7586cc94818ff865ca9a057d32c0fb40a7c3688
Commit By: raeburn
Revision: 25148
Changed Files:
U trunk/src/kadmin/dbutil/kdb5_mkey.c