Skip Menu |
 

From: Jason Rogers <jrogers@sinenomine.net>
To: "krb5-bugs@mit.edu" <krb5-bugs@mit.edu>
Date: Mon, 12 Apr 2010 14:50:06 -0500
Subject: Incremental propagation log time stamp issue
Incremental propagation log time stamp issue Greetings,

There is an issue in 1.7.1 and 1.8 (at least) such that the incremental propagation log time stamp returned, through kproplog, on  a 64bit Centos/RHEL platform is nonsensical, while it is correct on a 32bit platform.

The following change in casting corrects this:

@@ -386,6 +386,7 @@
     char                *dbprinc;
     kdb_ent_header_t    *indx_log;
     kdb_incr_update_t   upd;
+    time_t              tstamp;

     if (entry && (entry < ulog->kdb_num))
         start_sno = ulog->kdb_last_sno - entry;
@@ -445,9 +446,11 @@

         if (indx_log->kdb_time.seconds == 0L)
             (void) printf(_("\tUpdate time stamp : None\n"));
-        else
+        else  {
+            tstamp = (time_t) indx_log->kdb_time.seconds;
             (void) printf(_("\tUpdate time stamp : %s"),
-                          ctime((time_t *)&(indx_log->kdb_time.seconds)));
+                         ctime(&tstamp));
+        }

         (void) printf(_("\tAttributes changed : %d\n"),
                       upd.kdb_update.kdbe_t_len);


Thank you,

Jason Rogers
Sine Nomine Associates
From: tlyu@mit.edu
Subject: SVN Commit

Adapted patch from Jason Rogers. It wasn't complete, so this commit
fixes the other instances of the 64-bit problem.

Also fix krb5_deltat_to_str(), which would previously always return an
empty string.

https://github.com/krb5/krb5/commit/33fcef6a991d5697a9e2fa0c52d30349c1e88789
Commit By: tlyu
Revision: 23928
Changed Files:
U trunk/src/lib/krb5/krb/str_conv.c
U trunk/src/slave/kproplog.c
From: tlyu@mit.edu
Subject: SVN Commit

pull up r23928 from trunk

------------------------------------------------------------------------
r23928 | tlyu | 2010-04-22 21:10:20 -0400 (Thu, 22 Apr 2010) | 10 lines

ticket: 6698
target_version: 1.8.2
tags: pullup

Adapted patch from Jason Rogers. It wasn't complete, so this commit
fixes the other instances of the 64-bit problem.

Also fix krb5_deltat_to_str(), which would previously always return an
empty string.

https://github.com/krb5/krb5/commit/cc6d0c93fdd66886fce3fc4321e3d57bdf24887d
Commit By: tlyu
Revision: 24059
Changed Files:
U branches/krb5-1-8/src/lib/krb5/krb/str_conv.c
U branches/krb5-1-8/src/slave/kproplog.c