Skip Menu |
 

History Show all quoted text — Show full headers
# Mon Dec 06 13:52:38 2010 Derrick Brashear <shadow@gmail.com> - Ticket created
Date: Mon, 6 Dec 2010 13:06:59 -0500
Subject: accept_sec_context RFC4121 support bug in 1.8.3
From: Derrick Brashear <shadow@gmail.com>
To: krb5-bugs@mit.edu
Download (untitled) / with headers
text/plain 162B
While we're at it, RFC 4121 does not specify that rc4-hmac-exp is "not
newer", so the new token selector should be applied there. Patch
attached.




--
Derrick
Download mit18
application/octet-stream 441B

Message body not shown because it is not plain text.

# Mon Dec 06 13:52:38 2010 Derrick Brashear <shadow@gmail.com> - Ticket #6834: - Ticket created
Date: Mon, 6 Dec 2010 13:29:37 -0500
Subject: Re: accept_sec_context RFC4121 support bug in 1.8.3
From: Derrick Brashear <shadow@gmail.com>
To: krb5-bugs@mit.edu
Download (untitled) / with headers
text/plain 450B
Ah. You may disregard this, though the code should perhaps be
commented. RFC 4757 in defining rc4-hmac-exp explicitly
codifies the old token format, while not referring to RFC 4121.

On Mon, Dec 6, 2010 at 1:06 PM, Derrick Brashear <shadow@gmail.com> wrote:
Show quoted text
> While we're at it, RFC 4121 does not specify that rc4-hmac-exp is "not
> newer", so the new token selector should be applied there. Patch
> attached.
>
>
>
>
> --
> Derrick
>



--
Derrick
# Mon Dec 06 14:14:33 2010 tlyu (Taylor Yu) - Ticket #6834: - Ticket 6834 MergedInto ticket 6835.
# Tue Dec 07 17:15:35 2010 tlyu (Taylor Yu) - Correspondence added
To: rt@krbdev.MIT.EDU
Subject: Re: [krbdev.mit.edu #6835] Re: accept_sec_context RFC4121 support bug in 1.8.3
From: Tom Yu <tlyu@MIT.EDU>
Date: Tue, 07 Dec 2010 17:15:33 -0500
RT-Send-Cc:
Download (untitled) / with headers
text/plain 546B
"Derrick Brashear via RT" <rt-comment@krbdev.mit.edu> writes:

Show quoted text
> Ah. You may disregard this, though the code should perhaps be
> commented. RFC 4757 in defining rc4-hmac-exp explicitly
> codifies the old token format, while not referring to RFC 4121.

What should the comment say? Should it mention that RFC 4121
accidentally omitted rc4-hmac-exp from the list of "not-newer"?

I think there would need to be comments both in accept_sec_context.c
and util_crypt.c, because some of the RFC 4121 vs RFC 1964 selection
logic moved to util_crypt.c.
# Tue Dec 07 18:35:08 2010 Derrick Brashear <shadow@gmail.com> - Correspondence added
Date: Tue, 7 Dec 2010 18:35:07 -0500
Subject: Re: [krbdev.mit.edu #6835] Re: accept_sec_context RFC4121 support bug in 1.8.3
From: Derrick Brashear <shadow@gmail.com>
To: rt@krbdev.mit.edu
RT-Send-Cc:
Download (untitled) / with headers
text/plain 837B
On Tue, Dec 7, 2010 at 5:15 PM, Tom Yu via RT <rt-comment@krbdev.mit.edu> wrote:
Show quoted text
> "Derrick Brashear via RT" <rt-comment@krbdev.mit.edu> writes:
>
>> Ah. You may disregard this, though the code should perhaps be
>> commented. RFC 4757 in defining rc4-hmac-exp explicitly
>> codifies the old token format, while not referring to RFC 4121.
>
> What should the comment say?  Should it mention that RFC 4121
> accidentally omitted rc4-hmac-exp from the list of "not-newer"?

That would be my suggestion. I'd be less worried if there hadn't been deviances
from what is specified in versions of both MIT Kerberos and Heimdal.

Show quoted text
> I think there would need to be comments both in accept_sec_context.c
> and util_crypt.c, because some of the RFC 4121 vs RFC 1964 selection
> logic moved to util_crypt.c.

That seems reasonable.




--
Derrick
# Tue Dec 07 18:45:15 2010 tlyu (Taylor Yu) - Given to tlyu (Taylor Yu)
# Tue Dec 07 18:45:16 2010 tlyu (Taylor Yu) - Status changed from 'new' to 'review'
# Tue Dec 07 18:45:16 2010 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: SVN Commit
Download (untitled) / with headers
text/plain 400B

Add comment noting that RFC 4121 appears to omit RC4-HMAC from the
list of "not-newer" enctypes, even though RFC 4757 effectively treats
it as one. Suggested by Derrick Brashear.

https://github.com/krb5/krb5/commit/168f7bfc5927ab8bf6faad3e08ad8f32a99ee2fb
Commit By: tlyu
Revision: 24563
Changed Files:
U trunk/src/lib/gssapi/krb5/accept_sec_context.c
U trunk/src/lib/gssapi/krb5/util_crypt.c
# Tue Dec 07 18:53:32 2010 Derrick Brashear <shadow@gmail.com> - Correspondence added
Date: Tue, 7 Dec 2010 18:53:30 -0500
Subject: Re: [krbdev.mit.edu #6835] SVN Commit
From: Derrick Brashear <shadow@gmail.com>
To: rt@krbdev.mit.edu
RT-Send-Cc:
Download (untitled) / with headers
text/plain 584B
On Tue, Dec 7, 2010 at 6:45 PM, Tom Yu via RT <rt-comment@krbdev.mit.edu> wrote:
Show quoted text
>
> Add comment noting that RFC 4121 appears to omit RC4-HMAC from the
> list of "not-newer" enctypes, even though RFC 4757 effectively treats
> it as one.  Suggested by Derrick Brashear.

Er. RC4-HMAC-EXP, but you got it right in the comment.

Show quoted text
> https://github.com/krb5/krb5/commit/168f7bfc5927ab8bf6faad3e08ad8f32a99ee2fb
> Commit By: tlyu
> Revision: 24563
> Changed Files:
> U   trunk/src/lib/gssapi/krb5/accept_sec_context.c
> U   trunk/src/lib/gssapi/krb5/util_crypt.c
>
>



--
Derrick
# Mon Oct 17 19:01:23 2011 tlyu (Taylor Yu) - Version_Fixed 1.10 added
# Sun Sep 24 20:39:57 2017 ghudson@mit.edu (Greg Hudson) - Status changed from 'review' to 'resolved'