Skip Menu |
 

From: ghudson@mit.edu
Subject: SVN Commit

The dispatch() in kadmind's schpw.c could return a failure code with
an allocated response container. net-server.c does not expect this
and leaks the container in the UDP case. Free the container in
dispatch() if we are returning an error.


https://github.com/krb5/krb5/commit/4ffd70b133afea3d19fccbac269798c1d210c0fd
Commit By: ghudson
Revision: 24886
Changed Files:
U trunk/src/kadmin/server/schpw.c
From: ghudson@mit.edu
Subject: SVN Commit

Revert r24886; it was incorrect.


https://github.com/krb5/krb5/commit/fdac952438ff70c73a317aa847ef6472cb4e3000
Commit By: ghudson
Revision: 24887
Changed Files:
U trunk/src/kadmin/server/schpw.c
Although it's totally non-obvious, there is no memory leak after #6899.
When rep->data is allocated in process_chpw_request(), ret should always
be 0 (this is the non-obvious part). So when a non-zero return happens,
ret->data will be NULL, and the new code in #6899 will free the container.