Ticket History #6943: incorrect reference in spnego_gss_set_cred

# Wed Aug 10 14:41:39 2011 "Arlene Berry" <aberry@likewise.com> - Ticket created

From:	Arlene Berry <aberry@likewise.com>
To:	"krb5-bugs@mit.edu" <krb5-bugs@mit.edu>
Subject:	incorrect reference in spnego_gss_set_cred_option
Date:	Wed, 10 Aug 2011 18:13:45 +0000

Download (untitled) / with headers
text/plain 582B

In src/lib/gssapi/spnego/spnego_mech.c:

OM_uint32
KRB5_CALLCONV spnego_gss_set_cred_option(
OM_uint32 *minor_status,
gss_cred_id_t *cred_handle,
const gss_OID desired_object,
const gss_buffer_t value)
{
OM_uint32 ret;
OM_uint32 tmp_minor_status;
spnego_gss_cred_id_t spcred = (spnego_gss_cred_id_t)cred_handle;
gss_cred_id_t mcred;
...
*cred_handle = (gss_cred_id_t)spcred;

It looks to me like that initial spcred assignment should be *cred_handle, not cred_handle.

# Thu Aug 11 11:03:29 2011 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)

# Thu Aug 11 11:03:29 2011 ghudson@mit.edu (Greg Hudson) - Target_Version 1.9.2 added

# Thu Aug 11 11:03:29 2011 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'review'

# Thu Aug 11 11:03:30 2011 ghudson@mit.edu (Greg Hudson) - Tags pullup added

# Thu Aug 11 11:03:30 2011 ghudson@mit.edu (Greg Hudson) - Correspondence added

From:	ghudson@mit.edu
Subject:	SVN Commit

Download (untitled) / with headers
text/plain 299B

Correctly dereference cred_handle when assigning to spcred in
spnego_gss_set_cred_option. Reported by aberry@likewise.com.

https://github.com/krb5/krb5/commit/e9093e0805c49cddc86a6fef5154e77aa959f227
Commit By: ghudson
Revision: 25096
Changed Files:
U trunk/src/lib/gssapi/spnego/spnego_mech.c

# Tue Oct 18 16:42:46 2011 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'

# Tue Oct 18 16:42:46 2011 tlyu (Taylor Yu) - Version_Fixed 1.9.2 added

# Tue Oct 18 16:42:46 2011 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	SVN Commit

Download (untitled) / with headers
text/plain 539B

pull up r25096 from trunk

------------------------------------------------------------------------
r25096 | ghudson | 2011-08-11 11:03:28 -0400 (Thu, 11 Aug 2011) | 7 lines

ticket: 6943
target_version: 1.9.2
tags: pullup

Correctly dereference cred_handle when assigning to spcred in
spnego_gss_set_cred_option. Reported by aberry@likewise.com.

https://github.com/krb5/krb5/commit/441a7fa63b8be0645c3586545fd1eed010071020
Commit By: tlyu
Revision: 25378
Changed Files:
U branches/krb5-1-9/src/lib/gssapi/spnego/spnego_mech.c

# Wed Dec 16 18:02:57 2015 tlyu (Taylor Yu) - CustomField pullup deleted

Ticket History #6943: incorrect reference in spnego_gss_set_cred_option