Skip Menu |
 

History Show all quoted text — Show full headers
# Tue Dec 27 14:23:10 2011 Richard Basch <basch@alum.mit.edu> - Ticket created
Date: Tue, 27 Dec 2011 14:09:43 -0500
From: Richard Basch <basch@alum.mit.edu>
Subject: Krb5 1.9.x does not build on Solaris 8 - Implicit function declaration error
To: krb5-bugs@mit.edu, krbdev@mit.edu
CC: prakash.madiraju@gs.com, richard.basch@gs.com
Download (untitled) / with headers
text/plain 711B
Kerberos 1.9.x does not build on Solaris 8, using gcc. I trace the problem
down to the build now setting the gcc flag
-werror-implicit-function-declaration, which it did not previously include
in Kerberos 1.8.x builds. 'ksu' still has an implicit function declaration
for strcpy and memcpy because Solaris lacks a setenv() function in libc and
thus includes the offending code.

Enclosed is the patch...


--- src/clients/ksu/setenv.c.orig 2009-10-30 20:48:38.000000000 -0400
+++ src/clients/ksu/setenv.c 2011-12-27 14:03:05.000000000 -0500
@@ -21,6 +21,7 @@
#include <sys/types.h>
#include <stdio.h>
#include <stdlib.h>
+#include <string.h>
#include "autoconf.h"

static char *_findenv(char *, int *);
# Tue Dec 27 20:32:00 2011 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)
# Tue Dec 27 20:32:00 2011 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'review'
# Tue Dec 27 20:32:00 2011 ghudson@mit.edu (Greg Hudson) - Correspondence added
From: ghudson@mit.edu
Subject: SVN Commit
Download (untitled) / with headers
text/plain 312B

Fix implicit declaration in ksu for some builds

ksu's setenv implementation needs to include <string.h> for memcpy.
Patch from basch@alum.mit.edu.

https://github.com/krb5/krb5/commit/08d4890edef5bd809da597d8de056c85800224d0
Commit By: ghudson
Revision: 25605
Changed Files:
U trunk/src/clients/ksu/setenv.c
# Tue Jan 10 16:36:48 2012 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'
# Tue Jan 10 16:36:48 2012 tlyu (Taylor Yu) - Version_Fixed 1.10 added
# Tue Jan 10 16:36:48 2012 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: SVN Commit
Download (untitled) / with headers
text/plain 517B

Pull up r25605 from trunk

------------------------------------------------------------------------
r25605 | ghudson | 2011-12-27 20:31:59 -0500 (Tue, 27 Dec 2011) | 7 lines

ticket: 7057

Fix implicit declaration in ksu for some builds

ksu's setenv implementation needs to include <string.h> for memcpy.
Patch from basch@alum.mit.edu.

https://github.com/krb5/krb5/commit/1c1828a5cf44065db30a566a25ee022e60ae2516
Commit By: tlyu
Revision: 25639
Changed Files:
U branches/krb5-1-10/src/clients/ksu/setenv.c