Skip Menu |
 

From: ghudson@mit.edu
Subject: SVN Commit

Don't touch the lookaside cache if we're responding with a lookaside
cache entry. Also, leave the null entry behind if we're deliberately
dropping a request (a rare case) so that we don't have to process it
again. Fixes several lookaside problems in 1.10:

* When dropping a request because it was already being processed, we
were erroneously removing the null entry, causing us to process the
request again upon a second retransmit.

* When responding to a finished request with a lookaside entry, we
were removing and re-adding the entry to the cache, resetting its
time and performing unnecessary work.

* We were not caching responses we couldn't deliver because they were
too big for UDP, causing us to re-process the request when it came
in again via TCP instead of simply delivering the cached response.

https://github.com/krb5/krb5/commit/548f8461c75c5638f0c24ca86364a17f59619b89
Commit By: ghudson
Revision: 25660
Changed Files:
U trunk/src/kdc/dispatch.c
From: tlyu@mit.edu
Subject: SVN Commit
Download (untitled) / with headers
text/plain 1.2KiB

Pull up r25660 from trunk

------------------------------------------------------------------------
r25660 | ghudson | 2012-01-26 16:56:16 -0500 (Thu, 26 Jan 2012) | 22 lines

ticket: 7082
subject: Various lookaside cache fixes
target_version: 1.10
tags: pullup

Don't touch the lookaside cache if we're responding with a lookaside
cache entry. Also, leave the null entry behind if we're deliberately
dropping a request (a rare case) so that we don't have to process it
again. Fixes several lookaside problems in 1.10:

* When dropping a request because it was already being processed, we
were erroneously removing the null entry, causing us to process the
request again upon a second retransmit.

* When responding to a finished request with a lookaside entry, we
were removing and re-adding the entry to the cache, resetting its
time and performing unnecessary work.

* We were not caching responses we couldn't deliver because they were
too big for UDP, causing us to re-process the request when it came
in again via TCP instead of simply delivering the cached response.

https://github.com/krb5/krb5/commit/72e9558135f4e0eabdb6aa1139c6dc59ea24b9fe
Commit By: tlyu
Revision: 25681
Changed Files:
U branches/krb5-1-10/src/kdc/dispatch.c