Ticket History #7112: KRB5_TRACE is broken in trunk

From krb5-bugs-incoming-bounces@PCH.mit.edu Thu Apr 5 09:33:57 2012
Return-Path: <krb5-bugs-incoming-bounces@PCH.mit.edu>
Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90])
by krbdev.mit.edu (Postfix) with ESMTP id 3E4CB3EC4B;
Thu, 5 Apr 2012 09:33:57 -0400 (EDT)
Received: from pch.mit.edu (pch.mit.edu [127.0.0.1])
by pch.mit.edu (8.13.6/8.12.8) with ESMTP id q35DXum0023928;
Thu, 5 Apr 2012 09:33:56 -0400
Received: from mailhub-dmz-1.mit.edu (MAILHUB-DMZ-1.MIT.EDU [18.9.21.41])
by pch.mit.edu (8.13.6/8.12.8) with ESMTP id q357vtZx009401
for <krb5-bugs-incoming@PCH.mit.edu>; Thu, 5 Apr 2012 03:57:55 -0400
Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU
[18.7.68.35])
by mailhub-dmz-1.mit.edu (8.13.8/8.9.2) with ESMTP id q357vo0p027287
for <krb5-bugs@mit.edu>; Thu, 5 Apr 2012 03:57:55 -0400
X-AuditID: 12074423-b7f9c6d0000008c3-0b-4f7d5081e44c
Authentication-Results: symauth.service.identifier; spf=pass; senderid=pass
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP
id 2F.56.02243.2805D7F4; Thu, 5 Apr 2012 03:57:54 -0400 (EDT)
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q357vrmC015672
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
for <krb5-bugs@mit.edu>; Thu, 5 Apr 2012 03:57:53 -0400
Received: from stef-desktop.thewalter.lan (ovpn-116-27.ams2.redhat.com
[10.36.116.27])
by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
id q357vqCX032593
for <krb5-bugs@mit.edu>; Thu, 5 Apr 2012 03:57:52 -0400
Message-ID: <4F7D507F.3050901@redhat.com>
Date: Thu, 05 Apr 2012 09:57:51 +0200
From: Stef Walter <stefw@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
rv:11.0) Gecko/20120329 Thunderbird/11.0.1
MIME-Version: 1.0
To: krb5-bugs@mit.edu
Subject: KRB5_TRACE is broken in trunk
Content-Type: multipart/mixed; boundary="------------050405010305080602060707"
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDKsWRWlGSWpSXmKPExsVysWW7jG5TQK2/weNzlhYND4+zOzB6NJ05
yhzAGMVlk5Kak1mWWqRvl8CVsef5NPaCZQIVm+7eZG1g3M7bxcjJISFgItF/9QM7iM0o4C3x
5upxdoi4mMSFe+vZuhi5OIQETjBK/H8wmR3C2cgksfDlX6jMG0aJzZ8WgrXwCmhKrD3/nQnE
ZhFQlVjwew0biM0moCIx790c5i5GDg5RgTCJ38ccIMoFJU7OfMICYosIiEq8/HsMzBYWUJP4
2vAcbCSzQIDE6z1r2SAu0pb43DyTZQIj/ywk7bOQlEHYOhLv+h4wQ9jyEtvfzoGygyTm7rrA
gikeLdHwpJN9ASP7KkbZlNwq3dzEzJzi1GTd4uTEvLzUIl0zvdzMEr3UlNJNjMDgFmJ3Ud7B
+Oeg0iFGAQ5GJR5ezck1/kKsiWXFlbmHGCU5mJREeff61/oL8SXlp1RmJBZnxBeV5qQWH2JU
Adr1aMPqC4xSLHn5ealKIrwaN4FaeVMSK6tSi/JhyqQ5WJTEeTW03vkJCaQnlqRmp6YWpBbB
ZJk42A8xynBwKEnw7gPZIliUmp5akZaZU4KshhNEcB1ilODgAVqzCqSQt7ggMbc4Mx2i6BSj
opQ471qQhABIIqM0D24AKFHV/////xKjrJQwLyMDA4MQD9AFwEBAyIMS3StGcWAACPNuBpnC
k5lXAjf9FdBiJqDFJ79WgywuSURISTUwZnlz8zzVPCA/l0/6De8i8a/T1t7JeVGk+b/mqPjp
1Zl7fkQ9U3E/qlod3mFe2VSj82FH2PT2Z10VMSbn08vyWG82iP6YdW5yU+hnpn8MIj0vZ6s/
fDBhSmyV8SEOo+wZcTW5orLdkeLs584vk9nRJfPg7UMb5a9z1ykuup5Rn1P3O7si+84TJZbi
jERDLeai4kQAbCkEc08DAAA=
X-Mailman-Approved-At: Thu, 05 Apr 2012 09:33:55 -0400
X-BeenThere: krb5-bugs-incoming@mailman.mit.edu
X-Mailman-Version: 2.1.6
Precedence: list
Sender: krb5-bugs-incoming-bounces@PCH.mit.edu
Errors-To: krb5-bugs-incoming-bounces@PCH.mit.edu

This is a multi-part message in MIME format.
--------------050405010305080602060707
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

System: Linux stef-desktop.thewalter.lan 3.3.0-8.fc17.x86_64 #1 SMP Thu
Mar 29 18:18:26 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux
Architecture: x86_64


KRB5_TRACE is initialized in krb5int_init_trace() but then later reset
to NULL during the initialization of a krb5_context.


Build krb5 from svn trunk. Try to do:

$ KRB5_TRACE=/tmp/krb5.log kinit User@REALM

No output to /tmp/krb5.log


Patch is attached.

--------------050405010305080602060707
Content-Type: text/x-patch;
name="0001-Unbreak-KRB5_TRACE-path-to-logfile.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="0001-Unbreak-KRB5_TRACE-path-to-logfile.patch"

From: Stef Walter <stefw@gnome.org>
Date: Thu, 5 Apr 2012 08:11:10 +0200
Subject: [PATCH 1/2] Unbreak KRB5_TRACE="/path/to/logfile"

* ctx->trace_callback was being reset late in initialization after
having been configured by krb5int_init_trace()
---
src/lib/krb5/krb/init_ctx.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/src/lib/krb5/krb/init_ctx.c b/src/lib/krb5/krb/init_ctx.c
index 784acbe..048e685 100644
--- a/src/lib/krb5/krb/init_ctx.c
+++ b/src/lib/krb5/krb/init_ctx.c
@@ -272,7 +272,6 @@ krb5_init_context_profile(profile_t profile, krb5_flags flags,
ctx->prompt_types = 0;
ctx->use_conf_ktypes = 0;
ctx->udp_pref_limit = -1;
- ctx->trace_callback = NULL;
*context_out = ctx;
return 0;

--
1.7.9.3


--------------050405010305080602060707--

Fix trace logging initialization

Reported by stefw@gnome.org.

https://github.com/krb5/krb5/commit/578224b2a26b076d40833f9a50edcb5496a19de5
Commit By: ghudson
Revision: 25803
Changed Files:
U trunk/src/lib/krb5/krb/init_ctx.c