Ticket History #7150: Does not build when CPPFLAGS=-DDEBUG is set.

From krb5-bugs-incoming-bounces@PCH.mit.edu Tue May 22 22:36:52 2012
Return-Path: <krb5-bugs-incoming-bounces@PCH.mit.edu>
Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90])
by krbdev.mit.edu (Postfix) with ESMTP id 7C7113E6FE;
Tue, 22 May 2012 22:36:52 -0400 (EDT)
Received: from pch.mit.edu (pch.mit.edu [127.0.0.1])
by pch.mit.edu (8.13.6/8.12.8) with ESMTP id q4N2aqjf026827;
Tue, 22 May 2012 22:36:52 -0400
Received: from mailhub-dmz-2.mit.edu (MAILHUB-DMZ-2.MIT.EDU [18.7.62.37])
by pch.mit.edu (8.13.6/8.12.8) with ESMTP id q4N0nXiW013747
for <krb5-bugs-incoming@PCH.mit.edu>; Tue, 22 May 2012 20:49:33 -0400
Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU
[18.7.68.36])
by mailhub-dmz-2.mit.edu (8.13.8/8.9.2) with ESMTP id q4N0n1l6015649
for <krb5-bugs@mit.edu>; Tue, 22 May 2012 20:49:32 -0400
X-AuditID: 12074424-b7fae6d000000906-aa-4fbc341c606d
Authentication-Results: symauth.service.identifier
Received: from laphotz.jpl.nasa.gov (wildcard.jpl.nasa.gov [128.149.133.44])
by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP
id C5.03.02310.C143CBF4; Tue, 22 May 2012 20:49:32 -0400 (EDT)
Received: by laphotz.jpl.nasa.gov (Postfix, from userid 1989)
id A8CB11286635; Tue, 22 May 2012 17:49:30 -0700 (PDT)
yEND-PR: Lines starting with `SEND-PR' will be removed automatically, as
To: krb5-bugs@mit.edu
Subject: Building with Debug Printout Enabled
From: hotz@jpl.nasa.gov
X-send-pr-version: 3.99
Message-Id: <20120523004930.A8CB11286635@laphotz.jpl.nasa.gov>
Date: Tue, 22 May 2012 17:49:30 -0700 (PDT)
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBIsWRWlGSWpSXmKPExsXSMLVVR1fGZI+/waZjmhYND4+zOzB6NJ05
yhzAGMVlk5Kak1mWWqRvl8CVce3OYuaCn7IVDRenMjUwvhHvYuTgkBAwkfhwTayLkZODUcBI
Yve5V6wgtoSAmMSFe+vZQGwhgauMEp8eiELYZRKv950Hq5EU8JB49mAlO4gtIiAq8fLvMRYQ
W1hAT2L1rB4wm01AXOJE2zcmiF5pidmbdoPNZBZgkfjzZgMLxC5xiR3bT7ODnMMrYCex/idY
OYuAtsTcDVvZJjDyLWBkWMUom5JbpZubmJlTnJqsW5ycmJeXWqRrrpebWaKXmlK6iREYFELs
Lio7GJsPKR1iFOBgVOLhLTq/21+INbGsuDL3EKMkB5OSKO9l3T3+QnxJ+SmVGYnFGfFFpTmp
xYcYJTiYlUR4108HKudNSaysSi3Kh0lJc7AoifOu1QRKCaQnlqRmp6YWpBbBZJk42A8xynBw
KEnw1hoDTRYsSk1PrUjLzClBVsMJIrhA1vAArREEKeQtLkjMLc5Mhyg6xajL8ePXomuMQix5
+XmpUuK880CKBECKMkrz4IaBIrz+////lxhlpYR5GRkYGIR4gK4BBgJCHpQgXjGKAwNAmDcK
ZApPZl4J3KZXQEcwAR0R9GInyBEliQgpqQbGHYeMvypxfZ+YIfpwknvvWv6e5yV+PVNDNwa7
/umcr/n//aFF71YdZQx6GTFDr1v/dUOpL+9uG81LSrty47btvcdSv7fnkEJQmJqO/23+FLt9
1ut1jYzasta4lL24KXK3yeV17rJTnvXVT0u+nL+RfVv4+0PLirtv17/hmHX5TY1Ipdgrn57Z
SizFGYmGWsxFxYkA4RWZK+sCAAA=
X-Mailman-Approved-At: Tue, 22 May 2012 22:36:49 -0400
X-BeenThere: krb5-bugs-incoming@mailman.mit.edu
X-Mailman-Version: 2.1.6
Precedence: list
Reply-To: hotz@jpl.nasa.gov
Sender: krb5-bugs-incoming-bounces@PCH.mit.edu
Errors-To: krb5-bugs-incoming-bounces@PCH.mit.edu


Jet Propulsion Laboratory
MacBook Pro, MacOS 10.6.8, MacOS 10.6.8, all
Intel VM, Scientific Linux 6.2, Scientific Linux 6.2, all
System: Darwin laphotz.jpl.nasa.gov 10.8.0 Darwin Kernel Version 10.8.0: Tue Jun 7 16:33:36 PDT 2011; root:xnu-1504.15.3~1/RELEASE_I386 i386


Several files do not compile cleanly when the DEBUG flag is set. I can't guarantee the fixes are identital for SL6 as MacOS, but they are at least very similar.
CFLAGS=-g CPPFLAGS="-DDEBUG -DDEBUG_ASN1 -DDEBUG_CERTCHAIN -DDEBUG_CKSUM -DDEBUG_DH -DDEBUG_MECHINFO -DDEBUG_SAN_INFO -DDEBUG_SIG -I/usr/local/include/openssl" LDFLAGS=-L/usr/local/lib LIBS=-lcrypto ./configure --prefix=/usr/local/mit19 --enable-pkinit --with-crypto-impl=openssl
make
Apply the following patches:
--- ./src/appl/simple/server/sim_server.c.orig 2012-05-10 00:43:52.000000000 -0700
+++ ./src/appl/simple/server/sim_server.c 2012-05-10 00:44:24.000000000 -0700
@@ -41,6 +41,7 @@
#include <sys/socket.h>
#include <netinet/in.h>
#include <netdb.h>
+#include <arpa/inet.h>

#include "com_err.h"

--- ./src/lib/crypto/openssl/des/des_int.h.orig 2012-05-09 15:13:08.000000000 -0700
+++ ./src/lib/crypto/openssl/des/des_int.h 2012-05-09 23:20:14.000000000 -0700
@@ -191,4 +191,7 @@
/* XXX depends on FILE being a #define! */
extern void test_set (FILE *, const char *, int, const char *, int);
#endif
+
+#include <openssl/des.h>
+
#endif /*DES_INTERNAL_DEFS*/
--- ./src/lib/gssapi/spnego/gssapiP_spnego.h.orig 2012-05-09 15:12:06.000000000 -0700
+++ ./src/lib/gssapi/spnego/gssapiP_spnego.h 2012-05-09 14:58:24.000000000 -0700
@@ -117,6 +117,7 @@
extern const gss_OID_set_desc * const gss_mech_set_spnego;

#ifdef DEBUG
+#include <syslog.h>
#define dsyslog(a) syslog(LOG_DEBUG, a)
#else
#define dsyslog(a)
--- ./src/lib/kadm5/srv/server_acl.c.orig 2012-05-10 00:35:44.000000000 -0700
+++ ./src/lib/kadm5/srv/server_acl.c 2012-05-10 00:36:41.000000000 -0700
@@ -570,7 +570,7 @@
if (ws && !targetflag) {
if (ws->nwild >= 9) {
DPRINT(DEBUG_ACL, acl_debug_level,
- ("Too many wildcards in ACL entry %s\n", entry->ae_name));
+ ("Too many wildcards in ACL entry.\n"));
}
else
ws->backref[ws->nwild++] = e2;
@@ -581,7 +581,7 @@
int n = e1->data[1] - '1';
if (n >= ws->nwild) {
DPRINT(DEBUG_ACL, acl_debug_level,
- ("Too many backrefs in ACL entry %s\n", entry->ae_name));
+ ("Too many backrefs in ACL entry.\n"));
}
else if ((ws->backref[n]->length == e2->length) &&
(!strncmp(ws->backref[n]->data, e2->data, e2->length)))
--- ./src/lib/kadm5/srv/server_acl.h.orig 2012-05-10 00:15:19.000000000 -0700
+++ ./src/lib/kadm5/srv/server_acl.h 2012-05-10 00:15:47.000000000 -0700
@@ -42,7 +42,7 @@
#define DEBUG_CALLS 128
#define DEBUG_NOSLAVES 256
#ifdef DEBUG
-#define DPRINT(l1, cl, al) if ((cl & l1) != 0) xprintf al
+#define DPRINT(l1, cl, al) if ((cl & l1) != 0) printf al
#else /* DEBUG */
#define DPRINT(l1, cl, al)
#endif /* DEBUG */
--- ./src/plugins/kdb/db2/libdb2/hash/hash_debug.c.orig 2012-05-10 00:41:06.000000000 -0700
+++ ./src/plugins/kdb/db2/libdb2/hash/hash_debug.c 2012-05-10 00:41:22.000000000 -0700
@@ -51,6 +51,7 @@
* __dump_bucket
*/
#include <stdio.h>
+#include <string.h>

#include "db-int.h"
#include "hash.h"

Fix -DDEBUG compilation errors

https://github.com/krb5/krb5/commit/7c3ecf5c77e33f6d04d6226b041071c6ce23b062
Author: Henry B. Hotz <hotz@jpl.nasa.gov>
Committer: Greg Hudson <ghudson@mit.edu>
Commit: 7c3ecf5c77e33f6d04d6226b041071c6ce23b062
Branch: master
src/appl/simple/server/sim_server.c | 1 +
src/lib/gssapi/spnego/gssapiP_spnego.h | 1 +
src/lib/kadm5/srv/server_acl.c | 4 ++--
src/lib/kadm5/srv/server_acl.h | 2 +-
src/plugins/kdb/db2/libdb2/hash/hash_debug.c | 1 +
5 files changed, 6 insertions(+), 3 deletions(-)

Thx.

On Jun 4, 2012, at 7:57 AM, Greg Hudson via RT wrote:


------------------------------------------------------
The opinions expressed in this message are mine,
not those of Caltech, JPL, NASA, or the US Government.
Henry.B.Hotz@jpl.nasa.gov, or hbhotz@oxy.edu