Ticket History #7353: assertion failure (possible memory corruption) when restarting putty session

# Mon Sep 10 13:35:24 2012 kaduk@MIT.EDU (Benjamin Kaduk) - Ticket created

Subject:

assertion failure (possible memory corruption) when restarting putty session

Download (untitled) / with headers
text/plain 810B

asedeno reports:
Start a (GSSAPI-authed) connection in PuTTY, pull the network connection so the putty
session drops, reenable network, and right-click the title bar to restart the connection.
Then, observe the "Assertion failed!" dialog box:

Program: C:\Users\zonetest\desktop\putty.exe
File: .\threads.c
Line: 337

Expression: destructors_set[keynum]==0

For more information on how your program can cause an assertion failure, see the Visual
C++ documentation on asserts.

(Press Retry to debug the application -- JIT must be enabled)
Abort/Retry/Ignore

When using the signed beta9 KfW, attaching visual studio and looking at the stack trace
seemed to implicate the gssapi32 library; however, doing a rebuild with debugging symbols
changes the stack trace so that our library is no longer included...

# Wed Sep 12 13:42:11 2012 kaduk@MIT.EDU (Benjamin Kaduk) - Given to kaduk@MIT.EDU (Benjamin Kaduk)

# Wed Sep 12 13:42:12 2012 kaduk@MIT.EDU (Benjamin Kaduk) - Status changed from 'new' to 'review'

# Wed Sep 12 13:42:12 2012 kaduk@MIT.EDU (Benjamin Kaduk) - Correspondence added

From:	kaduk@MIT.EDU
Subject:	SVN Commit

Download (untitled) / with headers
text/plain 789B

Unregister error message key on library unload

Revision fcdd2de1 added the K5_KEY_GSS_KRB5_ERROR_MESSAGE key, and
registered it in the gssapi library initialization routine, but
did not unregister it in the libary finalization routine.
When the library is unloaded and reloaded in the same process,
this leads to an assertion failure, since we check that
destructors_set[keynum] is zero (no destructor set) when registering
a key in util/support/threads.c.
Unregister the key on library cleanup to resolve the error.

https://github.com/krb5/krb5/commit/4ab584c830024757cc628b1783dde6220a9fec6d
Author: Ben Kaduk <kaduk@mit.edu>
Commit: 4ab584c830024757cc628b1783dde6220a9fec6d
Branch: master
src/lib/gssapi/krb5/gssapi_krb5.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

# Wed Sep 12 15:32:41 2012 tlyu (Taylor Yu) - Queue changed from kfw to krb5

# Wed Sep 12 15:32:59 2012 tlyu (Taylor Yu) - Target_Version 1.10.4 added

# Wed Sep 12 15:32:59 2012 tlyu (Taylor Yu) - Tags pullup added

# Wed Sep 12 15:56:25 2012 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'

# Wed Sep 12 15:56:25 2012 tlyu (Taylor Yu) - Version_Fixed 1.10.4 added

# Wed Sep 12 15:56:25 2012 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	SVN Commit

Download (untitled) / with headers
text/plain 895B

Unregister error message key on library unload

Revision fcdd2de1 added the K5_KEY_GSS_KRB5_ERROR_MESSAGE key, and
registered it in the gssapi library initialization routine, but
did not unregister it in the libary finalization routine.
When the library is unloaded and reloaded in the same process,
this leads to an assertion failure, since we check that
destructors_set[keynum] is zero (no destructor set) when registering
a key in util/support/threads.c.
Unregister the key on library cleanup to resolve the error.

(cherry picked from commit 4ab584c830024757cc628b1783dde6220a9fec6d)

https://github.com/krb5/krb5/commit/1d0c691e59f89df68413a6a41b951cfda88005e8
Author: Ben Kaduk <kaduk@mit.edu>
Committer: Tom Yu <tlyu@mit.edu>
Commit: 1d0c691e59f89df68413a6a41b951cfda88005e8
Branch: krb5-1.10
src/lib/gssapi/krb5/gssapi_krb5.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

# Wed Dec 16 18:02:58 2015 tlyu (Taylor Yu) - CustomField pullup deleted