Skip Menu |
 

Date: Tue, 25 Sep 2012 16:13:27 -0500
Subject: MAX_ULOGENTRIES is too low
From: Nico Williams <nico@cryptonector.com>
To: krb5-bugs@mit.edu
Download (untitled) / with headers
text/plain 1.1KiB
There's no reason to have a maximum on the number of entries
in the iprop ulog. This should just be removed.


diff --git a/src/include/kdb_log.h b/src/include/kdb_log.h
index beecdc1..c8d0288 100644
--- a/src/include/kdb_log.h
+++ b/src/include/kdb_log.h
@@ -53,7 +53,6 @@ extern "C" {
/*
* Default ulog file attributes
*/
-#define MAX_ULOGENTRIES 2500
#define DEF_ULOGENTRIES 1000
#define ULOG_IDLE_TIME 10 /* in seconds */
/*
diff --git a/src/lib/kadm5/alt_prof.c b/src/lib/kadm5/alt_prof.c
index d218640..b18bbd5 100644
--- a/src/lib/kadm5/alt_prof.c
+++ b/src/lib/kadm5/alt_prof.c
@@ -822,9 +822,7 @@ krb5_error_code kadm5_get_config_params(context,
use_kdc_config,
} else {
if (aprofile && !krb5_aprof_get_int32(aprofile, hierarchy,
TRUE, &ivalue)) {
- if (ivalue > MAX_ULOGENTRIES)
- params.iprop_ulogsize = MAX_ULOGENTRIES;
- else if (ivalue <= 0)
+ if (ivalue <= 0)
params.iprop_ulogsize = DEF_ULOGENTRIES;
else
params.iprop_ulogsize = ivalue;
From: ghudson@mit.edu
Subject: SVN Commit

Remove MAX_ULOGENTRIES

If a master KDC uses only a 64-bit libkadm5srv then there is no reason
to impose any limit on ulog size: the practical maximum will be given by
the filesystem and available storage space.

Even when using a 32-bit libkadm5srv the maximum practical ulog size
will be found easily enough when mmap() fails.

https://github.com/krb5/krb5/commit/1d7c107c9e9239674b5c7aed32931ab47c50f239
Author: Nicolas Williams <nico@cryptonector.com>
Committer: Greg Hudson <ghudson@mit.edu>
Commit: 1d7c107c9e9239674b5c7aed32931ab47c50f239
Branch: master
src/include/kdb_log.h | 1 -
src/lib/kadm5/alt_prof.c | 4 +---
2 files changed, 1 insertions(+), 4 deletions(-)