From yak@point-and-drool.mit.edu Mon Aug 9 21:31:29 1999
Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id VAA15559 for <bugs@RT-11.MIT.EDU>; Mon, 9 Aug 1999 21:31:29 -0400
Received: from POINT-AND-DROOL.MIT.EDU by MIT.EDU with SMTP
id AA05290; Mon, 9 Aug 99 21:31:40 EDT
Received: (from yak@localhost)
by point-and-drool.mit.edu (8.9.1/8.9.1) id VAA01730
for krb5-bugs@mit.edu; Mon, 9 Aug 1999 21:31:28 -0400 (EDT)
Message-Id: <199908100131.VAA01730@point-and-drool.mit.edu>
Date: Mon, 9 Aug 1999 21:31:28 -0400 (EDT)
From: Brad Thompson <yak@point-and-drool.mit.edu>
To: krb5-bugs@MIT.EDU
Subject: krb_sendauth_hidden_tkt_len
It's making my life unhappy for uninteresting reasons. It seems that it is
not actually used, though. The comments reference kcmd.c, which does not
touch it, or any of the things #define'd to it. I think we should make
the following patch:
*** sendauth.c.old Mon Aug 9 21:19:54 1999
--- sendauth.c Mon Aug 9 21:22:06 1999
***************
*** 107,124 ****
*
* See FIXME KLUDGE code in appl/bsd/kcmd.c.
*/
- KRB4_32 __krb_sendauth_hidden_tkt_len;
- #define raw_tkt_len __krb_sendauth_hidden_tkt_len -
/*
* Read a server's sendauth response out of a file descriptor.
* Returns a Kerberos error code.
- *
- * Note sneaky code using raw_tkt_len to stash away a bit of info
- * for use by appl/bsd/kcmd.c. Now that krb_net_rd_sendauth is
- * a separate function, kcmd should call it directly to get this
- * sneaky info.
*/
int
krb_net_rd_sendauth (fd, reply, raw_len)
--- 107,116 ----
***************
*** 230,235 ****
--- 222,229 ----
/* mutual authentication, if desired */
if (options & KOPT_DO_MUTUAL) {
+ KRB4_32 raw_tkt_len;
+
/* get credentials so we have service session
key for decryption below */
if (cc = krb_get_cred(service, srv_inst, realm, cred))
yak
(can't seem to get send-pr working on this box)
Responsible-Changed-From-To: gnats-admin->krb5-unassigned
Responsible-Changed-By: raeburn
Responsible-Changed-When: Sat Jun 23 01:30:16 2001
Responsible-Changed-Why:
Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id VAA15559 for <bugs@RT-11.MIT.EDU>; Mon, 9 Aug 1999 21:31:29 -0400
Received: from POINT-AND-DROOL.MIT.EDU by MIT.EDU with SMTP
id AA05290; Mon, 9 Aug 99 21:31:40 EDT
Received: (from yak@localhost)
by point-and-drool.mit.edu (8.9.1/8.9.1) id VAA01730
for krb5-bugs@mit.edu; Mon, 9 Aug 1999 21:31:28 -0400 (EDT)
Message-Id: <199908100131.VAA01730@point-and-drool.mit.edu>
Date: Mon, 9 Aug 1999 21:31:28 -0400 (EDT)
From: Brad Thompson <yak@point-and-drool.mit.edu>
To: krb5-bugs@MIT.EDU
Subject: krb_sendauth_hidden_tkt_len
Show quoted text
>Number: 737
>Category: krb5-libs
>Synopsis: krb_sendauth_hidden_tkt_len
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: krb5-unassigned
>State: open
>Class: sw-bug
>Submitter-Id: unknown
>Arrival-Date: Mon Aug 09 21:32:01 EDT 1999
>Last-Modified: Sat Jun 23 01:30:19 EDT 2001
>Originator: Brad Thompson <yak@point-and-drool.mit.edu>
>Organization:
>Release:
>Environment:
>Description:
So, there's this variable krb_sendauth_hidden_tkt_len in lib/krb4/sendauth.c.>Category: krb5-libs
>Synopsis: krb_sendauth_hidden_tkt_len
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: krb5-unassigned
>State: open
>Class: sw-bug
>Submitter-Id: unknown
>Arrival-Date: Mon Aug 09 21:32:01 EDT 1999
>Last-Modified: Sat Jun 23 01:30:19 EDT 2001
>Originator: Brad Thompson <yak@point-and-drool.mit.edu>
>Organization:
>Release:
>Environment:
>Description:
It's making my life unhappy for uninteresting reasons. It seems that it is
not actually used, though. The comments reference kcmd.c, which does not
touch it, or any of the things #define'd to it. I think we should make
the following patch:
*** sendauth.c.old Mon Aug 9 21:19:54 1999
--- sendauth.c Mon Aug 9 21:22:06 1999
***************
*** 107,124 ****
*
* See FIXME KLUDGE code in appl/bsd/kcmd.c.
*/
- KRB4_32 __krb_sendauth_hidden_tkt_len;
- #define raw_tkt_len __krb_sendauth_hidden_tkt_len -
/*
* Read a server's sendauth response out of a file descriptor.
* Returns a Kerberos error code.
- *
- * Note sneaky code using raw_tkt_len to stash away a bit of info
- * for use by appl/bsd/kcmd.c. Now that krb_net_rd_sendauth is
- * a separate function, kcmd should call it directly to get this
- * sneaky info.
*/
int
krb_net_rd_sendauth (fd, reply, raw_len)
--- 107,116 ----
***************
*** 230,235 ****
--- 222,229 ----
/* mutual authentication, if desired */
if (options & KOPT_DO_MUTUAL) {
+ KRB4_32 raw_tkt_len;
+
/* get credentials so we have service session
key for decryption below */
if (cc = krb_get_cred(service, srv_inst, realm, cred))
yak
(can't seem to get send-pr working on this box)
Show quoted text
>How-To-Repeat:
>Fix:
>Audit-Trail:
>Fix:
>Audit-Trail:
Responsible-Changed-From-To: gnats-admin->krb5-unassigned
Responsible-Changed-By: raeburn
Responsible-Changed-When: Sat Jun 23 01:30:16 2001
Responsible-Changed-Why:
Show quoted text
>Unformatted: