Ticket History #7553: sendto_kdc can invoke poll with negative timeout

# Thu Jan 24 19:35:29 2013 ghudson@mit.edu (Greg Hudson) - Ticket created

Subject:

sendto_kdc can invoke poll with negative timeout

Download (untitled) / with headers
text/plain 571B

Our select/poll wrapper in cm.c and sendto_kdc.c uses an absolute end
time. If an event occurs just prior to the end time and doesn't terminate
the service_fds loop, and we take a few milliseconds to process it, we
could wind up calling cm_select_or_poll after the end time has expired.
The select wrapper in cm.c is careful to check for this, but the poll
wrapper in sendto_kdc.c is not. If we invoke poll with a negative
timeout, it will wait indefinitely.

This issue was reported in a github pull request by Matthieu Hautreax
<matthieu.hautreux@gmail.com>.

# Fri Jan 25 13:29:21 2013 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)

# Fri Jan 25 13:29:25 2013 ghudson@mit.edu (Greg Hudson) - Target_Version 1.11.1 added

# Fri Jan 25 13:29:25 2013 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'review'

# Fri Jan 25 13:29:25 2013 ghudson@mit.edu (Greg Hudson) - Tags pullup added

# Fri Jan 25 13:29:25 2013 ghudson@mit.edu (Greg Hudson) - Correspondence added

From:	ghudson@mit.edu
Subject:	SVN Commit

Download (untitled) / with headers
text/plain 322B

Check for negative poll timeout in k5_sendto_kdc

https://github.com/krb5/krb5/commit/74bee54227deb64a41c2e79f57dd2a2c5ea010a3
Author: Greg Hudson <ghudson@mit.edu>
Commit: 74bee54227deb64a41c2e79f57dd2a2c5ea010a3
Branch: master
src/lib/krb5/os/sendto_kdc.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

# Fri Jan 25 13:29:53 2013 ghudson@mit.edu (Greg Hudson) - Comments added

Download (untitled) / with headers
text/plain 49B

This should also be pulled up to the 1.10 branch.

# Thu Jan 31 17:55:05 2013 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'

# Thu Jan 31 17:55:05 2013 tlyu (Taylor Yu) - Version_Fixed 1.11.1 added

# Thu Jan 31 17:55:05 2013 tlyu (Taylor Yu) - Correspondence added

From:	tlyu@mit.edu
Subject:	SVN Commit

Download (untitled) / with headers
text/plain 428B

Check for negative poll timeout in k5_sendto_kdc

(cherry picked from commit 74bee54227deb64a41c2e79f57dd2a2c5ea010a3)

https://github.com/krb5/krb5/commit/7c4c3962bad878cf7aae9c03e20cfe2ddf7474e9
Author: Greg Hudson <ghudson@mit.edu>
Committer: Tom Yu <tlyu@mit.edu>
Commit: 7c4c3962bad878cf7aae9c03e20cfe2ddf7474e9
Branch: krb5-1.11
src/lib/krb5/os/sendto_kdc.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

# Wed Dec 16 18:03:00 2015 tlyu (Taylor Yu) - CustomField pullup deleted