Skip Menu |
 

From: Gilles Espinasse <g.esp@free.fr>
To: krb5-bugs@mit.edu
Subject: [PATCH] krb5: fix crypto built-in no effect warning
Date: Wed, 8 May 2013 12:16:12 +0200
CC: Gilles Espinasse <g.esp@free.fr>
gcc complain with
aes.c:186: warning: statement with no effect

That look to never do something in the git history range.

Signed-off-by: Gilles Espinasse <g.esp@free.fr>
---
src/lib/crypto/builtin/enc_provider/aes.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/src/lib/crypto/builtin/enc_provider/aes.c b/src/lib/crypto/builtin/enc_provider/aes.c
index b46680a..c28f6d4 100644
--- a/src/lib/crypto/builtin/enc_provider/aes.c
+++ b/src/lib/crypto/builtin/enc_provider/aes.c
@@ -27,8 +27,6 @@
#include "crypto_int.h"
#include "aes.h"

-#define CHECK_SIZES 0
-
/*
* Private per-key data to cache after first generation. We don't
* want to mess with the imported AES implementation too much, so
@@ -183,8 +181,6 @@ krb5int_aes_decrypt(krb5_key key, const krb5_data *ivec, krb5_crypto_iov *data,
size_t input_length;
struct iov_block_state input_pos, output_pos;

- CHECK_SIZES;
-
if (key->cache == NULL) {
key->cache = malloc(sizeof(struct aes_key_info_cache));
if (key->cache == NULL)
--
1.7.2.5
This will be cleaned up in the aes-ni refactoring, so no need to act on
it. I'll close the issue when that code is merged.