Skip Menu |
 

History Show all quoted text — Show full headers
# Tue May 28 17:47:59 2013 Gilles Espinasse <g.esp@free.fr> - Ticket created
From: Gilles Espinasse <g.esp@free.fr>
To: krb5-bugs@mit.edu
Subject: [PATCH] krb5: change message macro for configure selection
Date: Tue, 28 May 2013 23:04:24 +0200
CC: Gilles Espinasse <g.esp@free.fr>
Download (untitled) / with headers
text/plain 2.3KiB
AC_MSG_RESULT is to print result after AC_MSG_CHECKING
AC_MSG_NOTICE is to deliver message to user.
So use AC_MSG_NOTICE for --with options

Remove overquoting too

Signed-off-by: Gilles Espinasse <g.esp@free.fr>
---
src/configure.in | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/configure.in b/src/configure.in
index 81eca47..2316497 100644
--- a/src/configure.in
+++ b/src/configure.in
@@ -132,7 +132,7 @@ CHECK_SIGNALS
AC_ARG_WITH([vague-errors],
AC_HELP_STRING([--with-vague-errors],[Do not @<:@do@:>@ send helpful errors to client]), , withval=no)
if test "$withval" = yes; then
- AC_MSG_RESULT(Supplying vague error messages to KDC clients)
+ AC_MSG_NOTICE(Supplying vague error messages to KDC clients)
AC_DEFINE(KRBCONF_VAGUE_ERRORS,1,[Define if the KDC should return only vague error codes to clients])
fi

@@ -142,7 +142,7 @@ CRYPTO_IMPL="builtin"
AC_ARG_WITH([crypto-impl],
AC_HELP_STRING([--with-crypto-impl=IMPL], [use specified crypto implementation @<:@builtin@:>@]),
[CRYPTO_IMPL=$withval
-AC_MSG_RESULT("k5crypto will use \'$withval\'")
+AC_MSG_NOTICE(k5crypto will use '$withval')
], withval=builtin)
case "$withval" in
builtin)
@@ -183,7 +183,7 @@ else
AC_ARG_WITH([prng-alg],
AC_HELP_STRING([--with-prng-alg=ALG], [use specified PRNG algorithm. Ignored for nss. @<:@fortuna@:>@]),
[PRNG_ALG=$withval
-AC_MSG_RESULT("k5crypto will use \'$withval\'")
+AC_MSG_NOTICE(k5crypto will use '$withval')
], PRNG_ALG=fortuna)
fi
AC_CONFIG_COMMANDS(PRNG_ALG, , PRNG_ALG=$PRNG_ALG)
@@ -198,7 +198,7 @@ PKINIT_CRYPTO_IMPL="$CRYPTO_IMPL"
AC_ARG_WITH([pkinit-crypto-impl],
AC_HELP_STRING([--with-pkinit-crypto-impl=IMPL], [use specified pkinit crypto implementation @<:@openssl@:>@]),
[PKINIT_CRYPTO_IMPL=$withval
-AC_MSG_RESULT("pkinit will use \'$withval\'")
+AC_MSG_NOTICE(pkinit will use '$withval')
], withval=$PKINIT_CRYPTO_IMPL)
case "$withval" in
builtin|openssl)
@@ -240,7 +240,7 @@ AC_SUBST(PKINIT_CRYPTO_IMPL_LIBS)
AC_ARG_WITH([kdc-kdb-update],
AC_HELP_STRING([--with-kdc-kdb-update],[Update the database @<:@don't update@:>@]), , withval=no)
if test "$withval" = yes; then
- AC_MSG_RESULT(Updating KDC database with each request)
+ AC_MSG_NOTICE(Updating KDC database with each request)
AC_DEFINE(KRBCONF_KDC_MODIFIES_KDB,1,[Define if KDC should update database with each request])
fi

--
1.7.10.4
# Wed May 29 12:15:32 2013 ghudson@mit.edu (Greg Hudson) - Given to ghudson@mit.edu (Greg Hudson)
# Wed May 29 12:15:32 2013 ghudson@mit.edu (Greg Hudson) - Status changed from 'new' to 'review'
# Wed May 29 12:15:32 2013 ghudson@mit.edu (Greg Hudson) - Correspondence added
From: ghudson@mit.edu
Subject: git commit
Download (untitled) / with headers
text/plain 524B

Change message macro for configure selection

AC_MSG_RESULT is to print result after AC_MSG_CHECKING.
AC_MSG_NOTICE is to deliver message to user.
So use AC_MSG_NOTICE for --with options.

Remove overquoting too.

https://github.com/krb5/krb5/commit/3db9bdef99ecec12a1ec3477e817381ddefc327f
Author: Gilles Espinasse <g.esp@free.fr>
Committer: Greg Hudson <ghudson@mit.edu>
Commit: 3db9bdef99ecec12a1ec3477e817381ddefc327f
Branch: master
src/configure.in | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
# Fri Oct 11 13:37:52 2013 tlyu (Taylor Yu) - Status changed from 'review' to 'resolved'
# Fri Oct 11 13:37:52 2013 tlyu (Taylor Yu) - Version_Fixed 1.12 added
# Fri Oct 11 14:28:42 2013 tlyu (Taylor Yu) - Subject changed from '[PATCH] krb5: change message macro for configure selection' to 'Change message macro for configure selection'