Skip Menu |
 

Download (untitled) / with headers
text/plain 2.6KiB
From kerberos-acl@MIT.EDU Sun Oct 10 22:16:31 1999
Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id WAA04550 for <bugs@RT-11.MIT.EDU>; Sun, 10 Oct 1999 22:16:31 -0400
Received: from GRAND-CENTRAL-STATION.MIT.EDU by MIT.EDU with SMTP
id AA09771; Sun, 10 Oct 99 22:16:36 EDT
Received: from melbourne-city-street.MIT.EDU (MELBOURNE-CITY-STREET.MIT.EDU [18.69.0.45])
by grand-central-station.MIT.EDU (8.9.2/8.9.2) with ESMTP id WAA12090
for <krb5-bugs@MIT.EDU>; Sun, 10 Oct 1999 22:16:29 -0400 (EDT)
Received: from small-gods.mit.edu (SMALL-GODS.MIT.EDU [18.177.0.248])
by melbourne-city-street.MIT.EDU (8.9.3/8.9.2) with ESMTP id WAA11227
for <krb5-bugs@mit.edu>; Sun, 10 Oct 1999 22:16:29 -0400 (EDT)
Received: (from ghudson@localhost) by small-gods.mit.edu (8.9.3)
id WAA10311; Sun, 10 Oct 1999 22:16:28 -0400 (EDT)
Message-Id: <199910110216.WAA10311@small-gods.mit.edu>
Date: Sun, 10 Oct 1999 22:16:28 -0400 (EDT)
From: ghudson@MIT.EDU
Reply-To: ghudson@MIT.EDU
To: krb5-bugs@MIT.EDU
Subject: Use of "errno" in prototype
X-Send-Pr-Version: 3.99

Show quoted text
>Number: 770
>Category: krb5-libs
>Synopsis: krb4 prototype uses parameter name "errno"
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: krb5-unassigned
>State: open
>Class: sw-bug
>Submitter-Id: unknown
>Arrival-Date: Sun Oct 10 22:17:01 EDT 1999
>Last-Modified:
>Originator: Greg Hudson
>Organization:
mit
Show quoted text
>Release: 1.0
>Environment:

System: SunOS small-gods.mit.edu 5.6 Generic_105181-13 sun4u sparc SUNW,Ultra-5_10
Architecture: sun4

Show quoted text
>Description:
errno is sometimes a macro. It should not be used as a parameter name
in prototypes.
Show quoted text
>How-To-Repeat:
Compile something using krb_get_err_text() with gcc -Wall.
Show quoted text
>Fix:
The function definition already uses "code".

Index: krb.h
===================================================================
RCS file: /afs/dev.mit.edu/source/repository/third/krb5/src/include/kerberosIV/krb.h,v
retrieving revision 1.9
diff -c -r1.9 krb.h
*** krb.h 1999/10/07 00:58:31 1.9
--- krb.h 1999/10/11 02:13:34
***************
*** 466,472 ****
PROTOTYPE((void));
/* err_txt.c */
KRB5_DLLIMP const char FAR * KRB5_CALLCONV krb_get_err_text
! PROTOTYPE((int errno));
/* g_ad_tkt.c */
int get_ad_tkt
PROTOTYPE((char *service, char *sinst, char *realm, int lifetime));
--- 466,472 ----
PROTOTYPE((void));
/* err_txt.c */
KRB5_DLLIMP const char FAR * KRB5_CALLCONV krb_get_err_text
! PROTOTYPE((int code));
/* g_ad_tkt.c */
int get_ad_tkt
PROTOTYPE((char *service, char *sinst, char *realm, int lifetime));
Show quoted text
>Audit-Trail:
>Unformatted:
Fixed long ago.