Ticket History #775: make check failed

From akw@slpmbo.ed.ray.com Sun Oct 24 16:48:35 1999
Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id QAA28668 for <bugs@RT-11.MIT.EDU>; Sun, 24 Oct 1999 16:48:35 -0400
Received: from dfw-gate1.raytheon.com by MIT.EDU with SMTP
id AA26093; Sun, 24 Oct 99 16:48:45 EDT
Received: from slpmbo.ed.ray.com (slpmbo.ed.ray.com [138.125.118.43])
by dfw-gate1.raytheon.com (8.9.3/8.9.3) with ESMTP id PAA06677
for <krb5-bugs@mit.edu>; Sun, 24 Oct 1999 15:48:25 -0500 (CDT)
Received: from slpmbu (slpmbu.ed.ray.com [138.125.33.128]) by slpmbo.ed.ray.com (8.9.1/8.8.2) with SMTP id QAA20145; Sun, 24 Oct 1999 16:48:23 -0400 (EDT)
Message-Id: <199910242048.QAA20145@slpmbo.ed.ray.com>
Date: Sun, 24 Oct 1999 16:48:23 -0400 (EDT)
From: Alvin Wong <akw@slpmbo.ed.ray.com>
Reply-To: Alvin Wong <akw@slpmbo.ed.ray.com>
To: krb5-bugs@MIT.EDU
Cc: akw@slpmbo.ed.ray.com
Subject: make check failed


Hello,

This is the first time I write to a Freeware organization.
If this is not the right way to report a problem or communicate,
please let me know how.

I was compiling on Solaris 5.7 Generic_106541-07 sun4m sparc SUNW,SPARCstation-20.
I used gcc version 2.95.1 19990816 (release)

Well, I encountered an error while doing "make check".

+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Here is the error:
==================
# make check
gcc -DHAVE_LIBSOCKET=1 -DHAVE_LIBNSL=1 -DSTDC_HEADERS=1 -DHAVE_STRCHR=1 -DHAVE_SYS_PARAM_H=1
-DHAVE_SYS_SOCKET_H=1 -DHAVE_COMPILE=1 -DHAVE_STEP=1 -DKRB5_KRB4_COMPAT -I./../../include -I../../include
-I./../../include/krb5 -I../../include/krb5 -DKRB5_KRB4_COMPAT -I./../../include -I../../include
-I./../../include/krb5 -I../../include/krb5 -c resolve.c -o resolve.o
gcc -L./../../lib -L./../../lib -o resolve resolve.o -lkrb5 -lcrypto -lcom_err -lnsl -lsocket
-lgen
./resolve
Hostname: slpmbu.ed.ray.com
Host address: 138.125.33.128
FQDN: slpmbu

Resolve library did not return a fully qualified domain name
You may have to reconfigure the kerberos distribution to select a
different set of libraries using --with-netlib[=libs]
make: *** [check] Error 3


The related section of code in krb5-1.0.6/src/tests/resolve/resolve.c:
======================================================================
122 if (quiet)
123 printf("%s\n", host->h_name);
124 else
125 printf("FQDN: %s\n", host->h_name);
126
127 if(strchr(host->h_name, '.') == NULL) {
128 fprintf(stderr, "\nResolve library did not return a fully qualified domain name\n");
129 fprintf(stderr, "You may have to reconfigure the kerberos distribution to select
a\ndifferent set of libraries using --with-netlib[=libs]\n");
130 exit(3);
131 }

My suggestion
=============
Modify line 127:

From: if(strchr(host->h_name, '.') == NULL) {

To : if(strchr(myname, '.') == NULL) {


+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Hope to get an answer soon. Please reply.

Alvin Wong


Responsible-Changed-From-To: gnats-admin->raeburn
Responsible-Changed-By: raeburn
Responsible-Changed-When: Tue Oct 26 22:02:35 1999
Responsible-Changed-Why:

I'll take it...



From: Ken Raeburn <raeburn@MIT.EDU>
To: akw@slpmbo.ed.ray.com
Cc: krb5-bugs@MIT.EDU
Subject: Re: krb5-misc/775: make check failed
Date: Tue, 26 Oct 1999 22:13:31 -0400 (EDT)

This is the first time I write to a Freeware organization.
If this is not the right way to report a problem or communicate,
please let me know how.

No, this is fine. We do include a program for submitting specially
formatted problem reports into our database, but plain mail is okay
too.

Resolve library did not return a fully qualified domain name
You may have to reconfigure the kerberos distribution to select a
different set of libraries using --with-netlib[=libs]

The patch you sent isn't correct. What we're testing in this case is
that the gethostbyname() and gethostbyaddr() calls will give us the
fully qualified domain name. Your patch would cause it to check only
the local hostname as returned by gethostname(), which tells us
nothing about whether domain name resolution is doing what we want.

It looks like the gethostbyaddr() call on your system is not returning
a fully qualified name first on the list for your own system's
address. I'd guess that the most likely cause is that
/etc/nsswitch.conf says something like "hosts: files dns" or "hosts:
files", which means that /etc/hosts should be consulted before the
domain name service, and your /etc/hosts file has a line starting with
"138.125.33.128 slpmbu ...", so that this non-qualified version of the
name is returned first.

If this is the case, you can re-order the line so that
"slpmbu.ed.ray.com" is the first name on that line after the address,
and similarly for any other hostnames you may have listed in that
file, and then the test should pass. (The test won't actually check
any other hostnames, but the Kerberos library code won't behave
properly if *any* server hostname it tries to use is not resolved to a
fully-qualified name.)

If that's not the problem, check with your sysadmin; there may be
other Solaris-specific things that could cause this that I'm not aware
of.

Let me know if this helps...

Ken

State-Changed-From-To: open-closed
State-Changed-By: raeburn
State-Changed-When: Wed Oct 27 18:04:58 1999
State-Changed-Why:

Message-Id: <199910271009.GAA26905@slpmbo.ed.ray.com>
Date: Wed, 27 Oct 1999 06:09:40 -0400 (EDT)
From: Alvin Wong <akw@slpmbo.ed.ray.com>
Reply-To: Alvin Wong <akw@slpmbo.ed.ray.com>
Subject: Re: krb5-misc/775: make check failed
To: raeburn@MIT.EDU
Cc: akw@slpmbo.ed.ray.com

Ken,

Thanks very much for replying (so promptly).
I did as you said and make check passed.

Thanks again.

Alvin